Skip to content

Commit b7f816c

Browse files
committed
Revert "Refactor parameter handling in JetCommand"
This reverts commit 6384523.
1 parent ba5e7ba commit b7f816c

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

src/EFCore.Jet.Data/JetCommand.cs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ protected virtual DbParameter ExtractParameter(string commandText, int count, Li
683683
var indices = GetParameterIndices(commandText[..count]);
684684
var parameter = parameters[indices.Count];
685685

686-
parameters.RemoveAt(indices.Count);
686+
parameters.RemoveAt(indices.Count);
687687

688688
return parameter;
689689
}
@@ -708,16 +708,19 @@ protected virtual void ExpandParameters()
708708
{
709709
MatchParametersAndPlaceholders(placeholders);
710710

711-
foreach (var placeholder in placeholders.Reverse())
711+
if (JetConnection.GetDataAccessProviderType(_connection.DataAccessProviderFactory) == DataAccessProviderType.Odbc)
712712
{
713-
InnerCommand.CommandText = InnerCommand.CommandText
714-
.Remove(placeholder.Index, placeholder.Name.Length)
715-
.Insert(placeholder.Index, "?");
713+
foreach (var placeholder in placeholders.Reverse())
714+
{
715+
InnerCommand.CommandText = InnerCommand.CommandText
716+
.Remove(placeholder.Index, placeholder.Name.Length)
717+
.Insert(placeholder.Index, "?");
718+
}
716719
}
717720

718721
InnerCommand.Parameters.Clear();
719722
InnerCommand.Parameters.AddRange(
720-
placeholders.Select(p => p.Parameter)
723+
placeholders.Select(p => p.Parameter)
721724
.ToArray());
722725
}
723726
else if (placeholders.All(t => t.Name == "?"))

0 commit comments

Comments
 (0)