Skip to content

add estateguru Penalty type and fix bookingdate #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flod1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add estateguru Penalty type and fix bookingdate #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/estateguru.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
type_regex: !!map
deposit: "^Einzahlung.*"
withdraw: "^Auszahlung.*"
interest: "(^Empfehlungsbonus.*)|(^Zins.*)|(^Sondervergütung.*)|(^Empfehlung.*)|(^Bonus.*)"
interest: "(^Empfehlungsbonus.*)|(^Zins.*)|(^Sondervergütung.*)|(^Empfehlung.*)|(^Bonus.*)|(^Strafe.*)"

csv_fieldnames: !!map
booking_date: 'Zahlungsdatum'
Expand Down
6 changes: 3 additions & 3 deletions config/estateguru_en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
type_regex: !!map
deposit: "^Deposit.*"
withdraw: "^Withdrawal.*"
interest: "(^Interest.*)|(^Indemnity.*)|(^Referral.*)|(^EG Bonus.*)|(^Secondary Market Profit.*)"
interest: "(^Interest.*)|(^Indemnity.*)|(^Referral.*)|(^EG Bonus.*)|(^Secondary Market Profit.*)|(^Penalty.*)"
fee: "(^Secondary Market Loss.*)|(^Fee.*)"

csv_fieldnames: !!map
booking_date: 'Payment Date'
booking_date_format: '%d/%m/%Y %H:%M'
booking_date: 'Confirmation Date'
booking_date_format: '%d.%m.%Y %H:%M'
Comment on lines -9 to +10

@ChrisRBe ChrisRBe Feb 24, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change requires an update of the unit test.

booking_details: 'Loan Code'
booking_id: 'ID'
booking_type: 'Cash Flow Type'
Expand Down