Simplify Set-WinUtilDNS.ps1#4663
Open
GabiNun2 wants to merge 6 commits into
Open
Conversation
ChrisTitusTech
added
the
Refactor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors DNS application behavior during tweak execution by skipping DNS updates when the provider is “Default”, and simplifies the DNS setter implementation.
Changes:
- Only call
Set-WinUtilDNSwhen a non-Defaultprovider is selected in the tweaks runspace. - Refactor
Set-WinUtilDNSto iterate active adapters and apply DNS settings per adapter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| functions/public/Invoke-WPFtweaksbutton.ps1 | Gates DNS application so DNS changes are only attempted when a non-default provider is selected. |
| functions/private/Set-WinUtilDNS.ps1 | Simplifies DNS-setting logic per “Up” adapter and consolidates how provider DNS values are applied. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description