fix: quote $ARGUMENTS in shell invocations#19
Open
xiaolai wants to merge 1 commit into
Open
Conversation
Unquoted \$ARGUMENTS in shell contexts is a word-splitting risk: if the AI constructs input containing spaces or shell metacharacters, the shell expands it into multiple tokens rather than treating it as a single argument, which can bypass tool restrictions or inject extra flags. - pr-review.md: gh pr view/diff "\$ARGUMENTS" - code-quality.md: npm run lint -- "\$ARGUMENTS" Co-Authored-By: Claude Code <noreply@anthropic.com>
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Finding (Low)
Two commands embed
$ARGUMENTSunquoted in shell code blocks:.claude/commands/pr-review.md.claude/commands/code-quality.mdWhen the shell (or AI-generated shell invocation) expands an unquoted variable, any whitespace or metacharacters in the value cause word-splitting. This means
$ARGUMENTScontaining spaces produces multiple tokens instead of one argument, which can:Bash(gh:*)restriction intent (extra tokens are separate arguments)npm run lintFix
Wrap the variable in double quotes in both files:
This is a minimal, targeted fix with no change to command behavior for well-formed input.