[!IMPORTANT] fix run service compatibility (#202)

* enums must be sent in lowercase
* renewjob must be called with SystemVssConnection token of job
* add PipelinesServiceUrl as ACTIONS_RUNTIME_URL

Author: ChristopherHX

actionsdotnetactcompat/act_worker.go

@@ -254,6 +254,9 @@ func ExecWorker(rqt *protocol.AgentJobRequestMessage, wc actionsrunner.WorkerCon
 	if resultsServiceUrl, ok := vssConnectionData["ResultsServiceUrl"]; ok && len(resultsServiceUrl) > 0 {
 		env["ACTIONS_RESULTS_URL"] = resultsServiceUrl
 	}
+	if pipelinesServiceUrl, ok := vssConnectionData["PipelinesServiceUrl"]; ok && len(pipelinesServiceUrl) > 0 {
+		env["ACTIONS_RUNTIME_URL"] = pipelinesServiceUrl
+	}
 	if uses_cache_service_v2, ok := rqt.Variables["actions_uses_cache_service_v2"]; ok && strings.EqualFold(uses_cache_service_v2.Value, "True") {
 		env["ACTIONS_CACHE_SERVICE_V2"] = "True" // bool.TrueString
 	}

actionsrunner/runner.go

@@ -488,16 +488,17 @@ func runJob(runnerenv RunnerEnvironment, joblock *sync.Mutex, vssConnection *pro
 			for {
 				var err error
 				if runServiceUrl != "" {
-					vssConnection = &con
+					jobVssConnection, _, _ := jobreq.GetConnection("SystemVssConnection")
+					jobVssConnection.Trace = con.Trace
 					renewjobUrl, _ := url.Parse(runServiceUrl)
 					renewjobUrl.Path = path.Join(renewjobUrl.Path, "renewjob")
-					vssConnection.TenantURL = runServiceUrl
+					jobVssConnection.TenantURL = runServiceUrl
 					payload := &runservice.RenewJobRequest{
 						PlanID: jobreq.Plan.PlanID,
 						JobID:  jobreq.JobID,
 					}
 					resp := &runservice.RenewJobResponse{}
-					err = vssConnection.RequestWithContext2(jobctx, "POST", renewjobUrl.String(), "", payload, &resp)
+					err = jobVssConnection.RequestWithContext2(jobctx, "POST", renewjobUrl.String(), "", payload, &resp)
 				} else {
 					err = con.RequestWithContext(jobctx, "fc825784-c92a-4299-9221-998a02d1b54f", "5.1-preview", "PATCH", map[string]string{
 						"poolId":    fmt.Sprint(instance.PoolID),

actionsrunner/worker_context.go

@@ -33,7 +33,7 @@ func (wc *DefaultWorkerContext) FinishJob(result string, outputs *map[string]pro
 		payload := &run.CompleteJobRequest{
 			PlanID:     wc.Message().Plan.PlanID,
 			JobID:      wc.Message().JobID,
-			Conclusion: result,
+			Conclusion: strings.ToLower(result),
 			Outputs:    nil,
 		}
 		if outputs != nil {

protocol/run/contracts.go

@@ -43,6 +43,14 @@ type StepResult struct {
 	Annotations       []Annotation `json:"annotations,omitempty"`
 }
 
+func toLowerStringP(p *string) *string {
+	if p == nil {
+		return nil
+	}
+	ret := strings.ToLower(*p)
+	return &ret
+}
+
 func TimeLineRecordToStepResult(rec protocol.TimelineRecord) StepResult {
 	annotations := make([]Annotation, len(rec.Issues))
 	for i, issue := range rec.Issues {
@@ -51,8 +59,8 @@ func TimeLineRecordToStepResult(rec protocol.TimelineRecord) StepResult {
 
 	return StepResult{
 		ExternalID:  rec.ID,
-		Conclusion:  rec.Result,
-		Status:      rec.State,
+		Conclusion:  toLowerStringP(rec.Result),
+		Status:      strings.ToLower(rec.State),
 		Number:      int(rec.Order),
 		Name:        rec.Name,
 		StartedAt:   rec.StartTime,