Skip to content

Commit d55601a

Browse files
Enhance sendLogFallback with reason parameter
1 parent 5c165f9 commit d55601a

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

protocol/logger/job_logger.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -193,14 +193,14 @@ func (logger *WebsocketLiveloggerWithFallback) Close() error {
193193
return logger.replace(&errorLogger{})
194194
}
195195

196-
func (logger *WebsocketLiveloggerWithFallback) sendLogFallback(err error, wrapper *protocol.TimelineRecordFeedLinesWrapper) {
196+
func (logger *WebsocketLiveloggerWithFallback) sendLogFallback(err error, reason string, wrapper *protocol.TimelineRecordFeedLinesWrapper) {
197197
if !logger.ForceWebsock {
198198
if logger.Connection.Trace {
199-
fmt.Printf("Failed to reconnect to websocket %s, fallback to vsslogger\n", err.Error())
199+
fmt.Printf("Failed to %s to websocket %s, fallback to vsslogger\n", reason, err.Error())
200200
}
201-
currentLogger = logger.initializeVssLogger()
201+
currentLogger := logger.initializeVssLogger()
202202
if currentLogger == nil {
203-
return fmt.Errorf("failed to initialize VSS logger after websocket reconnect failure: %w", err)
203+
return fmt.Errorf("failed to initialize VSS logger after websocket %s failure: %w", reason, err)
204204
}
205205
return currentLogger.SendLog(wrapper)
206206
}
@@ -222,11 +222,11 @@ func (logger *WebsocketLiveloggerWithFallback) SendLog(wrapper *protocol.Timelin
222222
}
223223
if wslogger, ok := currentLogger.(*WebsocketLivelogger); ok {
224224
if err = wslogger.Connect(); err != nil {
225-
return logger.sendLogFallback(err, wrapper)
225+
return logger.sendLogFallback(err, "reconnect", wrapper)
226226
}
227227
err = currentLogger.SendLog(wrapper)
228228
if err != nil {
229-
return logger.sendLogFallback(err, wrapper)
229+
return logger.sendLogFallback(err, "send", wrapper)
230230
}
231231
return nil
232232
}

0 commit comments

Comments
 (0)