fix

Author: ChristopherHX

actionsdotnetactcompat/action_cache.go

@@ -31,7 +31,7 @@ type ActionCacheBase struct {
 }
 
 // GetTarArchive implements runner.ActionCache.
-func (cache *ActionCacheBase) GetTarArchive(ctx context.Context, cacheDir string, sha string, includePrefix string) (io.ReadCloser, error) {
+func (cache *ActionCacheBase) GetTarArchive(ctx context.Context, cacheDir, sha, includePrefix string) (io.ReadCloser, error) {
 	pr, pw := io.Pipe()
 	cleanIncludePrefix := path.Clean(includePrefix)
 	go func() {
@@ -77,7 +77,7 @@ func (cache *ActionCacheBase) GetTarArchive(ctx context.Context, cacheDir string
 				_ = pw.CloseWithError(err)
 				return
 			}
-			_, err = io.Copy(writer, treader)
+			_, err = io.Copy(writer, treader) //nolint:gosec
 			if err != nil {
 				_ = pw.CloseWithError(err)
 				return
@@ -87,15 +87,16 @@ func (cache *ActionCacheBase) GetTarArchive(ctx context.Context, cacheDir string
 	return pr, nil
 }
 
-func fetchAction(ctx context.Context, target string, owner string, name string, resolvedSha string, tarURL string, token string, httpClient *http.Client) (targetFile string, reterr error) {
+func fetchAction(ctx context.Context, target, owner, name, resolvedSha, tarURL, token string, httpClient *http.Client,
+) (targetFile string, reterr error) {
 	logger := common.Logger(ctx)
 	cachedTar := filepath.Join(target, owner+"."+name+"."+resolvedSha+".tar")
 	defer func() {
 		if reterr != nil {
 			_ = os.Remove(cachedTar)
 		}
 	}()
-	if fr, err := os.Open(cachedTar); err == nil {
+	if fr, err := os.Open(cachedTar); err == nil { //nolint:gosec
 		defer func() { _ = fr.Close() }()
 		if logger != nil {
 			logger.Infof("Found cache for action %v/%v (sha:%v) from %v", owner, name, resolvedSha, cachedTar)
@@ -124,7 +125,7 @@ func fetchAction(ctx context.Context, target string, owner string, name string,
 			_, _ = io.Copy(buf, rsp.Body)
 			return "", fmt.Errorf("failed to download action from %v response %v", tarURL, buf.String())
 		}
-		fo, err := os.Create(cachedTar)
+		fo, err := os.Create(cachedTar) //nolint:gosec
 		if err != nil {
 			return "", err
 		}

actionsdotnetactcompat/launch_action_cache.go

@@ -19,7 +19,7 @@ type LaunchActionCache struct {
 }
 
 // Fetch implements runner.ActionCache.
-func (cache *LaunchActionCache) Fetch(ctx context.Context, cacheDir string, url string, ref string, token string) (string, error) {
+func (cache *LaunchActionCache) Fetch(ctx context.Context, cacheDir, url, ref, token string) (string, error) {
 	actionList := &launch.ActionReferenceRequestList{}
 	actionurl := strings.Split(url, "/")
 	actionurl = actionurl[len(actionurl)-2:]
@@ -40,7 +40,7 @@ func (cache *LaunchActionCache) Fetch(ctx context.Context, cacheDir string, url
 		return "", err
 	}
 
-	for _, v := range actionDownloadInfo.Actions {
+	for _, v := range actionDownloadInfo.Actions { //nolint:dupl
 		token := cache.GHToken
 		if v.Authentication != nil && v.Authentication.Token != "" {
 			token = v.Authentication.Token

actionsdotnetactcompat/vss_action_cache.go

@@ -16,7 +16,7 @@ type VssActionCache struct {
 }
 
 // Fetch implements runner.ActionCache.
-func (cache *VssActionCache) Fetch(ctx context.Context, cacheDir string, url string, ref string, token string) (string, error) {
+func (cache *VssActionCache) Fetch(ctx context.Context, cacheDir, url, ref, token string) (string, error) {
 	actionList := &protocol.ActionReferenceList{}
 	actionurl := strings.Split(url, "/")
 	actionurl = actionurl[len(actionurl)-2:]
@@ -32,7 +32,7 @@ func (cache *VssActionCache) Fetch(ctx context.Context, cacheDir string, url str
 	if err != nil {
 		return "", err
 	}
-	for _, v := range actionDownloadInfo.Actions {
+	for _, v := range actionDownloadInfo.Actions { //nolint:dupl
 		token := cache.GHToken
 		if v.Authentication != nil && v.Authentication.Token != "" {
 			token = v.Authentication.Token