Skip to content

Atomic logger#238

Merged
ChristopherHX merged 21 commits into
mainfrom
atomic-logger
Mar 18, 2026
Merged

Atomic logger#238
ChristopherHX merged 21 commits into
mainfrom
atomic-logger

Conversation

@ChristopherHX
Copy link
Copy Markdown
Owner

@ChristopherHX ChristopherHX commented Mar 7, 2026

Make logger code async safe, public interface kept

  • add some panic handler to not affect the whole runner in case of failure

REF #211

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the job logging implementation concurrency-safe (while keeping the public interface unchanged), addressing crashes seen during job execution/restarts (ref: issue #211).

Changes:

  • Switched websocket connection handling to atomic.Pointer to avoid races when closing/reconnecting.
  • Refactored WebsocketLiveloggerWithFallback to use atomic swapping of the active logger.
  • Refactored BufferedLiveLogger to initialize/teardown its internal channels via an atomic state pointer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread protocol/logger/job_logger.go
Comment thread protocol/logger/job_logger.go Outdated
Comment thread protocol/logger/job_logger.go Outdated
Comment thread protocol/logger/job_logger.go Outdated
Comment thread protocol/logger/job_logger.go
Copy link
Copy Markdown

Copilot AI commented Mar 7, 2026

@ChristopherHX I've opened a new pull request, #239, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread protocol/logger/job_logger.go Outdated
Comment thread protocol/logger/job_logger.go Outdated
Comment thread protocol/logger/job_logger_test.go
Comment thread actionsdotnetactcompat/action_cache.go Outdated
ChristopherHX and others added 5 commits March 18, 2026 16:30
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread protocol/logger/job_logger.go
Comment thread protocol/logger/job_logger.go
Comment thread protocol/logger/job_logger.go Outdated
Comment thread protocol/logger/job_logger.go
Comment thread protocol/logger/job_logger_test.go
ChristopherHX and others added 4 commits March 18, 2026 16:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ChristopherHX and others added 2 commits March 18, 2026 17:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ChristopherHX ChristopherHX merged commit ce2ce47 into main Mar 18, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants