Atomic logger#238
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make the job logging implementation concurrency-safe (while keeping the public interface unchanged), addressing crashes seen during job execution/restarts (ref: issue #211).
Changes:
- Switched websocket connection handling to
atomic.Pointerto avoid races when closing/reconnecting. - Refactored
WebsocketLiveloggerWithFallbackto use atomic swapping of the active logger. - Refactored
BufferedLiveLoggerto initialize/teardown its internal channels via an atomic state pointer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ChristopherHX I've opened a new pull request, #239, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Make logger code async safe, public interface kept
REF #211