Atomic logger

actionsdotnetactcompat/action_cache.go

@@ -8,10 +8,12 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"log"
 	"net/http"
 	"os"
 	"path"
 	"path/filepath"
+	"runtime/debug"
 	"strings"
 
 	"github.com/actions-oss/act-cli/pkg/common"
@@ -35,7 +37,14 @@ func (cache *ActionCacheBase) GetTarArchive(ctx context.Context, cacheDir, sha,
 	pr, pw := io.Pipe()
 	cleanIncludePrefix := path.Clean(includePrefix)
 	go func() {
-		defer func() { _ = pw.Close() }()
+		defer func() {
+			if r := recover(); r != nil {
+				log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+				_ = pw.CloseWithError(fmt.Errorf("panic recovered in GetTarArchive: %v", r))
+				return
+			}
+			_ = pw.Close()
+		}()
 		writer := tar.NewWriter(pw)
 		defer func() { _ = writer.Close() }()
 		reader, err := os.Open(cache.mapping[cacheDir+"@"+sha])

actionsrunner/runner.go

@@ -7,6 +7,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"log"
 	"net/http"
 	"net/url"
 	"path"
@@ -152,6 +153,11 @@ func (run *RunRunner) Run(runnerenv RunnerEnvironment, listenerctx, corectx cont
 		for _, instance := range settings.Instances {
 			//nolint:gosec
 			go func(instance *runnerconfiguration.RunnerInstance) (exitcode int) {
+				defer func() {
+					if r := recover(); r != nil {
+						log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+					}
+				}()
 				defer wg.Done()
 				defer func() {
 					// Without this the inner return 1 got lost and we would retry it
@@ -189,6 +195,11 @@ func (run *RunRunner) Run(runnerenv RunnerEnvironment, listenerctx, corectx cont
 						Result:    result,
 					}
 					go func() {
+						defer func() {
+							if r := recover(); r != nil {
+								log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+							}
+						}()
 						for i := 0; ; i++ {
 							if err := vssConnection.FinishJob(finish, jobrun.Plan); err != nil {
 								runnerenv.Printf("Failed to finish previous stuck job with Status Failed: %v\n", err.Error())
@@ -450,6 +461,11 @@ func runJob(runnerenv RunnerEnvironment, joblock *sync.Mutex, vssConnection *pro
 	session *protocol.AgentMessageConnection, message protocol.TaskAgentMessage, instance *runnerconfiguration.RunnerInstance,
 ) {
 	go func() {
+		defer func() {
+			if r := recover(); r != nil {
+				log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+			}
+		}()
 		plogger := &PrefixConsoleLogger{
 			Parent: runnerenv,
 			Prefix: fmt.Sprintf("%v ( %v ):", instance.Agent.Name, instance.RegistrationURL),
@@ -539,6 +555,11 @@ func runJob(runnerenv RunnerEnvironment, joblock *sync.Mutex, vssConnection *pro
 		}
 		con := *vssConnection
 		go func() {
+			defer func() {
+				if r := recover(); r != nil {
+					log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+				}
+			}()
 			for {
 				renewErr := renewJob(jobctx, runServiceURL, jobreq, &con, instance)
 				if renewErr != nil {

main.go

@@ -9,9 +9,11 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"log"
 	"os"
 	"os/signal"
 	"runtime"
+	"runtime/debug"
 	"strings"
 	"syscall"
 
@@ -120,6 +122,11 @@ func (run *RunRunner) Run() int {
 	listenerctx, cancelListener := context.WithCancel(context.Background())
 	defer cancelListener()
 	go func() {
+		defer func() {
+			if r := recover(); r != nil {
+				log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+			}
+		}()
 		sig := <-channel
 		if sig == syscall.SIGTERM {
 			fmt.Println("SIGTERM received, cancel any current job and wait for completion")
@@ -215,15 +222,18 @@ func (svc *RunRunnerSvc) Start(s service.Service) error {
 		runner.Terminal = terminal
 	}
 
-	//nolint:gosec
 	ctx, cancel := context.WithCancel(context.Background())
-	//nolint:gosec
 	listenerctx, cancelListener := context.WithCancel(context.Background())
 	svc.stop = func() {
 		cancelListener()
 	}
 	svc.wait = make(chan error)
 	go func() {
+		defer func() {
+			if r := recover(); r != nil {
+				log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+			}
+		}()
 		defer cancelListener()
 		defer cancel()
 		defer close(svc.wait)
@@ -404,6 +414,11 @@ func main() {
 			ccontext, cancelccontext := context.WithCancel(context.Background())
 			defer cancelccontext()
 			go func() {
+				defer func() {
+					if r := recover(); r != nil {
+						log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+					}
+				}()
 				execcontext, cancelExec := context.WithCancel(context.Background())
 				defer cancelExec()
 				buf := make([]byte, bufferSize)
@@ -431,6 +446,11 @@ func main() {
 							fmt.Printf("unmarshal job request: %v", err)
 						}
 						go func() {
+							defer func() {
+								if r := recover(); r != nil {
+									log.Printf("panic recovered: %v\n%s", r, debug.Stack())
+								}
+							}()
 							defer cancelExec()
 							defer cancelccontext()
 							wc := &actionsrunner.DefaultWorkerContext{