Skip to content

Commit 9b5807d

Browse files
restore net6.0 compat (#625)
1 parent bd300ee commit 9b5807d

1 file changed

Lines changed: 12 additions & 8 deletions

File tree

src/Runner.Listener/Runner.cs

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -876,15 +876,15 @@ private void HandleAuthMigrationChanged(object sender, AuthMigrationEventArgs e)
876876

877877
private async Task CheckOAuthTokenClaimsAsync(CancellationToken token)
878878
{
879-
string[] expectedClaims =
880-
[
879+
string[] expectedClaims = new string[]
880+
{
881881
"owner_id",
882882
"runner_id",
883883
"runner_group_id",
884884
"scale_set_id",
885885
"is_ephemeral",
886886
"labels"
887-
];
887+
};
888888

889889
try
890890
{
@@ -949,12 +949,15 @@ v2Token is VssOAuthAccessToken v2AccessToken &&
949949
var v2Claims = v2Jwt.ExtractClaims();
950950

951951
// Log extracted claims for debugging
952-
Trace.Verbose($"Baseline token expected claims: {string.Join(", ", baselineClaims
952+
var baselineClaimsString = string.Join(", ", baselineClaims
953953
.Where(c => expectedClaims.Contains(c.Type.ToLowerInvariant()))
954-
.Select(c => $"{c.Type}:{c.Value}"))}");
955-
Trace.Verbose($"V2 token expected claims: {string.Join(", ", v2Claims
954+
.Select(c => $"{c.Type}:{c.Value}"));
955+
Trace.Verbose($"Baseline token expected claims: {baselineClaimsString}");
956+
957+
var v2ClaimsString = string.Join(", ", v2Claims
956958
.Where(c => expectedClaims.Contains(c.Type.ToLowerInvariant()))
957-
.Select(c => $"{c.Type}:{c.Value}"))}");
959+
.Select(c => $"{c.Type}:{c.Value}"));
960+
Trace.Verbose($"V2 token expected claims: {v2ClaimsString}");
958961

959962
foreach (var claim in expectedClaims)
960963
{
@@ -965,8 +968,9 @@ v2Token is VssOAuthAccessToken v2AccessToken &&
965968
var v2Claim = v2Claims.FirstOrDefault(c => c.Type.ToLowerInvariant() == claim);
966969
if (v2Claim?.Value != baselineClaim.Value)
967970
{
971+
var expectedClaimString = $"Expected claim {baselineClaim.Type}:{baselineClaim.Value} does not match {v2Claim?.Type ?? "Empty"}:{v2Claim?.Value ?? "Empty"}";
968972
Trace.Info($"Token Claim mismatch between two issuers. Expected: {baselineClaim.Type}:{baselineClaim.Value}. Actual: {v2Claim?.Type ?? "Empty"}:{v2Claim?.Value ?? "Empty"}");
969-
HostContext.DeferAuthMigration(TimeSpan.FromMinutes(60), $"Expected claim {baselineClaim.Type}:{baselineClaim.Value} does not match {v2Claim?.Type ?? "Empty"}:{v2Claim?.Value ?? "Empty"}");
973+
HostContext.DeferAuthMigration(TimeSpan.FromMinutes(60), expectedClaimString);
970974
break;
971975
}
972976
}

0 commit comments

Comments
 (0)