Support Gitea Absolute Actions via Feature Flag (#563)

* including tokens
* system.runner.server.absolute_actions

Author: ChristopherHX

src/Runner.Server/Controllers/ActionDownloadInfoController.cs

@@ -124,11 +124,20 @@ public async Task<IActionResult> Get(Guid scopeIdentifier, string hubName, Guid
                         ActionDownloadInfo defDownloadInfo = null;
                         foreach(var downloadUrl in downloadUrls) {
                             try {
-                                var downloadinfo = new ActionDownloadInfo() {NameWithOwner = item.NameWithOwner, Ref = item.Ref, ResolvedNameWithOwner = item.NameWithOwner, ResolvedSha = item.Ref };
+                                // : is otherwise put on the filesystem and windows forbids it
+                                var sanitizedNameWithOwner = item.NameWithOwner;//.Replace("://", "__");
+                                var downloadinfo = new ActionDownloadInfo() {NameWithOwner = sanitizedNameWithOwner, Ref = item.Ref, ResolvedNameWithOwner = sanitizedNameWithOwner, ResolvedSha = item.Ref };
                                 // Allow access to the original action
                                 if(islocalcheckout && item.NameWithOwner == localcheckout && item.Ref.StartsWith(BuildConstants.Source.CommitHash)) {
                                     item.Ref = item.Ref.Substring(BuildConstants.Source.CommitHash.Length);
                                 }
+                                if(item.NameWithOwner.StartsWith("http~//") || item.NameWithOwner.StartsWith("https~//")) {
+                                    downloadinfo.TarballUrl = item.NameWithOwner.Replace('~', ':') + "/archive/" + item.Ref + ".tar.gz";
+                                    downloadinfo.ZipballUrl = item.NameWithOwner.Replace('~', ':') + "/archive/" + item.Ref + ".zip";
+                                    downloadinfo.Authentication = new ActionDownloadAuthentication() { Token = "dummy-token" };
+                                    actions[name] = downloadinfo;
+                                    break;
+                                }
                                 downloadinfo.TarballUrl = String.Format(downloadUrl.TarballUrl, item.NameWithOwner, item.Ref);
                                 downloadinfo.ZipballUrl = String.Format(downloadUrl.ZipballUrl, item.NameWithOwner, item.Ref);
                                 if(defDownloadInfo == null) {

src/Runner.Server/Controllers/MessageController.cs

@@ -637,6 +637,8 @@ private static TemplateContext CreateTemplateContext(GitHub.DistributedTask.Obje
             if(context.HasFeature("system.runner.server.FailInvalidActionsIfExpression")) {
                 flags |= ExpressionFlags.FailInvalidActionsIfExpression;
             }
+            // For Gitea Actions
+            var absoluteActions = context.HasFeature("system.runner.server.absolute_actions");
             var templateContext = new TemplateContext() {
                 Flags = flags,
                 CancellationToken = CancellationToken.None,
@@ -646,7 +648,8 @@ private static TemplateContext CreateTemplateContext(GitHub.DistributedTask.Obje
                     maxEvents: 1000000,
                     maxBytes: 10 * 1024 * 1024),
                 TraceWriter = traceWriter,
-                Schema = PipelineTemplateSchemaFactory.GetSchema()
+                Schema = PipelineTemplateSchemaFactory.GetSchema(),
+                AbsoluteActions = absoluteActions,
             };
             if(context.FeatureToggles.TryGetValue("system.runner.server.workflow_schema", out var workflow_schema)) {
                 var objectReader = new JsonObjectReader(null, workflow_schema);

src/Runner.Worker/ActionManager.cs

@@ -205,6 +205,11 @@ public sealed class ActionManager : RunnerService, IActionManager
                         throw new Exception($"Missing download info for {lookupKey}");
                     }
 
+                    if (action.Reference is Pipelines.RepositoryPathReference repoAction && repoAction.Token != null)
+                    {
+                        downloadInfo.Authentication = new ActionDownloadAuthentication { Token = repoAction.Token };
+                    }
+
                     await DownloadRepositoryActionAsync(executionContext, downloadInfo);
                 }
 

src/Runner.Worker/ActionManifestManager.cs

@@ -328,6 +328,8 @@ private TemplateContext CreateTemplateContext(
             if(executionContext.Global.Variables.GetBoolean("system.runner.server.FailInvalidActionsIfExpression") == true) {
                 flags |= ExpressionFlags.FailInvalidActionsIfExpression;
             }
+            // For Gitea Actions
+            var absoluteActions = executionContext.Global.Variables.GetBoolean("system.runner.server.absolute_actions") == true;
             var result = new TemplateContext
             {
                 Flags = flags,
@@ -339,6 +341,7 @@ private TemplateContext CreateTemplateContext(
                     maxBytes: 10 * 1024 * 1024),
                 Schema = schema,
                 TraceWriter = executionContext.ToTemplateTraceWriter(),
+                AbsoluteActions = absoluteActions,
             };
 
             // Expression values from execution context

src/Sdk/DTObjectTemplating/ObjectTemplating/TemplateContext.cs

@@ -33,6 +33,7 @@ internal class AutoCompleteEntry {
     public sealed class TemplateContext
     {
         public ExpressionFlags Flags { get; set; }
+        public bool AbsoluteActions { get; set; }
         internal CancellationToken CancellationToken { get; set; }
 
         public int? Column { get; set; }

src/Sdk/DTPipelines/Pipelines/ActionStepDefinitionReference.cs

@@ -79,6 +79,7 @@ private RepositoryPathReference(RepositoryPathReference referenceToClone)
             this.Ref = referenceToClone.Ref;
             this.RepositoryType = referenceToClone.RepositoryType;
             this.Path = referenceToClone.Path;
+            this.Token = referenceToClone.Token;
         }
 
         [DataMember(EmitDefaultValue = false)]
@@ -124,6 +125,16 @@ public string Path
             set;
         }
 
+        /// <summary>
+        /// For Gitea Basic Auth Token
+        /// </summary>
+        [DataMember(EmitDefaultValue = false)]
+        public string Token
+        {
+            get;
+            set;
+        }
+
         public override ActionStepDefinitionReference Clone()
         {
             return new RepositoryPathReference(this);

src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConverter.cs

@@ -563,6 +563,29 @@ private static ActionStep ConvertToStep(
                     var usesSegments = uses.Value.Split('@');
                     var pathSegments = usesSegments[0].Split(new[] { '/', '\\' }, StringSplitOptions.RemoveEmptyEntries);
                     var gitRef = usesSegments.Length == 2 ? usesSegments[1] : String.Empty;
+                    string token = null;
+                    if(usesSegments.Length >= 2 && usesSegments.Length <= 3 && context.AbsoluteActions)
+                    {
+                        foreach (var proto in new [] {"http://", "https://"})
+                        {
+                            if (usesSegments[0].StartsWith(proto))
+                            {
+                                // Includes basic auth
+                                if (usesSegments.Length == 3)
+                                {
+                                    usesSegments = new string[] { string.Join("@", usesSegments.Take(2)), usesSegments[2] };
+                                    // Remove auth part and extract the token for loading
+                                    var absoluteUrl = new Uri(usesSegments[0]);
+                                    usesSegments[0] = absoluteUrl.GetComponents(UriComponents.AbsoluteUri & ~UriComponents.UserInfo, UriFormat.UriEscaped);
+                                    token = string.Join(":", absoluteUrl.UserInfo?.Split(':').Skip(1));
+                                    gitRef = usesSegments[1];
+                                }
+                                pathSegments = usesSegments[0].Substring(proto.Length).Split('/');
+                                pathSegments = pathSegments.Skip(2).Prepend((proto + string.Join("/", pathSegments.Take(2))).Replace(':', '~')).ToArray();
+                                break;
+                            }
+                        }
+                    }
 
                     if (usesSegments.Length != 2 ||
                         pathSegments.Length < 2 ||
@@ -584,6 +607,7 @@ private static ActionStep ConvertToStep(
                             Name = repositoryName,
                             Ref = gitRef,
                             Path = directoryPath,
+                            Token = token,
                         };
                     }
                 }