azp: fix vscode extension path handling problem + add test framework (#599)

* azp: improve url joining

* add basic test to extension

* update timeout

Author: ChristopherHX

.github/workflows/deploy-pages.yml

@@ -43,6 +43,9 @@ jobs:
           node_modules/.bin/vsce pack -o azure-pipelines-vscode-ext.vsix
           node_modules/.bin/vsce pack --pre-release -o azure-pipelines-vscode-ext-pre-release.vsix
         working-directory: src/azure-pipelines-vscode-ext
+      - name: Run azure-pipelines-vscode-ext Tests
+        run: ${{ runner.os == 'Linux' && 'xvfb-run -a ' || ''}}npm test
+        working-directory: src/azure-pipelines-vscode-ext      
       - name: Build runner-server-vscode
         run: |
           npm install

src/azure-pipelines-vscode-ext/CHANGELOG.md

@@ -1,3 +1,7 @@
+### v0.3.1
+- remove additional space caused by export task as Cli Command
+- fix saving a single untitled pipeline file from browser broke syntax checker due to invalid uri joining
+
 ### v0.3.1 (Preview)
 - fix -q flag had no space between cli command and hypen
 - rename command of v0.3.1 to `Copy Azure Pipeline Linter Task as Cli Command for use in CI or debugging`

src/azure-pipelines-vscode-ext/index.js

@@ -1,13 +1,13 @@
 const vscode = require('vscode');
 import { basePaths, customImports } from "./config.js"
 import { AzurePipelinesDebugSession } from "./azure-pipelines-debug";
-import { integer, Position } from "vscode-languageclient";
+import { integer } from "vscode-languageclient";
 import jsYaml from "js-yaml";
 import { applyEdits, modify } from "jsonc-parser";
 import vsVars from "vscode-variables";
 
 function joinPath(l, r) {
-	return l ? l + "/" + r : r;
+	return l ? l.replace(/\/+$/g, '') + "/" + r.replace(/^\/+/g, '') : r;
 }
 
 function cliQuote(str) {
@@ -621,7 +621,7 @@ function activate(context) {
 								}
 							}
 						}
-						await vscode.env.clipboard.writeText(`Runner.Client azexpand -W ${cliQuote(filename)} ${parameters ? Object.entries(parameters).reduce((p, c) => `${p} --input ${cliQuote(`${c[0]}=${typeof c[1] === 'object' ? JSON.stringify(c[1]) : c[1]}`)}`, "") : ""}${variables ? Object.entries(variables).reduce((p, c) => `${p} --var ${cliQuote(`${c[0]}=${c[1]}'`)}`, "") : ""}${flags}`);
+						await vscode.env.clipboard.writeText(`Runner.Client azexpand -W ${cliQuote(filename)}${parameters ? Object.entries(parameters).reduce((p, c) => `${p} --input ${cliQuote(`${c[0]}=${typeof c[1] === 'object' ? JSON.stringify(c[1]) : c[1]}`)}`, "") : ""}${variables ? Object.entries(variables).reduce((p, c) => `${p} --var ${cliQuote(`${c[0]}=${c[1]}'`)}`, "") : ""}${flags}`);
 						await vscode.window.showInformationMessage("Copied to clipboard");
 						return;
 					}