Skip to content

Commit 16f1ee0

Browse files
committed
changing category in mcp-cli-options
1 parent e8d943b commit 16f1ee0

4 files changed

Lines changed: 30 additions & 19 deletions

File tree

src/bin/chrome-devtools-mcp-cli-options.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,10 @@ export const cliOptions = {
237237
describe:
238238
'Set to true to include tools related to extensions. Note: This feature is currently only supported with a pipe connection. autoConnect, browserUrl, and wsEndpoint are not supported with this feature until 149 will be released.',
239239
},
240-
categoryInPageTools: {
240+
categoryExperimentalInPage: {
241241
type: 'boolean',
242242
hidden: true,
243+
default: false,
243244
describe:
244245
'Set to true to enable tools exposed by the inspected page itself',
245246
},

src/telemetry/flag_usage_metrics.json

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,11 +192,13 @@
192192
},
193193
{
194194
"name": "category_in_page_tools",
195-
"flagType": "boolean"
195+
"flagType": "boolean",
196+
"isDeprecated": true
196197
},
197198
{
198199
"name": "category_in_page_tools_present",
199-
"flagType": "boolean"
200+
"flagType": "boolean",
201+
"isDeprecated": true
200202
},
201203
{
202204
"name": "clearcut_endpoint_present",
@@ -265,5 +267,13 @@
265267
{
266268
"name": "via_cli_present",
267269
"flagType": "boolean"
270+
},
271+
{
272+
"name": "category_experimental_in_page_present",
273+
"flagType": "boolean"
274+
},
275+
{
276+
"name": "category_experimental_in_page",
277+
"flagType": "boolean"
268278
}
269279
]

tests/McpResponse.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,7 +1111,7 @@ describe('inPage tools', () => {
11111111
t.assert.snapshot?.(JSON.stringify(structuredContent, null, 2));
11121112
},
11131113
undefined,
1114-
{categoryInPageTools: true} as ParsedArguments,
1114+
{categoryExperimentalInPage: true} as ParsedArguments,
11151115
);
11161116
});
11171117

@@ -1162,14 +1162,14 @@ describe('inPage tools', () => {
11621162
);
11631163
},
11641164
undefined,
1165-
{categoryInPageTools: true} as ParsedArguments,
1165+
{categoryExperimentalInPage: true} as ParsedArguments,
11661166
);
11671167
}
11681168

11691169
it('includes in-page tools in list_pages response', async () => {
11701170
await testIncludesInPageTools(async (response, context) => {
11711171
const listPagesDef = listPages({
1172-
categoryInPageTools: true,
1172+
categoryExperimentalInPage: true,
11731173
} as ParsedArguments);
11741174
await listPagesDef.handler({params: {}}, response, context);
11751175
}, 'list_pages');

tests/tools/inPage.test.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ describe('inPage', () => {
7272
});
7373
},
7474
undefined,
75-
{categoryInPageTools: true} as ParsedArguments,
75+
{categoryExperimentalInPage: true} as ParsedArguments,
7676
);
7777
});
7878

@@ -102,7 +102,7 @@ describe('inPage', () => {
102102
);
103103
},
104104
undefined,
105-
{categoryInPageTools: true} as ParsedArguments,
105+
{categoryExperimentalInPage: true} as ParsedArguments,
106106
);
107107
});
108108

@@ -131,7 +131,7 @@ describe('inPage', () => {
131131
);
132132
},
133133
undefined,
134-
{categoryInPageTools: true} as ParsedArguments,
134+
{categoryExperimentalInPage: true} as ParsedArguments,
135135
);
136136
});
137137

@@ -150,7 +150,7 @@ describe('inPage', () => {
150150
);
151151
},
152152
undefined,
153-
{categoryInPageTools: true} as ParsedArguments,
153+
{categoryExperimentalInPage: true} as ParsedArguments,
154154
);
155155
});
156156
});
@@ -215,7 +215,7 @@ describe('inPage', () => {
215215
);
216216
},
217217
undefined,
218-
{categoryInPageTools: true} as ParsedArguments,
218+
{categoryExperimentalInPage: true} as ParsedArguments,
219219
);
220220
});
221221

@@ -302,7 +302,7 @@ describe('inPage', () => {
302302
);
303303
},
304304
undefined,
305-
{categoryInPageTools: true} as ParsedArguments,
305+
{categoryExperimentalInPage: true} as ParsedArguments,
306306
);
307307
});
308308

@@ -347,7 +347,7 @@ describe('inPage', () => {
347347
);
348348
},
349349
undefined,
350-
{categoryInPageTools: true} as ParsedArguments,
350+
{categoryExperimentalInPage: true} as ParsedArguments,
351351
);
352352
});
353353

@@ -486,7 +486,7 @@ describe('inPage', () => {
486486
);
487487
},
488488
undefined,
489-
{categoryInPageTools: true} as ParsedArguments,
489+
{categoryExperimentalInPage: true} as ParsedArguments,
490490
);
491491
});
492492

@@ -535,7 +535,7 @@ describe('inPage', () => {
535535
);
536536
},
537537
undefined,
538-
{categoryInPageTools: true} as ParsedArguments,
538+
{categoryExperimentalInPage: true} as ParsedArguments,
539539
);
540540
});
541541

@@ -590,7 +590,7 @@ describe('inPage', () => {
590590
);
591591
},
592592
undefined,
593-
{categoryInPageTools: true} as ParsedArguments,
593+
{categoryExperimentalInPage: true} as ParsedArguments,
594594
);
595595
});
596596

@@ -647,7 +647,7 @@ describe('inPage', () => {
647647
stub.restore();
648648
},
649649
undefined,
650-
{categoryInPageTools: true} as ParsedArguments,
650+
{categoryExperimentalInPage: true} as ParsedArguments,
651651
);
652652
});
653653

@@ -713,7 +713,7 @@ describe('inPage', () => {
713713
stubSnapshot.restore();
714714
},
715715
undefined,
716-
{categoryInPageTools: true} as ParsedArguments,
716+
{categoryExperimentalInPage: true} as ParsedArguments,
717717
);
718718
});
719719

@@ -771,7 +771,7 @@ describe('inPage', () => {
771771
stubSnapshot.restore();
772772
},
773773
undefined,
774-
{categoryInPageTools: true} as ParsedArguments,
774+
{categoryExperimentalInPage: true} as ParsedArguments,
775775
);
776776
});
777777
});

0 commit comments

Comments
 (0)