feat: add set_extra_http_headers tool for Network.setExtraHTTPHeaders#1176
Open
pedrodurek wants to merge 1 commit intoChromeDevTools:mainfrom
Open
feat: add set_extra_http_headers tool for Network.setExtraHTTPHeaders#1176pedrodurek wants to merge 1 commit intoChromeDevTools:mainfrom
pedrodurek wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
OrKoN
requested changes
Apr 2, 2026
Collaborator
There was a problem hiding this comment.
Thanks for the PR! I think we should align with the suggestion in this comment #1175 (comment) and add this to the emulation tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
set_extra_http_headerstool that calls Puppeteer'spage.setExtraHTTPHeaders()(which uses CDPNetwork.setExtraHTTPHeadersunder the hood).Closes #1175
Tool Definition
set_extra_http_headerslist_network_requestsandget_network_request)headers— aRecord<string, string>of header name-value pairs{}Use Case
This enables setting custom HTTP headers on all requests — including the initial document navigation and
<script>tag loads — whichinitScriptcannot do since it runs after the document is already fetched.Changes
src/tools/network.ts— AddedsetExtraHTTPHeaderspage tool usingdefinePageTooltests/tools/network.test.ts— Added 3 test cases:{}