Skip to content

chore: remove specific chrome executable usage on extensions tests #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nroscino wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore: remove specific chrome executable usage on extensions tests #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aab83b9
chore: remove canary usage on extensions tests
nroscino Mar 27, 2026
077afb9
chore: formatting
nroscino Mar 27, 2026
0ce2a89
chore: adding uninstall to extension tests
nroscino Mar 27, 2026
c8a89cd
chore: removed unused uninstallation of extension
nroscino Mar 27, 2026
6aba753
chore: adding uninstall of text to avoid test overlapping
nroscino Mar 27, 2026
3d6d4a5
chore: test
nroscino Mar 27, 2026
b89a238
chore: spawn new browser flag
nroscino Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions scripts/test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const nodeArgs = [
...files,
];

function installChrome(version) {
function _installChrome(version) {
try {
return execSync(
`npx puppeteer browsers install chrome@${version} --format "{{path}}"`,
Expand Down Expand Up @@ -92,9 +92,6 @@ async function runTests(attempt) {
});
}

const chromePath = installChrome('146.0.7680.31');
process.env.CHROME_M146_EXECUTABLE_PATH = chromePath;

const maxAttempts = shouldRetry ? 3 : 1;
let exitCode = 1;

Expand Down
4 changes: 1 addition & 3 deletions tests/tools/extensions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,7 @@ describe('extension', () => {
);
assert.ok(pageTargetAfter, 'Page should exist after action');
},
{
executablePath: process.env.CHROME_M146_EXECUTABLE_PATH,
},
{},
{
categoryExtensions: true,
} as ParsedArguments,
Expand Down
9 changes: 5 additions & 4 deletions tests/tools/pages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,9 @@ describe('pages', () => {
'<extension-id>',
);
t.assert.snapshot?.(text);
await context.uninstallExtension(extensionId);
},
{
executablePath: process.env.CHROME_M146_EXECUTABLE_PATH,
},
{},
{
categoryExtensions: true,
} as ParsedArguments,
Expand Down Expand Up @@ -144,6 +143,7 @@ describe('pages', () => {
'<extension-id>',
);
t.assert.snapshot?.(text);
await context.uninstallExtension(extensionId);
},
{},
{
Expand Down Expand Up @@ -195,9 +195,10 @@ describe('pages', () => {
'<extension-id>',
);
t.assert.snapshot?.(text);
await context.uninstallExtension(extensionId);
},
{
executablePath: process.env.CHROME_M146_EXECUTABLE_PATH,
spawnNewBrowser: true,
},
{
categoryExtensions: true,
Expand Down
4 changes: 3 additions & 1 deletion tests/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export async function withBrowser(
debug?: boolean;
autoOpenDevTools?: boolean;
executablePath?: string;
spawnNewBrowser?: boolean;
} = {},
) {
const launchOptions: LaunchOptions = {
Expand All @@ -77,7 +78,7 @@ export async function withBrowser(
};
const key = JSON.stringify(launchOptions);

let browser = browsers.get(key);
let browser = options.spawnNewBrowser && browsers.get(key);
if (!browser) {
browser = await puppeteer.launch(launchOptions);
browsers.set(key, browser);
Expand All @@ -102,6 +103,7 @@ export async function withMcpContext(
autoOpenDevTools?: boolean;
performanceCrux?: boolean;
executablePath?: string;
spawnNewBrowser?: boolean;
} = {},
args: ParsedArguments = {} as ParsedArguments,
) {
Expand Down
Loading