feat: support DevTools header redactions as an option#1848
Open
feat: support DevTools header redactions as an option#1848
Conversation
SandyMtz9
approved these changes
Apr 10, 2026
Collaborator
Author
|
@natorion I currently think it makes sense to add this as an option aligning with DevTools. PTAL |
75d5343 to
323d821
Compare
Lightning00Blade
approved these changes
Apr 10, 2026
Contributor
|
Is this enabled or disabled by default? I am not sure we want to have redaction enabled by default - that sounds a like a box of surprises. If enabled we should also clearly indicate/state how it can turned off via the settings. Let's make srue that agents can self fix the problem. |
0d32540 to
ea6bb6e
Compare
Collaborator
Author
Changed to disabled by default. |
This PR adds a CLI flag to enable redacting network headers in the same way they are redacted in DevTools. Note that sometimes it might prevent the agent from properly analysing network issues. Pass `--redact-headers=false` to revert to the previous behavior.
ea6bb6e to
26b5e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CLI flag to enable redacting network headers in the same way they are redacted in DevTools. Note that sometimes it might prevent the agent from properly analysing network issues. Pass
--redact-headers=falseto revert to the previous behavior.