Skip to content

feat: support DevTools header redactions as an option#1848

Open
OrKoN wants to merge 1 commit intomainfrom
orkon/redact-headers
Open

feat: support DevTools header redactions as an option#1848
OrKoN wants to merge 1 commit intomainfrom
orkon/redact-headers

Conversation

@OrKoN
Copy link
Copy Markdown
Collaborator

@OrKoN OrKoN commented Apr 10, 2026

This PR adds a CLI flag to enable redacting network headers in the same way they are redacted in DevTools. Note that sometimes it might prevent the agent from properly analysing network issues. Pass --redact-headers=false to revert to the previous behavior.

@OrKoN
Copy link
Copy Markdown
Collaborator Author

OrKoN commented Apr 10, 2026

@natorion I currently think it makes sense to add this as an option aligning with DevTools. PTAL

@OrKoN OrKoN force-pushed the orkon/redact-headers branch from 75d5343 to 323d821 Compare April 10, 2026 13:40
@OrKoN OrKoN marked this pull request as ready for review April 10, 2026 13:41
@natorion
Copy link
Copy Markdown
Contributor

natorion commented Apr 14, 2026

Is this enabled or disabled by default? I am not sure we want to have redaction enabled by default - that sounds a like a box of surprises.

If enabled we should also clearly indicate/state how it can turned off via the settings. Let's make srue that agents can self fix the problem.

@OrKoN OrKoN changed the title feat: apply DevTools header redactions by default feat: support DevTools header redactions as an option Apr 14, 2026
@OrKoN OrKoN force-pushed the orkon/redact-headers branch 2 times, most recently from 0d32540 to ea6bb6e Compare April 14, 2026 08:55
@OrKoN
Copy link
Copy Markdown
Collaborator Author

OrKoN commented Apr 14, 2026

Is this enabled or disabled by default? I am not sure we want to have redaction enabled by default - that sounds a like a box of surprises.

If enabled we should also clearly indicate/state how it can turned off via the settings. Let's make srue that agents can self fix the problem.

Changed to disabled by default.

This PR adds a CLI flag to enable redacting network
headers in the same way they are redacted in DevTools.
Note that sometimes it might prevent the agent from
properly analysing network issues. Pass `--redact-headers=false`
to revert to the previous behavior.
@OrKoN OrKoN force-pushed the orkon/redact-headers branch from ea6bb6e to 26b5e37 Compare April 14, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants