Skip to content

fix: ignore unmapped PerformanceIssue events #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
officialasishkumar wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −0
Open

fix: ignore unmapped PerformanceIssue events #1852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/PageCollector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,11 @@ class PageEventSubscriber {

#onIssueAdded = (inspectorIssue: Issue) => {
try {
// DevTools currently defines this protocol issue code but has no
// IssuesManager handler for it, so calling into the mapper only warns.
if (String(inspectorIssue.code) === 'PerformanceIssue') {
Copy link
Copy Markdown
Collaborator

@Lightning00Blade Lightning00Blade Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note I have landed a change upstream in DevTools - https://crrev.com/c/7761323
to get the supported list so we don't have to hard code this bit.

Copy link
Copy Markdown
Author

@officialasishkumar officialasishkumar Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main and updated the regression test for the current page issue event path. Kept the guard isolated until the DevTools bundle with the supported-list change is pulled in here.

return;
}
const issue = DevTools.createIssuesFromProtocolIssue(
null,
// @ts-expect-error Protocol types diverge.
Expand Down
29 changes: 29 additions & 0 deletions tests/PageCollector.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,35 @@ describe('ConsoleCollector', () => {
assert.equal(data.length, 2);
});

it('silently ignores unmapped PerformanceIssue events', async () => {
const browser = getMockBrowser();
const page = (await browser.pages())[0];
const warnStub = sinon.stub(console, 'warn');

const collector = new ConsoleCollector(browser, collect => {
return {
devtoolsAggregatedIssue: issue => {
collect(issue);
},
} as ListenerMap;
});
await collector.init([page]);

const performanceIssue = {
code: 'PerformanceIssue',
details: {
performanceIssueDetails: {
performanceIssueType: 'DocumentCookie',
},
},
} as unknown as Protocol.Audits.InspectorIssue;

page.emit('issue', performanceIssue);

assert.equal(collector.getData(page).length, 0);
sinon.assert.notCalled(warnStub);
});

it('filters duplicated issues', async () => {
const browser = getMockBrowser();
const page = (await browser.pages())[0];
Expand Down
Loading