Skip to content

fix(cli): allow --autoConnect in chrome-devtools start #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerone0x wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix(cli): allow --autoConnect in chrome-devtools start #1859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ chrome-devtools navigate_page "https://google.com"
# Take a screenshot and save it to a file
chrome-devtools take_screenshot --filePath screenshot.png

# Start the daemon and auto-connect to an existing Chrome profile
chrome-devtools start --autoConnect

# Stop the background daemon when finished
chrome-devtools stop
```
Expand Down
3 changes: 1 addition & 2 deletions src/bin/chrome-devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ const startCliOptions = {
...cliOptions,
} as Partial<typeof cliOptions>;

// Not supported in CLI on purpose.
delete startCliOptions.autoConnect;
// autoConnect is supported by the CLI.
// Missing CLI serialization.
delete startCliOptions.viewport;
// CLI is generated based on the default tool definitions. To enable conditional
Expand Down