fix: Make fill_form more appealing when filling forms with checkboxes#1971
Open
zyzyzyryxy wants to merge 2 commits intomainfrom
Open
fix: Make fill_form more appealing when filling forms with checkboxes#1971zyzyzyryxy wants to merge 2 commits intomainfrom
zyzyzyryxy wants to merge 2 commits intomainfrom
Conversation
OrKoN
reviewed
Apr 28, 2026
| export const fillForm = definePageTool({ | ||
| name: 'fill_form', | ||
| description: `Fill out multiple form elements at once`, | ||
| description: `Fill out multiple form elements at once. To set checkboxes fill them with 'true'`, |
Collaborator
There was a problem hiding this comment.
let's add a test to tests/tools/input.test.ts that tests checkboxes and verify that it actually accepts a string true and false
Contributor
Author
There was a problem hiding this comment.
Good catch, I misread some eval results thinking it already works this way. Pushed an update to make fill and fill_form handle those, together with tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1942
Verified using
npm run eval -- scripts/eval_scenarios/fill_select_and_checkboxes_test.tsWithout this change, I observed 7 runs using fill_form for all controls at once, 14 runs using click to select checkboxes and 10 runs that did nothing (total 31 runs)
After this change: 9 fill_form using runs (passes), 1 click based approach and 10 no-attempt fails (20 runs total)
Depending how we count the no-attempt runs, its either increase from 23% to 45% or 33% to 90% in eval pass rate.