fix: harden page discovery for autoConnect#1979
fix: harden page discovery for autoConnect#1979bertrand319 wants to merge 6 commits intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Local verification completed:
The fork workflows |
|
Added a second fix for the new \ feedback. The log shows Puppeteer connects successfully, then \ fails while resolving one page target. This path previously relied on , where one stalled target can reject/block the whole page snapshot. The new commit enumerates targets directly, resolves each page with the existing default timeout, logs and skips only the unresponsive target, and still returns the responsive pages. Fresh local verification after the latest commit:
.claude-plugin/marketplace.json 1ms (unchanged) (cached)
................
.................... Failed tests: ✖ respects the timeout parameter (555.324208ms) |
|
I am having trouble understanding what this is about. Is this related to a specific bug? It feels like this addresses multiple things in a single PR, could they be separated to make reviewing easier? |
Summary
isolatedContextvalues as omitted when opening a new page.list_pagescan still return responsive pages instead of failing on one stalled target.Test Plan
npm run formatnpm run buildnpm run test tests/McpContext.test.tsnpm run test