feat: support allowedUrlPattern & blockedUrlPattern Options#2037
Open
nattallius wants to merge 11 commits into
Open
feat: support allowedUrlPattern & blockedUrlPattern Options#2037nattallius wants to merge 11 commits into
nattallius wants to merge 11 commits into
Conversation
nattallius
force-pushed
the
add-blocklist-and-allowlist-options
branch
from
b5eca0f to
788efce
Compare
OrKoN
reviewed
May 12, 2026
OrKoN
reviewed
May 12, 2026
OrKoN
reviewed
May 12, 2026
nattallius
force-pushed
the
add-blocklist-and-allowlist-options
branch
from
f537e11 to
998d4be
Compare
OrKoN
reviewed
May 18, 2026
OrKoN
reviewed
May 18, 2026
| }, | ||
| { | ||
| blockedUrlPattern: [server.getRoute('/blocked.html')], | ||
| executablePath: process.env.CHROME_M149_EXECUTABLE_PATH, |
Collaborator
There was a problem hiding this comment.
block list should not need M149, right?
Collaborator
Author
There was a problem hiding this comment.
No, it also fails if runs against stable
nattallius
force-pushed
the
add-blocklist-and-allowlist-options
branch
from
703ef62 to
eab8536
Compare
OrKoN
reviewed
May 18, 2026
| }, | ||
| { | ||
| blockedUrlPattern: [server.getRoute('/blocked.html')], | ||
| executablePath: process.env.CHROME_M149_EXECUTABLE_PATH, |
Collaborator
There was a problem hiding this comment.
blocklist should not need M149?
nattallius
changed the title
OrKoN
force-pushed
the
add-blocklist-and-allowlist-options
branch
from
b90f3a7 to
57c0f95
Compare
nattallius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.