fix: Apply CPU throttling to secondary CDP session#2092
Open
wolfib wants to merge 2 commits into
Open
Conversation
wolfib
force-pushed
the
extend-navigation-timeout
branch
from
0694532 to
c09351b
Compare
OrKoN
reviewed
May 20, 2026
| const secondarySession = this.getDevToolsUniverse(mcpPage)?.session; | ||
| if (!options.cpuThrottlingRate) { | ||
| await page.emulateCPUThrottling(1); | ||
| if (secondarySession) { |
Collaborator
There was a problem hiding this comment.
I am surprised this is needed because CPUthrottling is global IIRC. Are we sure DevTools code does not reset CPU throttling upon instantiation?
OrKoN
reviewed
May 21, 2026
| }); | ||
| }); | ||
|
|
||
| it('applies cpu throttling to secondary session', async () => { |
Collaborator
There was a problem hiding this comment.
can we test instead that throttling apply correctly to performance trace results?
OrKoN
approved these changes
May 21, 2026
Collaborator
OrKoN
left a comment
OrKoN
left a comment
There was a problem hiding this comment.
LGTM as a temporary solution but let's fix it upstream and file a task to clean up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1955
CPU throttling needs to be applied to both the primary puppeteer session and the secondary CDP session from the DevTools universe to have an effect.
For network throttling this does not seem to be the case, I can see a slowdown with the current implementation which only applies the network throttling to the primary CDP session.
I also had to increase the navigation timeout to prevent timeout errors.