Move insightBounds helper into models/trace/insights

R=cjamcl@chromium.org

Bug: 442509324
Change-Id: I1ddc433c2b14087ca6147cf932a02ac77e0e5f1d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6917689
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>

Author: jackfranklin

front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts

@@ -95,7 +95,7 @@ export class PerformanceTraceFormatter {
           continue;
         }
 
-        const insightBounds = TimelineUtils.InsightAIContext.insightBounds(model, insightSet.bounds);
+        const insightBounds = Trace.Insights.Common.insightBounds(model, insightSet.bounds);
         const insightParts = [
           `insight name: ${insightName}`,
           `description: ${model.description}`,

front_end/models/trace/insights/Common.test.ts

@@ -6,6 +6,7 @@ import type {RecursivePartial} from '../../../core/platform/TypescriptUtilities.
 import * as Protocol from '../../../generated/protocol.js';
 import {describeWithEnvironment} from '../../../testing/EnvironmentHelpers.js';
 import {getFirstOrError, processTrace} from '../../../testing/InsightHelpers.js';
+import {microsecondsTraceWindow} from '../../../testing/TraceHelpers.js';
 import type * as Types from '../types/types.js';
 
 import * as Insights from './insights.js';
@@ -122,4 +123,56 @@ describeWithEnvironment('Common', function() {
       assert.strictEqual(result, 33);  // uses default compression ratio.
     });
   });
+
+  describe('insightBounds', () => {
+    const INSIGHT_SET_BOUNDS = microsecondsTraceWindow(0, 1_000);
+
+    it('uses the bounds of the overlays', async () => {
+      const fakeInsight = {
+        createOverlays(): Types.Overlays.Overlay[] {
+          return [{
+            type: 'TIME_RANGE',
+            bounds: microsecondsTraceWindow(100, 500),
+            label: 'test',
+            showDuration: true,
+          }];
+        }
+      } as unknown as Insights.Types.InsightModel;
+      const bounds = Insights.Common.insightBounds(fakeInsight, INSIGHT_SET_BOUNDS);
+      assert.deepEqual(bounds, microsecondsTraceWindow(100, 500));
+    });
+
+    it('merges the bounds of two overlays', async () => {
+      const fakeInsight = {
+        createOverlays(): Types.Overlays.Overlay[] {
+          return [
+            {
+              type: 'TIME_RANGE',
+              bounds: microsecondsTraceWindow(100, 500),
+              label: 'test',
+              showDuration: true,
+            },
+            {
+              type: 'TIME_RANGE',
+              bounds: microsecondsTraceWindow(50, 400),
+              label: 'test',
+              showDuration: true,
+            }
+          ];
+        }
+      } as unknown as Insights.Types.InsightModel;
+      const bounds = Insights.Common.insightBounds(fakeInsight, INSIGHT_SET_BOUNDS);
+      assert.deepEqual(bounds, microsecondsTraceWindow(50, 500));
+    });
+
+    it('falls back to the set bounds if there are no overlays', async () => {
+      const fakeInsight = {
+        createOverlays(): Types.Overlays.Overlay[] {
+          return [];
+        }
+      } as unknown as Insights.Types.InsightModel;
+      const bounds = Insights.Common.insightBounds(fakeInsight, INSIGHT_SET_BOUNDS);
+      assert.deepEqual(bounds, INSIGHT_SET_BOUNDS);
+    });
+  });
 });

front_end/models/trace/insights/Common.ts

@@ -12,6 +12,7 @@ import * as Types from '../types/types.js';
 import {getLogNormalScore} from './Statistics.js';
 import {
   InsightKeys,
+  type InsightModel,
   type InsightModels,
   type InsightSet,
   type InsightSetContext,
@@ -432,3 +433,21 @@ export function calculateDocFirstByteTs(docRequest: Types.Events.SyntheticNetwor
       Helpers.Timing.secondsToMicro(timing.requestTime) +
       Helpers.Timing.milliToMicro(timing.receiveHeadersStart ?? timing.receiveHeadersEnd));
 }
+
+/**
+ * Calculates the trace bounds for the given insight that are relevant.
+ *
+ * Uses the insight's overlays to determine the relevant trace bounds. If there are
+ * no overlays, falls back to the insight set's navigation bounds.
+ */
+export function insightBounds(
+    insight: InsightModel, insightSetBounds: Types.Timing.TraceWindowMicro): Types.Timing.TraceWindowMicro {
+  const overlays = insight.createOverlays?.() ?? [];
+  const windows = overlays.map(Helpers.Timing.traceWindowFromOverlay).filter(bounds => !!bounds);
+  const overlaysBounds = Helpers.Timing.combineTraceWindowsMicro(windows);
+  if (overlaysBounds) {
+    return overlaysBounds;
+  }
+
+  return insightSetBounds;
+}

front_end/panels/timeline/utils/InsightAIContext.ts

@@ -126,22 +126,3 @@ export class AIQueries {
         .filter(tree => !!tree);
   }
 }
-
-/**
- * Calculates the trace bounds for the given insight that are relevant.
- *
- * Uses the insight's overlays to determine the relevant trace bounds. If there are
- * no overlays, falls back to the insight set's navigation bounds.
- */
-export function insightBounds(
-    insight: Trace.Insights.Types.InsightModel,
-    insightSetBounds: Trace.Types.Timing.TraceWindowMicro): Trace.Types.Timing.TraceWindowMicro {
-  const overlays = insight.createOverlays?.() ?? [];
-  const windows = overlays.map(Trace.Helpers.Timing.traceWindowFromOverlay).filter(bounds => !!bounds);
-  const overlaysBounds = Trace.Helpers.Timing.combineTraceWindowsMicro(windows);
-  if (overlaysBounds) {
-    return overlaysBounds;
-  }
-
-  return insightSetBounds;
-}