Fix reliance on VE Chrome feature flag for VE logs in e2e tests

In crrev.com/c/6734500 the VE Logs feature was removed from Chromium,
but we relied on the testing parameter to update the host config for VE
Logs for test.

This CL updates the code for e2e_non_hosted tests to set a setting
`veLogsTestMode` that configures them instead.

In a follow-up, we will remove the VE Logs host config from Chromium &
DevTools entirely, now that we do not rely on the host config, and it is
always enabled, given that the feature flag is now removed and currently
hardcoded to `true` on the backend.

Bug: none
Change-Id: Ib73d9044a32cbdd263891e8f4c24112d293de10b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6764669
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>

Author: jackfranklin

extensions/cxx_debugging/e2e/MochaRootHooks.ts

@@ -44,7 +44,6 @@ async function beforeAll() {
       `--window-size=${defaultViewport.width + 20, defaultViewport.height + 100}`,
       `--custom-devtools-frontend=${new URL(`${DEVTOOLS_DIR}/front_end`, 'file://').href}`,
       '--disable-features=RenderDocument',
-      '--enable-features=DevToolsVeLogging:testing/true',
     ],
   });
 
@@ -63,6 +62,9 @@ async function beforeAll() {
     throw new Error('Could not find frontend page');
   }
   await frontend.setViewport(defaultViewport);
+  const devToolsVeLogging = {enabled: true, testing: true};
+  await frontend.evaluateOnNewDocument(`globalThis.hostConfigForTesting = ${JSON.stringify({devToolsVeLogging})};`);
+  await frontend.reload();
 
   setBrowserAndPages({frontend, target, browser: conn});
 }

front_end/entrypoints/main/MainImpl.ts

@@ -162,8 +162,15 @@ export class MainImpl {
 
     Host.userMetrics.syncSetting(Common.Settings.Settings.instance().moduleSetting<boolean>('sync-preferences').get());
     const veLogging = config.devToolsVeLogging;
+
+    // Used by e2e_non_hosted to put VE Logs into "test mode".
+    const veLogsTestMode = Common.Settings.Settings.instance().createSetting('veLogsTestMode', false).get();
+
     if (veLogging?.enabled) {
-      if (veLogging?.testing) {
+      // Note: as of https://crrev.com/c/6734500 landing, veLogging.testing is hard-coded to false.
+      // But the e2e tests (test/conductor/frontend_tab.ts) use this to enable this flag for e2e tests.
+      // TODO(crbug.com/432411398): remove the host config for VE logs + find a better way to set this up in e2e tests.
+      if (veLogging?.testing || veLogsTestMode) {
         VisualLogging.setVeDebugLoggingEnabled(true, VisualLogging.DebugLoggingFormat.TEST);
         const options = {
           processingThrottler: new Common.Throttler.Throttler(0),

front_end/ui/visual_logging/KnownContextValues.ts

@@ -1867,6 +1867,7 @@ export const knownContextValues = new Set([
   'is-landscape',
   'is-mobile',
   'is-resident-credential',
+  'is-u',
   'is-user-active-false-is-screen-unlocked-false',
   'is-user-active-false-is-screen-unlocked-true',
   'is-user-active-true-is-screen-unlocked-false',
@@ -3926,6 +3927,8 @@ export const knownContextValues = new Set([
   'value-3',
   'vary',
   'vary-header',
+  've',
+  'veLogsTestMode',
   'vector-effect',
   'verbose',
   'verdana',

test/conductor/frontend_tab.ts

@@ -60,8 +60,9 @@ export class DevToolsFrontendTab {
     // We also use a unique ID per DevTools frontend instance, to avoid the same issue with other
     // frontend instances.
     const id = DevToolsFrontendTab.tabCounter++;
+
     const frontendUrl = `https://i${id}.devtools-frontend.test:${testServerPort}/${devToolsAppURL}?ws=localhost:${
-        getDebugPort(browser)}/devtools/page/${targetId}&targetType=tab&veLogging=true`;
+        getDebugPort(browser)}/devtools/page/${targetId}&targetType=tab`;
 
     const frontend = await browser.newPage();
     installPageErrorHandlers(frontend);

test/e2e_non_hosted/shared/frontend-helper.ts

@@ -601,7 +601,7 @@ export interface DevtoolsSettings {
 export const DEFAULT_DEVTOOLS_SETTINGS: DevtoolsSettings = {
   enabledDevToolsExperiments: [],
   devToolsSettings: {
-    isUnderTest: true,
+    veLogsTestMode: true,
   },
   dockingMode: 'right',
 };
@@ -621,7 +621,10 @@ async function setDevToolsSettings(devToolsPata: DevToolsPage, settings: Record<
   return await devToolsPata.evaluate(`(async () => {
       const Common = await import('./core/common/common.js');
       ${rawValues.map(([settingName, value]) => {
-    return `Common.Settings.Settings.instance().createSetting('${settingName}', ${value});`;
+    // Creating the setting might not be enough if it already exists, so we
+    // create it and then forcibly set the value.
+    return `const setting = Common.Settings.Settings.instance().createSetting('${settingName}', ${value});
+        setting.set(${value});`;
   })}
     })()`);
 }