Remove show-option-to-expose-internals-in-heap-snapshot experiment

This CL removes this experiment which only guards whether this
checkbox is shown. The checkbox is then shown by default.

Bug: 497855658, 476074983
Change-Id: I0ca70cf449317e75747b9d259cd623ca70f34ab2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7715341
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>

Author: Dominik Inführ

front_end/core/host/UserMetrics.ts

@@ -815,7 +815,6 @@ export enum DevtoolsExperiments {
   'live-heap-profile' = 11,
   'protocol-monitor' = 13,
   'sampling-heap-profiler-timeline' = 17,
-  'show-option-to-expose-internals-in-heap-snapshot' = 18,
   'timeline-invalidation-tracking' = 26,
   'timeline-show-all-events' = 27,
   apca = 39,

front_end/core/root/ExperimentNames.ts

@@ -8,7 +8,6 @@ export enum ExperimentName {
   LIVE_HEAP_PROFILE = 'live-heap-profile',
   PROTOCOL_MONITOR = 'protocol-monitor',
   SAMPLING_HEAP_PROFILER_TIMELINE = 'sampling-heap-profiler-timeline',
-  SHOW_OPTION_TO_EXPOSE_INTERNALS_IN_HEAP_SNAPSHOT = 'show-option-to-expose-internals-in-heap-snapshot',
   TIMELINE_INVALIDATION_TRACKING = 'timeline-invalidation-tracking',
   TIMELINE_SHOW_ALL_EVENTS = 'timeline-show-all-events',
   APCA = 'apca',

front_end/entrypoints/main/MainImpl.ts

@@ -356,9 +356,6 @@ export class MainImpl {
         Root.ExperimentNames.ExperimentName.PROTOCOL_MONITOR, protocolMonitorExperiment);
     Root.Runtime.experiments.register(
         Root.ExperimentNames.ExperimentName.SAMPLING_HEAP_PROFILER_TIMELINE, 'Sampling heap profiler timeline');
-    Root.Runtime.experiments.register(
-        Root.ExperimentNames.ExperimentName.SHOW_OPTION_TO_EXPOSE_INTERNALS_IN_HEAP_SNAPSHOT,
-        'Show option to expose internals in heap snapshots');
 
     // Timeline
     Root.Runtime.experiments.register(

front_end/panels/profiler/HeapSnapshotView.ts

@@ -8,7 +8,6 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as Bindings from '../../models/bindings/bindings.js';
@@ -1339,12 +1338,10 @@ export class HeapSnapshotProfileType extends
   }
 
   override customContent(): Element|null {
-    const showOptionToExposeInternalsInHeapSnapshot = Root.Runtime.experiments.isEnabled(
-        Root.ExperimentNames.ExperimentName.SHOW_OPTION_TO_EXPOSE_INTERNALS_IN_HEAP_SNAPSHOT);
     const exposeInternalsInHeapSnapshotCheckbox =
         SettingsUI.SettingsUI.createSettingCheckbox(i18nString(UIStrings.exposeInternals), this.exposeInternals);
     this.customContentInternal = exposeInternalsInHeapSnapshotCheckbox;
-    return showOptionToExposeInternalsInHeapSnapshot ? exposeInternalsInHeapSnapshotCheckbox : null;
+    return exposeInternalsInHeapSnapshotCheckbox;
   }
 
   override setCustomContentEnabled(enable: boolean): void {

front_end/ui/visual_logging/KnownContextValues.ts

@@ -3623,7 +3623,6 @@ export const knownContextValues = new Set([
   'show-minimal-safe-area-for-maskable-icons',
   'show-more',
   'show-network-requests',
-  'show-option-to-expose-internals-in-heap-snapshot',
   'show-overrides',
   'show-paint-rects',
   'show-paint-rects-true',

test/e2e/memory/memory.test.ts

@@ -615,8 +615,8 @@ describe('The Memory Panel', function() {
   });
 });
 
-describe(' The Memory Panel with show-option-to-expose-internals-in-heap-snapshot experiment', () => {
-  setup({dockingMode: 'undocked', enabledDevToolsExperiments: ['show-option-to-expose-internals-in-heap-snapshot']});
+describe('The Memory Panel', () => {
+  setup({dockingMode: 'undocked'});
 
   it('Does not include backing store size in the shallow size of a JS Set', async ({devToolsPage, inspectedPage}) => {
     await inspectedPage.goToResource('memory/set.html');