Don't record another repeated impressions of the same non-DOM loggable

Bug: 477550607
Change-Id: I7e7ab03f6856ee96e608466847d405d51571b640
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7499829
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>

Author: danilsomsikov

front_end/ui/visual_logging/LoggingDriver.test.ts

@@ -1067,4 +1067,20 @@ describe('LoggingDriver', () => {
         VisualLoggingTesting.NonDomState.getNonDomLoggables(parent),
         {loggable, config: {ve: 1, context: '123'}, parent, size: undefined});
   });
+
+  it('does not log a non-DOM impression twice for the same loggable', async () => {
+    addLoggableElements();
+    const loggable = {};
+    const parent = document.getElementById('parent')!;
+    VisualLoggingTesting.NonDomState.registerLoggable(loggable, {ve: 1, context: '123'}, parent);
+    VisualLoggingTesting.NonDomState.registerLoggable(loggable, {ve: 1, context: '123'}, parent);
+    await VisualLoggingTesting.LoggingDriver.startLogging();
+    sinon.assert.calledOnce(recordImpression);
+
+    assert.sameDeepMembers(recordImpression.firstCall.firstArg.impressions, [
+      {id: getVeId(loggable), type: 1, context: 123, parent: getVeId(parent), width: 0, height: 0},
+      {id: getVeId('#element'), type: 1, context: 42, parent: getVeId(parent), width: 300, height: 300},
+      {id: getVeId(parent), type: 1, width: 300, height: 300},
+    ]);
+  });
 });

front_end/ui/visual_logging/LoggingDriver.ts

@@ -266,6 +266,9 @@ export async function process(): Promise<void> {
     const root = nonDomRoots[i];
     for (const {loggable, config, parent, size} of getNonDomLoggables(root)) {
       const loggingState = getOrCreateLoggingState(loggable, config, parent);
+      if (loggingState.impressionLogged) {
+        continue;
+      }
       if (size) {
         loggingState.size = size;
       }