Skip to content

Commit 59cd17f

Browse files
Kateryna ProkopenkoDevtools-frontend LUCI CQ
authored andcommitted
Do not create counter icon-buttons when there are no errors / issues
Fixed: 477530170 Change-Id: I3ad55f156545ec45cab8ac9feeb4f0ce1abc166b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7526787 Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org> Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
1 parent 8087fc2 commit 59cd17f

1 file changed

Lines changed: 16 additions & 10 deletions

File tree

front_end/panels/console_counters/WarningErrorCounter.ts

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@ import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
1212
import type * as IconButton from '../../ui/components/icon_button/icon_button.js';
1313
import * as IssueCounter from '../../ui/components/issue_counter/issue_counter.js';
1414
import * as UI from '../../ui/legacy/legacy.js';
15-
import {html, nothing, render} from '../../ui/lit/lit.js';
15+
import * as Lit from '../../ui/lit/lit.js';
1616
import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
1717

18+
const {html, nothing, render} = Lit;
19+
1820
const UIStrings = {
1921
/**
2022
* @description The console error count in the Warning Error Counter shown in the main toolbar (top-left in DevTools). The error count refers to the number of errors currently present in the JavaScript console.
@@ -95,21 +97,25 @@ const DEFAULT_VIEW: View = (input, _output, target) => {
9597

9698
render(
9799
html`<div class="status-buttons"
98-
><icon-button
100+
>${
101+
errors + warnings ? html`<icon-button
99102
.data=${iconData}
100103
title=${consoleTitle}
101-
class=${'small' + warnings || errors ? nothing as unknown as string : 'hidden'}
104+
class=${'small'}
102105
jslog=${VisualLogging.counter('console').track({
103-
click: true
104-
})}
105-
></icon-button><devtools-issue-counter
106-
class=${'main-toolbar' + (issues ? '' : ' hidden')}
106+
click: true
107+
})}
108+
></icon-button>` :
109+
nothing}${
110+
issues ? html`<devtools-issue-counter
111+
class=${'main-toolbar'}
107112
title=${issuesTitle}
108113
.data=${issueCounterData}
109114
jslog=${VisualLogging.counter('issue').track({
110-
click: true
111-
})}
112-
></devtools-issue-counter></div>`,
115+
click: true
116+
})}
117+
></devtools-issue-counter>` :
118+
nothing}</div>`,
113119
target);
114120
};
115121

0 commit comments

Comments
 (0)