Skip to content

Commit 8c32ced

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
devtools-ci-autoroll-builder
authored and
Devtools-frontend LUCI CQ
committed
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8697082927654543585 R=chrome-devtools-waterfall-gardener-emea-oncall@google.com Bug: none Change-Id: I57d95c537b295512e43a893dcbd7d3b8c0f7b0e9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7206196 Commit-Queue: Nicholas Roscino <nroscino@chromium.org> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: Nicholas Roscino <nroscino@chromium.org>
1 parent 1d205ae commit 8c32ced

10 files changed

Lines changed: 261 additions & 18 deletions

File tree

‎DEPS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '679b33a98ae546ff521eee2ea28d8d5bf28872ba',
2525

2626
# Keeping track of the last time we rolled the browser protocol files.
27-
'chromium_browser_protocol_revision' : '3e09060fabbdeb607bc7ed4db07e88ef0112f839',
27+
'chromium_browser_protocol_revision' : '5bbbb9ffe6bf19fdc31b46add466cd6ef53d75b4',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': 'c2725e0622e1a86d55f14514f2177a39efea4a0e',

‎front_end/generated/InspectorBackendCommands.ts‎

Lines changed: 5 additions & 2 deletions
Large diffs are not rendered by default.

‎front_end/generated/protocol-mapping.d.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4837,6 +4837,14 @@ export namespace ProtocolMapping {
48374837
paramsType: [Protocol.Target.SetRemoteLocationsRequest];
48384838
returnType: void;
48394839
};
4840+
/**
4841+
* Gets the targetId of the DevTools page target opened for the given target
4842+
* (if any).
4843+
*/
4844+
'Target.getDevToolsTarget': {
4845+
paramsType: [Protocol.Target.GetDevToolsTargetRequest];
4846+
returnType: Protocol.Target.GetDevToolsTargetResponse;
4847+
};
48404848
/**
48414849
* Opens a DevTools window for the target.
48424850
*/

‎front_end/generated/protocol-proxy-api.d.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4209,6 +4209,12 @@ declare namespace ProtocolProxyApi {
42094209
*/
42104210
invoke_setRemoteLocations(params: Protocol.Target.SetRemoteLocationsRequest): Promise<Protocol.ProtocolResponseWithError>;
42114211

4212+
/**
4213+
* Gets the targetId of the DevTools page target opened for the given target
4214+
* (if any).
4215+
*/
4216+
invoke_getDevToolsTarget(params: Protocol.Target.GetDevToolsTargetRequest): Promise<Protocol.Target.GetDevToolsTargetResponse>;
4217+
42124218
/**
42134219
* Opens a DevTools window for the target.
42144220
*/

‎front_end/generated/protocol.ts‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1461,6 +1461,66 @@ export namespace Audits {
14611461
sourceCodeLocation?: SourceCodeLocation;
14621462
}
14631463

1464+
export const enum PermissionElementIssueType {
1465+
InvalidType = 'InvalidType',
1466+
FencedFrameDisallowed = 'FencedFrameDisallowed',
1467+
CspFrameAncestorsMissing = 'CspFrameAncestorsMissing',
1468+
PermissionsPolicyBlocked = 'PermissionsPolicyBlocked',
1469+
PaddingRightUnsupported = 'PaddingRightUnsupported',
1470+
PaddingBottomUnsupported = 'PaddingBottomUnsupported',
1471+
InsetBoxShadowUnsupported = 'InsetBoxShadowUnsupported',
1472+
RequestInProgress = 'RequestInProgress',
1473+
UntrustedEvent = 'UntrustedEvent',
1474+
RegistrationFailed = 'RegistrationFailed',
1475+
TypeNotSupported = 'TypeNotSupported',
1476+
InvalidTypeActivation = 'InvalidTypeActivation',
1477+
SecurityChecksFailed = 'SecurityChecksFailed',
1478+
ActivationDisabled = 'ActivationDisabled',
1479+
GeolocationDeprecated = 'GeolocationDeprecated',
1480+
InvalidDisplayStyle = 'InvalidDisplayStyle',
1481+
NonOpaqueColor = 'NonOpaqueColor',
1482+
LowContrast = 'LowContrast',
1483+
FontSizeTooSmall = 'FontSizeTooSmall',
1484+
FontSizeTooLarge = 'FontSizeTooLarge',
1485+
InvalidSizeValue = 'InvalidSizeValue',
1486+
}
1487+
1488+
/**
1489+
* This issue warns about improper usage of the <permission> element.
1490+
*/
1491+
export interface PermissionElementIssueDetails {
1492+
issueType: PermissionElementIssueType;
1493+
/**
1494+
* The value of the type attribute.
1495+
*/
1496+
type?: string;
1497+
/**
1498+
* The node ID of the <permission> element.
1499+
*/
1500+
nodeId?: DOM.BackendNodeId;
1501+
/**
1502+
* True if the issue is a warning, false if it is an error.
1503+
*/
1504+
isWarning?: boolean;
1505+
/**
1506+
* Fields for message construction:
1507+
* Used for messages that reference a specific permission name
1508+
*/
1509+
permissionName?: string;
1510+
/**
1511+
* Used for messages about occlusion
1512+
*/
1513+
occluderNodeInfo?: string;
1514+
/**
1515+
* Used for messages about occluder's parent
1516+
*/
1517+
occluderParentNodeInfo?: string;
1518+
/**
1519+
* Used for messages about activation disabled reason
1520+
*/
1521+
disableReason?: string;
1522+
}
1523+
14641524
/**
14651525
* A unique identifier for the type of issue. Each type may use one of the
14661526
* optional fields in InspectorIssueDetails to convey more specific
@@ -1493,6 +1553,7 @@ export namespace Audits {
14931553
SRIMessageSignatureIssue = 'SRIMessageSignatureIssue',
14941554
UnencodedDigestIssue = 'UnencodedDigestIssue',
14951555
UserReidentificationIssue = 'UserReidentificationIssue',
1556+
PermissionElementIssue = 'PermissionElementIssue',
14961557
}
14971558

14981559
/**
@@ -1530,6 +1591,7 @@ export namespace Audits {
15301591
sriMessageSignatureIssueDetails?: SRIMessageSignatureIssueDetails;
15311592
unencodedDigestIssueDetails?: UnencodedDigestIssueDetails;
15321593
userReidentificationIssueDetails?: UserReidentificationIssueDetails;
1594+
permissionElementIssueDetails?: PermissionElementIssueDetails;
15331595
}
15341596

15351597
/**
@@ -18501,6 +18563,20 @@ export namespace Target {
1850118563
locations: RemoteLocation[];
1850218564
}
1850318565

18566+
export interface GetDevToolsTargetRequest {
18567+
/**
18568+
* Page or tab target ID.
18569+
*/
18570+
targetId: TargetID;
18571+
}
18572+
18573+
export interface GetDevToolsTargetResponse extends ProtocolResponseWithError {
18574+
/**
18575+
* The targetId of DevTools page target if exists.
18576+
*/
18577+
targetId?: TargetID;
18578+
}
18579+
1850418580
export interface OpenDevToolsRequest {
1850518581
/**
1850618582
* This can be the page or tab target ID.

‎front_end/models/javascript_metadata/NativeFunctions.js‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -709,11 +709,6 @@ export const NativeFunctions = [
709709
signatures: [["property","cssText"]],
710710
receivers: ["CSSStyleValue"]
711711
},
712-
{
713-
name: "parse",
714-
signatures: [["serializedOrigin"]],
715-
receivers: ["Origin"]
716-
},
717712
{
718713
name: "parse",
719714
signatures: [["url","?base"]],
@@ -7386,14 +7381,6 @@ export const NativeFunctions = [
73867381
name: "compareComponent",
73877382
signatures: [["component","left","right"]]
73887383
},
7389-
{
7390-
name: "Origin",
7391-
signatures: [["?serializedOrigin"]]
7392-
},
7393-
{
7394-
name: "fromURL",
7395-
signatures: [["serializedURL"]]
7396-
},
73977384
{
73987385
name: "isSameOrigin",
73997386
signatures: [["other"]]

‎front_end/third_party/chromium/README.chromium‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Name: Dependencies sourced from the upstream `chromium` repository
22
URL: https://chromium.googlesource.com/chromium/src
33
Version: N/A
4-
Revision: 3e09060fabbdeb607bc7ed4db07e88ef0112f839
4+
Revision: 5bbbb9ffe6bf19fdc31b46add466cd6ef53d75b4
55
Update Mechanism: Manual (https://crbug.com/428069060)
66
License: BSD-3-Clause
77
License File: LICENSE

‎third_party/blink/public/devtools_protocol/browser_protocol.json‎

Lines changed: 107 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2137,6 +2137,86 @@
21372137
}
21382138
]
21392139
},
2140+
{
2141+
"id": "PermissionElementIssueType",
2142+
"type": "string",
2143+
"enum": [
2144+
"InvalidType",
2145+
"FencedFrameDisallowed",
2146+
"CspFrameAncestorsMissing",
2147+
"PermissionsPolicyBlocked",
2148+
"PaddingRightUnsupported",
2149+
"PaddingBottomUnsupported",
2150+
"InsetBoxShadowUnsupported",
2151+
"RequestInProgress",
2152+
"UntrustedEvent",
2153+
"RegistrationFailed",
2154+
"TypeNotSupported",
2155+
"InvalidTypeActivation",
2156+
"SecurityChecksFailed",
2157+
"ActivationDisabled",
2158+
"GeolocationDeprecated",
2159+
"InvalidDisplayStyle",
2160+
"NonOpaqueColor",
2161+
"LowContrast",
2162+
"FontSizeTooSmall",
2163+
"FontSizeTooLarge",
2164+
"InvalidSizeValue"
2165+
]
2166+
},
2167+
{
2168+
"id": "PermissionElementIssueDetails",
2169+
"description": "This issue warns about improper usage of the <permission> element.",
2170+
"type": "object",
2171+
"properties": [
2172+
{
2173+
"name": "issueType",
2174+
"$ref": "PermissionElementIssueType"
2175+
},
2176+
{
2177+
"name": "type",
2178+
"description": "The value of the type attribute.",
2179+
"optional": true,
2180+
"type": "string"
2181+
},
2182+
{
2183+
"name": "nodeId",
2184+
"description": "The node ID of the <permission> element.",
2185+
"optional": true,
2186+
"$ref": "DOM.BackendNodeId"
2187+
},
2188+
{
2189+
"name": "isWarning",
2190+
"description": "True if the issue is a warning, false if it is an error.",
2191+
"optional": true,
2192+
"type": "boolean"
2193+
},
2194+
{
2195+
"name": "permissionName",
2196+
"description": "Fields for message construction:\nUsed for messages that reference a specific permission name",
2197+
"optional": true,
2198+
"type": "string"
2199+
},
2200+
{
2201+
"name": "occluderNodeInfo",
2202+
"description": "Used for messages about occlusion",
2203+
"optional": true,
2204+
"type": "string"
2205+
},
2206+
{
2207+
"name": "occluderParentNodeInfo",
2208+
"description": "Used for messages about occluder's parent",
2209+
"optional": true,
2210+
"type": "string"
2211+
},
2212+
{
2213+
"name": "disableReason",
2214+
"description": "Used for messages about activation disabled reason",
2215+
"optional": true,
2216+
"type": "string"
2217+
}
2218+
]
2219+
},
21402220
{
21412221
"id": "InspectorIssueCode",
21422222
"description": "A unique identifier for the type of issue. Each type may use one of the\noptional fields in InspectorIssueDetails to convey more specific\ninformation about the kind of issue.",
@@ -2167,7 +2247,8 @@
21672247
"ElementAccessibilityIssue",
21682248
"SRIMessageSignatureIssue",
21692249
"UnencodedDigestIssue",
2170-
"UserReidentificationIssue"
2250+
"UserReidentificationIssue",
2251+
"PermissionElementIssue"
21712252
]
21722253
},
21732254
{
@@ -2305,6 +2386,11 @@
23052386
"name": "userReidentificationIssueDetails",
23062387
"optional": true,
23072388
"$ref": "UserReidentificationIssueDetails"
2389+
},
2390+
{
2391+
"name": "permissionElementIssueDetails",
2392+
"optional": true,
2393+
"$ref": "PermissionElementIssueDetails"
23082394
}
23092395
]
23102396
},
@@ -28225,6 +28311,26 @@
2822528311
}
2822628312
]
2822728313
},
28314+
{
28315+
"name": "getDevToolsTarget",
28316+
"description": "Gets the targetId of the DevTools page target opened for the given target\n(if any).",
28317+
"experimental": true,
28318+
"parameters": [
28319+
{
28320+
"name": "targetId",
28321+
"description": "Page or tab target ID.",
28322+
"$ref": "TargetID"
28323+
}
28324+
],
28325+
"returns": [
28326+
{
28327+
"name": "targetId",
28328+
"description": "The targetId of DevTools page target if exists.",
28329+
"optional": true,
28330+
"$ref": "TargetID"
28331+
}
28332+
]
28333+
},
2822828334
{
2822928335
"name": "openDevTools",
2823028336
"description": "Opens a DevTools window for the target.",

‎third_party/blink/public/devtools_protocol/domains/Audits.pdl‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -632,6 +632,51 @@ experimental domain Audits
632632
# Applies to NoisedCanvasReadback issue type.
633633
optional SourceCodeLocation sourceCodeLocation
634634

635+
type PermissionElementIssueType extends string
636+
enum
637+
InvalidType
638+
FencedFrameDisallowed
639+
CspFrameAncestorsMissing
640+
PermissionsPolicyBlocked
641+
PaddingRightUnsupported
642+
PaddingBottomUnsupported
643+
InsetBoxShadowUnsupported
644+
RequestInProgress
645+
UntrustedEvent
646+
RegistrationFailed
647+
TypeNotSupported
648+
InvalidTypeActivation
649+
SecurityChecksFailed
650+
ActivationDisabled
651+
GeolocationDeprecated
652+
InvalidDisplayStyle
653+
NonOpaqueColor
654+
LowContrast
655+
FontSizeTooSmall
656+
FontSizeTooLarge
657+
InvalidSizeValue
658+
659+
# This issue warns about improper usage of the <permission> element.
660+
type PermissionElementIssueDetails extends object
661+
properties
662+
PermissionElementIssueType issueType
663+
# The value of the type attribute.
664+
optional string type
665+
# The node ID of the <permission> element.
666+
optional DOM.BackendNodeId nodeId
667+
# True if the issue is a warning, false if it is an error.
668+
optional boolean isWarning
669+
670+
# Fields for message construction:
671+
# Used for messages that reference a specific permission name
672+
optional string permissionName
673+
# Used for messages about occlusion
674+
optional string occluderNodeInfo
675+
# Used for messages about occluder's parent
676+
optional string occluderParentNodeInfo
677+
# Used for messages about activation disabled reason
678+
optional string disableReason
679+
635680
# A unique identifier for the type of issue. Each type may use one of the
636681
# optional fields in InspectorIssueDetails to convey more specific
637682
# information about the kind of issue.
@@ -664,6 +709,7 @@ experimental domain Audits
664709
SRIMessageSignatureIssue
665710
UnencodedDigestIssue
666711
UserReidentificationIssue
712+
PermissionElementIssue
667713

668714
# This struct holds a list of optional fields with additional information
669715
# specific to the kind of issue. When adding a new issue code, please also
@@ -696,6 +742,7 @@ experimental domain Audits
696742
optional SRIMessageSignatureIssueDetails sriMessageSignatureIssueDetails
697743
optional UnencodedDigestIssueDetails unencodedDigestIssueDetails
698744
optional UserReidentificationIssueDetails userReidentificationIssueDetails
745+
optional PermissionElementIssueDetails permissionElementIssueDetails
699746

700747
# A unique id for a DevTools inspector issue. Allows other entities (e.g.
701748
# exceptions, CDP message, console messages, etc.) to reference an issue.

‎third_party/blink/public/devtools_protocol/domains/Target.pdl‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,16 @@ domain Target
265265
# List of remote locations.
266266
array of RemoteLocation locations
267267

268+
# Gets the targetId of the DevTools page target opened for the given target
269+
# (if any).
270+
experimental command getDevToolsTarget
271+
parameters
272+
# Page or tab target ID.
273+
TargetID targetId
274+
returns
275+
# The targetId of DevTools page target if exists.
276+
optional TargetID targetId
277+
268278
# Issued when attached to target because of auto-attach or `attachToTarget` command.
269279
experimental event attachedToTarget
270280
parameters

0 commit comments

Comments
 (0)