Skip to content

Commit 90dda5c

Browse files
jackfranklinDevtools-frontend LUCI CQ
authored andcommitted
RPP: remove DOMRect dependency from trace engine
It means any NodeJS consumers (e.g. Lighthouse) have to polyfill `DOMRect`. Given that we only use this to store the x, y, width, height, it seems silly to force NodeJS users to jump through this hoop. R=alexrudenko@chromium.org Bug: 441265851 Change-Id: Ib6aa54b33ec2615dd34b30a0cc329202ada76b6d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6889752 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
1 parent 97ff8da commit 90dda5c

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

front_end/models/trace/handlers/MetaHandler.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ let browserProcessId: Types.Events.ProcessID = Types.Events.ProcessID(-1);
2222
let browserThreadId: Types.Events.ThreadID = Types.Events.ThreadID(-1);
2323
let gpuProcessId: Types.Events.ProcessID = Types.Events.ProcessID(-1);
2424
let gpuThreadId: Types.Events.ThreadID = Types.Events.ThreadID(-1);
25-
let viewportRect: DOMRect|null = null;
25+
let viewportRect: {x: number, y: number, width: number, height: number}|null = null;
2626
let devicePixelRatio: number|null = null;
2727

2828
const processNames = new Map<Types.Events.ProcessID, Types.Events.ProcessName>();
@@ -181,7 +181,7 @@ export function handleEvent(event: Types.Events.Event): void {
181181
const viewportY = rectAsArray[1];
182182
const viewportWidth = rectAsArray[2];
183183
const viewportHeight = rectAsArray[5];
184-
viewportRect = new DOMRect(viewportX, viewportY, viewportWidth, viewportHeight);
184+
viewportRect = {x: viewportX, y: viewportY, width: viewportWidth, height: viewportHeight};
185185
devicePixelRatio = event.args.data.dpr;
186186
}
187187

@@ -466,7 +466,7 @@ export interface MetaHandlerData {
466466
frameByProcessId: Map<Types.Events.ProcessID, Map<string, Types.Events.TraceFrame>>;
467467
mainFrameNavigations: Types.Events.NavigationStart[];
468468
gpuThreadId?: Types.Events.ThreadID;
469-
viewportRect?: DOMRect;
469+
viewportRect?: {x: number, y: number, width: number, height: number};
470470
devicePixelRatio?: number;
471471
}
472472

0 commit comments

Comments
 (0)