Skip to content

Commit 9156f38

Browse files
Natallia HarshunovaDevtools-frontend LUCI CQ
authored andcommitted
Remove default focus from third party issues checkbox
In the Issues Panel empty state with no issues list focus is explicitly set to third-party checkobox. This cl removes that behavior and keeps focus just on panel, so the first tab button press sets the focus on first focusable element Bug: 454885231 Change-Id: I22965dc4d26aad1046107db299a980e753955055 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7362764 Commit-Queue: Natallia Harshunova <nharshunova@chromium.org> Reviewed-by: Nicholas Roscino <nroscino@chromium.org>
1 parent c60a26d commit 9156f38

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

front_end/panels/issues/IssuesPane.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,6 @@ export class IssuesPane extends UI.Widget.VBox {
270270
thirdPartySetting, i18nString(UIStrings.includeCookieIssuesCausedBy),
271271
i18nString(UIStrings.includeThirdpartyCookieIssues));
272272
rightToolbar.appendToolbarItem(this.#showThirdPartyCheckbox);
273-
this.setDefaultFocusedElement(this.#showThirdPartyCheckbox.element);
274273

275274
rightToolbar.appendSeparator();
276275
const issueCounter = new IssueCounter.IssueCounter.IssueCounter();
@@ -459,9 +458,6 @@ export class IssuesPane extends UI.Widget.VBox {
459458
}
460459
} else {
461460
this.#issuesTree.element.hidden = true;
462-
if (this.#showThirdPartyCheckbox) {
463-
this.setDefaultFocusedElement(this.#showThirdPartyCheckbox.element);
464-
}
465461
// We alreay know that issesCount is zero here.
466462
const hasOnlyThirdPartyIssues =
467463
this.#issuesManager.numberOfAllStoredIssues() - this.#issuesManager.numberOfThirdPartyCookiePhaseoutIssues() >

0 commit comments

Comments
 (0)