Skip to content

Commit b2b9c19

Browse files
wolfibDevtools-frontend LUCI CQ
authored andcommitted
Align logic of showing only storage bucket with variable name
Bug: 408930706, 435311130 Change-Id: Ibaf382fc673ebd44a60747a588142b2bb1090902 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7736086 Auto-Submit: Wolfgang Beyer <wolfi@chromium.org> Commit-Queue: Piotr Paulski <piotrpaulski@chromium.org> Reviewed-by: Piotr Paulski <piotrpaulski@chromium.org>
1 parent 07ee22b commit b2b9c19

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

front_end/panels/application/IndexedDBViews.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ export class IDBDatabaseView extends ApplicationComponents.StorageMetadataView.S
147147
super();
148148

149149
this.model = model;
150-
this.setShowOnlyBucket(false);
150+
this.setShowOnlyBucket(true);
151151
if (database) {
152152
this.update(database);
153153
}

front_end/panels/application/ServiceWorkerCacheViews.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export class ServiceWorkerCacheView extends UI.View.SimpleView {
133133
.model(SDK.StorageBucketsModel.StorageBucketsModel)
134134
?.getBucketByName(cache.storageBucket.storageKey, cache.storageBucket.name);
135135

136-
this.metadataView.setShowOnlyBucket(false);
136+
this.metadataView.setShowOnlyBucket(true);
137137

138138
if (bucketInfo) {
139139
this.metadataView.setStorageBucket(bucketInfo);

front_end/panels/application/components/StorageMetadataView.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ describe('StorageMetadataView', () => {
284284
durability: Protocol.Storage.StorageBucketsDurability.Relaxed,
285285
};
286286
component.setStorageBucket(bucketInfo);
287-
component.setShowOnlyBucket(false);
287+
component.setShowOnlyBucket(true);
288288
await RenderCoordinator.done();
289289

290290
const report = component.shadowRoot!.querySelector('devtools-report');

front_end/panels/application/components/StorageMetadataView.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ export class StorageMetadataView extends LegacyWrapper.LegacyWrapper.WrappableCo
126126
#storageBucketsModel?: SDK.StorageBucketsModel.StorageBucketsModel;
127127
#storageKey: SDK.StorageKeyManager.StorageKey|null = null;
128128
#storageBucket: Protocol.Storage.StorageBucketInfo|null = null;
129-
#showOnlyBucket = true;
129+
#showOnlyBucket = false;
130130

131131
setStorageKey(storageKey: string): void {
132132
this.#storageKey = SDK.StorageKeyManager.parseStorageKey(storageKey);
@@ -232,7 +232,7 @@ export class StorageMetadataView extends LegacyWrapper.LegacyWrapper.WrappableCo
232232
if (isDefault) {
233233
return html`<span class="default-bucket">${i18nString(UIStrings.defaultBucket)}</span>`;
234234
}
235-
if (this.#showOnlyBucket) {
235+
if (!this.#showOnlyBucket) {
236236
return html`${name}`;
237237
}
238238
const revealBucket = (e: Event): void => {
@@ -249,7 +249,7 @@ export class StorageMetadataView extends LegacyWrapper.LegacyWrapper.WrappableCo
249249
>${name}</devtools-link>`;
250250
};
251251

252-
if (!this.#showOnlyBucket) {
252+
if (this.#showOnlyBucket) {
253253
return html`
254254
${this.key(i18nString(UIStrings.bucketName))}
255255
${this.value(renderBucketName())}`;

0 commit comments

Comments
 (0)