[cleanup] Fix some typos and unreachable code

A small improvement to the codebase

Bug: none
Change-Id: I648be119454c987b6c5fe849c7816f90d1a8c779
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6770019
Commit-Queue: Piotr Paulski <piotrpaulski@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Piotr Paulski <piotrpaulski@chromium.org>

Author: Lightning00Blade

front_end/models/trace/helpers/TreeHelpers.test.ts

@@ -211,15 +211,13 @@ describe('TreeHelpers', () => {
       const nodeE = [...tree.roots].at(1);
       if (!nodeA || !nodeE) {
         assert(false, 'Root nodes were not found');
-        return;
       }
       const taskA = nodeA.entry;
       const taskE = nodeE.entry;
       const nodeD = [...nodeA.children].at(1);
       const nodeB = [...nodeA.children].at(0);
       if (!nodeB || !nodeD) {
         assert(false, 'Child nodes were not found');
-        return;
       }
       const taskD = nodeD.entry;
       const taskB = nodeB.entry;
@@ -228,46 +226,40 @@ describe('TreeHelpers', () => {
 
       if (!nodeC) {
         assert(false, 'Child nodes were not found');
-        return;
       }
       const taskC = nodeC.entry;
 
       const taskCTotalTime = taskC.dur;
       if (taskCTotalTime === undefined) {
         assert.fail('Total time for task was not found');
-        return;
       }
       assert.strictEqual(taskCTotalTime, Trace.Types.Timing.Micro(1));
       assert.strictEqual(nodeC.selfTime, taskCTotalTime);
 
       const taskBTotalTime = taskB.dur;
       if (taskBTotalTime === undefined) {
         assert.fail('Total time for task was not found');
-        return;
       }
       assert.strictEqual(taskBTotalTime, Trace.Types.Timing.Micro(3));
       assert.strictEqual(nodeB.selfTime, Trace.Types.Timing.Micro(taskBTotalTime - taskCTotalTime));
 
       const taskDTotalTime = taskD.dur;
       if (taskDTotalTime === undefined) {
         assert.fail('Total time for task was not found');
-        return;
       }
       assert.strictEqual(taskDTotalTime, Trace.Types.Timing.Micro(3));
       assert.strictEqual(nodeD.selfTime, taskDTotalTime);
 
       const taskATotalTime = taskA.dur;
       if (taskATotalTime === undefined) {
         assert.fail('Total time for task was not found');
-        return;
       }
       assert.strictEqual(taskATotalTime, Trace.Types.Timing.Micro(10));
       assert.strictEqual(nodeA.selfTime, Trace.Types.Timing.Micro(taskATotalTime - taskBTotalTime - taskDTotalTime));
 
       const taskETotalTime = taskE.dur;
       if (taskETotalTime === undefined) {
         assert.fail('Total time for task was not found');
-        return;
       }
       assert.strictEqual(taskETotalTime, Trace.Types.Timing.Micro(3));
       assert.strictEqual(nodeD.selfTime, taskETotalTime);

front_end/panels/settings/KeybindsSettingsTab.ts

@@ -86,17 +86,17 @@ const UIStrings = {
    */
   shortcutRemoved: '{PH1} Shortcut removed',
   /**
-   *@description Screen reader announcment for shortcut restored to default
+   *@description Screen reader announcement for shortcut restored to default
    */
   shortcutChangesRestored: 'Changes to shortcut restored to default',
   /**
-   *@description Screen reader announcment for applied short cut changes
+   *@description Screen reader announcement for applied short cut changes
    */
   shortcutChangesApplied: 'Changes to shortcut applied',
   /**
-   *@description Screen reader announcment for discarded short cut changes
+   *@description Screen reader announcement for discarded short cut changes
    */
-  shortcutChangesDiscared: 'Changes to shortcut discarded',
+  shortcutChangesDiscarded: 'Changes to shortcut discarded',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/settings/KeybindsSettingsTab.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -410,7 +410,7 @@ export class ShortcutListItem {
     this.element.appendChild(
         this.createIconButton(i18nString(UIStrings.discardChanges), 'cross', 'keybinds-cancel-button', 'cancel', () => {
           this.settingsTab.stopEditing(this.item);
-          UI.ARIAUtils.LiveAnnouncer.alert(i18nString(UIStrings.shortcutChangesDiscared));
+          UI.ARIAUtils.LiveAnnouncer.alert(i18nString(UIStrings.shortcutChangesDiscarded));
         }));
     this.element.addEventListener('keydown', event => {
       if (Platform.KeyboardUtilities.isEscKey(event)) {

test/e2e_non_hosted/memory/memory_test.ts

@@ -154,14 +154,14 @@ describe('The Memory Panel', function() {
     await devToolsPage.waitForFunction(async () => {
       const pendingActivitiesSpan =
           await devToolsPage.waitFor('//span[text()="Pending activities"]', undefined, undefined, 'xpath');
-      const pendingActiviesRow =
+      const pendingActivitiesRow =
           await devToolsPage.waitFor('ancestor-or-self::tr', pendingActivitiesSpan, undefined, 'xpath');
       try {
         await devToolsPage.clickElement(pendingActivitiesSpan);
       } catch {
         return false;
       }
-      const res = await pendingActiviesRow.evaluate(x => x.classList.toString());
+      const res = await pendingActivitiesRow.evaluate(x => x.classList.toString());
       return res.includes('selected');
     });
     await devToolsPage.page.keyboard.press('ArrowRight');
@@ -176,8 +176,8 @@ describe('The Memory Panel', function() {
     });
     await devToolsPage.page.keyboard.press('ArrowRight');
     await devToolsPage.waitForFunction(async () => {
-      const pendingActiviesChildren = await devToolsPage.waitForElementsWithTextContent('MediaQueryList');
-      return pendingActiviesChildren.length === 2;
+      const pendingActivitiesChildren = await devToolsPage.waitForElementsWithTextContent('MediaQueryList');
+      return pendingActivitiesChildren.length === 2;
     });
   });
 
@@ -252,8 +252,8 @@ describe('The Memory Panel', function() {
 
         // check that we found two V8EventListener objects
         await devToolsPage.waitForFunction(async () => {
-          const pendingActiviesChildren = await devToolsPage.waitForElementsWithTextContent('V8EventListener');
-          return pendingActiviesChildren.length === 2;
+          const pendingActivitiesChildren = await devToolsPage.waitForElementsWithTextContent('V8EventListener');
+          return pendingActivitiesChildren.length === 2;
         });
 
         // Now we want to get the two rows below the "shared in leaking()" row and assert on them.