AI: Remove ellipses from function titles

This CL removes ellipses (… or ...) from the titles used in
`declareFunction` calls across all AI agents.

Fixed: 498881295
Change-Id: Ie7c6f553a76d4355b192cc4517c44ae5b5d9fd1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7725365
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>

Author: jackfranklin

front_end/models/ai_assistance/agents/AccessibilityAgent.test.ts

@@ -86,7 +86,7 @@ describeWithMockConnection('AccessibilityAgent', () => {
     const responses = await Array.fromAsync(agent.run('test', {selected: context}));
     const titleResponse = responses.find(response => response.type === AiAssistance.AiAgent.ResponseType.TITLE);
     assert.exists(titleResponse);
-    assert.strictEqual(titleResponse.title, 'Getting Lighthouse audits for accessibility…');
+    assert.strictEqual(titleResponse.title, 'Getting Lighthouse audits for accessibility');
   });
 
   it('can call the getStyles method', async () => {
@@ -143,7 +143,7 @@ describeWithMockConnection('AccessibilityAgent', () => {
     const responses = await Array.fromAsync(agent.run('test', {selected: context}));
     const titleResponse = responses.find(response => response.type === AiAssistance.AiAgent.ResponseType.TITLE);
     assert.exists(titleResponse);
-    assert.strictEqual(titleResponse.title, 'Running accessibility audits…');
+    assert.strictEqual(titleResponse.title, 'Running accessibility audits');
     assert.isTrue(lighthouseRecording.calledOnceWith({
       mode: 'snapshot',
       categoryIds: ['accessibility'],

front_end/models/ai_assistance/agents/AccessibilityAgent.ts

@@ -240,7 +240,7 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
       },
       displayInfoFromArgs: params => {
         return {
-          title: i18n.i18n.lockedString('Running accessibility audits…'),
+          title: i18n.i18n.lockedString('Running accessibility audits'),
           thought: params.explanation,
           action: 'runAccessibilityAudits()'
         };
@@ -282,7 +282,7 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
       },
       displayInfoFromArgs: params => {
         return {
-          title: i18n.i18n.lockedString(`Getting Lighthouse audits for ${params.categoryId}…`),
+          title: i18n.i18n.lockedString(`Getting Lighthouse audits for ${params.categoryId}`),
           action: `getLighthouseAudits('${params.categoryId}')`
         };
       },

front_end/models/ai_assistance/agents/BreakpointDebuggerAgent.ts

@@ -407,7 +407,7 @@ export class BreakpointDebuggerAgent extends AiAgent<Workspace.UISourceCode.UILo
       },
       displayInfoFromArgs: () => {
         return {
-          title: 'Waiting for user action...',
+          title: 'Waiting for user action',
           thought: 'I am waiting for you to trigger a breakpoint in the application.',
         };
       },

front_end/models/ai_assistance/agents/ContextSelectionAgent.ts

@@ -110,7 +110,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
       },
       displayInfoFromArgs: () => {
         return {
-          title: lockedString('Listing network requests…'),
+          title: lockedString('Listing network requests'),
           action: 'listNetworkRequest()',
         };
       },
@@ -175,7 +175,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
       },
       displayInfoFromArgs: args => {
         return {
-          title: lockedString('Getting network request…'),
+          title: lockedString('Getting network request'),
           action: `selectNetworkRequest(${args.id})`,
         };
       },
@@ -215,7 +215,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
       },
       displayInfoFromArgs: () => {
         return {
-          title: lockedString('Listing source requests…'),
+          title: lockedString('Listing source requests'),
           action: 'listSourceFiles()',
         };
       },
@@ -252,7 +252,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
       },
       displayInfoFromArgs: args => {
         return {
-          title: lockedString('Getting source file…'),
+          title: lockedString('Getting source file'),
           action: `selectSourceFile(${args.id})`,
         };
       },
@@ -285,7 +285,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
       },
       displayInfoFromArgs: () => {
         return {
-          title: 'Recording a performance trace…',
+          title: 'Recording a performance trace',
           action: 'performanceRecordAndReload()',
         };
       },
@@ -317,7 +317,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
       },
       displayInfoFromArgs: () => {
         return {
-          title: 'Auditing your page with Lighthouse…',
+          title: 'Auditing your page with Lighthouse',
           action: 'runLighthouseAudits()',
         };
       },

front_end/models/ai_assistance/agents/PerformanceAgent.test.ts

@@ -522,7 +522,7 @@ code
       const expectedOutput = JSON.stringify({summary: expectedRequestsOutput});
       const titleResponse = responses.find(response => response.type === AiAgent.ResponseType.TITLE);
       assert.exists(titleResponse);
-      assert.strictEqual(titleResponse.title, 'Investigating network activity…');
+      assert.strictEqual(titleResponse.title, 'Investigating network activity');
 
       assert.deepEqual(action, {
         type: 'action' as AiAgent.ActionResponse['type'],
@@ -555,7 +555,7 @@ code
       const responses = await Array.fromAsync(agent.run('test', {selected: context}));
       const titleResponse = responses.find(response => response.type === AiAgent.ResponseType.TITLE);
       assert.exists(titleResponse);
-      assert.strictEqual(titleResponse.title, 'Investigating main thread activity…');
+      assert.strictEqual(titleResponse.title, 'Investigating main thread activity');
 
       const action = responses.find(response => response.type === AiAgent.ResponseType.ACTION);
       assert.exists(action);

front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -41,11 +41,11 @@ const UIStringsNotTranslated = {
   /**
    * @description Shown when the agent is investigating network activity
    */
-  networkActivitySummary: 'Investigating network activity…',
+  networkActivitySummary: 'Investigating network activity',
   /**
    * @description Shown when the agent is investigating main thread activity
    */
-  mainThreadActivity: 'Investigating main thread activity…',
+  mainThreadActivity: 'Investigating main thread activity',
 } as const;
 const lockedString = i18n.i18n.lockedString;
 
@@ -805,7 +805,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       },
       displayInfoFromArgs: params => {
         return {
-          title: lockedString(`Investigating insight ${params.insightName}…`),
+          title: lockedString(`Investigating insight ${params.insightName}`),
           action: `getInsightDetails('${params.insightSetId}', '${params.insightName}')`
         };
       },
@@ -903,7 +903,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
         required: ['eventKey']
       },
       displayInfoFromArgs: params => {
-        return {title: lockedString('Looking at trace event…'), action: `getEventByKey('${params.eventKey}')`};
+        return {title: lockedString('Looking at trace event'), action: `getEventByKey('${params.eventKey}')`};
       },
       handler: async params => {
         debugLog('Function call: getEventByKey', params);
@@ -1093,7 +1093,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
         required: ['eventKey']
       },
       displayInfoFromArgs: args => {
-        return {title: lockedString('Looking at call tree…'), action: `getDetailedCallTree('${args.eventKey}')`};
+        return {title: lockedString('Looking at call tree'), action: `getDetailedCallTree('${args.eventKey}')`};
       },
       handler: async args => {
         debugLog('Function call: getDetailedCallTree');
@@ -1213,7 +1213,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       },
       displayInfoFromArgs: args => {
         return {
-          title: lockedString('Looking up function code…'),
+          title: lockedString('Looking up function code'),
           action: `getFunctionCode('${args.scriptUrl}', ${args.line}, ${args.column})`
         };
       },
@@ -1271,7 +1271,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
         required: ['url']
       },
       displayInfoFromArgs: args => {
-        return {title: lockedString('Looking at resource content…'), action: `getResourceContent('${args.url}')`};
+        return {title: lockedString('Looking at resource content'), action: `getResourceContent('${args.url}')`};
       },
       handler: async args => {
         debugLog('Function call: getResourceContent');
@@ -1326,7 +1326,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
           required: ['eventKey']
         },
         displayInfoFromArgs: params => {
-          return {title: lockedString('Selecting event…'), action: `selectEventByKey('${params.eventKey}')`};
+          return {title: lockedString('Selecting event'), action: `selectEventByKey('${params.eventKey}')`};
         },
         handler: async params => {
           debugLog('Function call: selectEventByKey', params);