Migrate test/e2e/sources/breakpoint-javascript_test.ts

Fixed: 416404716
Change-Id: Ia9241360d721b2b8a9055c2f45337714f076333b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6787828
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

Author: Liviu Rau

test/e2e/helpers/sources-helpers.ts

@@ -188,13 +188,13 @@ export async function getSelectedSource(): Promise<string> {
   return await (sourceTabs.evaluate(node => node.getAttribute('aria-label')) as Promise<string>);
 }
 
-export async function getBreakpointHitLocation() {
-  const breakpointHitHandle = await waitFor('.breakpoint-item.hit');
-  const locationHandle = await waitFor('.location', breakpointHitHandle);
+export async function getBreakpointHitLocation(devToolsPage = getBrowserAndPagesWrappers().devToolsPage) {
+  const breakpointHitHandle = await devToolsPage.waitFor('.breakpoint-item.hit');
+  const locationHandle = await devToolsPage.waitFor('.location', breakpointHitHandle);
   const locationText = await locationHandle.evaluate(location => location.textContent);
 
   const groupHandle = await breakpointHitHandle.evaluateHandle(x => x.parentElement!);
-  const groupHeaderTitleHandle = await waitFor('.group-header-title', groupHandle);
+  const groupHeaderTitleHandle = await devToolsPage.waitFor('.group-header-title', groupHandle);
   const groupHeaderTitle = await groupHeaderTitleHandle?.evaluate(header => header.textContent);
 
   return `${groupHeaderTitle}:${locationText}`;

test/e2e/sources/BUILD.gn

@@ -6,7 +6,6 @@ import("../../../scripts/build/typescript/typescript.gni")
 
 node_ts_library("sources") {
   sources = [
-    "breakpoint-javascript_test.ts",
     "can-disable-auto-sources-focus_test.ts",
     "overrides_test.ts",
   ]

test/e2e/sources/breakpoint-javascript_test.ts

@@ -8,6 +8,7 @@ ts_e2e_library("sources") {
   sources = [
     "authored-deployed-grouping_test.ts",
     "breakpoint-csp-violations_test.ts",
+    "breakpoint-javascript_test.ts",
     "breakpoints-sidebarpane_test.ts",
     "can-break-with-wasm-sourcemaps_test.ts",
     "can-handle-special-characters_test.ts",