Add support for accessibility issues about interactive content in <summary>.

This updates the devtools frontend to match browser protocol changes
that are being made to support an additional accessibility issue about
interactive content in <summary>.  This both makes the updates to match
the rename of SelectElementAccessibilityIssue (and related types and
fields) to ElementAccessibilityIssue and adds the frontend support for
the new issue reason reporting interactive content inside of <summary>.

This includes a manual roll of the browser protocol (which has
incompatible changes), excluding the separately-incompatible addition of
SharedWorkerMessage.

Bug: 427172874
Change-Id: I4e87be8d05b5453733285e11b4d3873829c31311
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6653379
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>

Author: dbaron

DEPS

@@ -23,8 +23,8 @@ vars = {
   'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
   'inspector_protocol_revision': '6d1ae0f13aae6ad381ca31b17b88a0f5af29ca94',
 
-  # Keeping track of the last time we rollerd the browser protocol files.
-  'chromium_browser_protocol_revision' : '9a6cdde91b579b777f10c566efb8b25d7552f21e',
+  # Keeping track of the last time we rolled the browser protocol files.
+  'chromium_browser_protocol_revision' : 'a5302fd8428c0287f753b2503b2f06d4550ab307',
 
   'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
   'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',
@@ -49,7 +49,7 @@ vars = {
   # Chrome version used for tests. It should be regularly updated to
   # match the Canary version listed here:
   # https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
-  'chrome': '139.0.7247.0',
+  'chrome': '140.0.7260.0',
 
   # 'magic' text to tell depot_tools that git submodules should be accepted but
   # but parity with DEPS file is expected.

config/gni/devtools_grd_files.gni

@@ -565,6 +565,7 @@ grd_files_bundled_sources = [
   "front_end/models/issues_manager/descriptions/sriValidationFailedSignatureMismatch.md",
   "front_end/models/issues_manager/descriptions/stylesheetLateImport.md",
   "front_end/models/issues_manager/descriptions/stylesheetRequestFailed.md",
+  "front_end/models/issues_manager/descriptions/summaryElementAccessibilityInteractiveContentSummaryDescendant.md",
   "front_end/models/issues_manager/descriptions/userReidentificationBlocked.md",
   "front_end/models/issues_manager/issues_manager.js",
   "front_end/models/javascript_metadata/javascript_metadata.js",
@@ -1052,6 +1053,7 @@ grd_files_unbundled_sources = [
   "front_end/models/issues_manager/CorsIssue.js",
   "front_end/models/issues_manager/CrossOriginEmbedderPolicyIssue.js",
   "front_end/models/issues_manager/DeprecationIssue.js",
+  "front_end/models/issues_manager/ElementAccessibilityIssue.js",
   "front_end/models/issues_manager/FederatedAuthRequestIssue.js",
   "front_end/models/issues_manager/FederatedAuthUserInfoRequestIssue.js",
   "front_end/models/issues_manager/GenericIssue.js",
@@ -1068,7 +1070,6 @@ grd_files_unbundled_sources = [
   "front_end/models/issues_manager/QuirksModeIssue.js",
   "front_end/models/issues_manager/RelatedIssue.js",
   "front_end/models/issues_manager/SRIMessageSignatureIssue.js",
-  "front_end/models/issues_manager/SelectElementAccessibilityIssue.js",
   "front_end/models/issues_manager/SharedArrayBufferIssue.js",
   "front_end/models/issues_manager/SharedDictionaryIssue.js",
   "front_end/models/issues_manager/SourceFrameIssuesManager.js",

front_end/core/host/UserMetrics.ts

@@ -951,11 +951,11 @@ export enum IssueCreated {
   'CookieIssue::WarnThirdPartyPhaseout::SetCookie' = 83,
   'CookieIssue::ExcludeThirdPartyPhaseout::ReadCookie' = 84,
   'CookieIssue::ExcludeThirdPartyPhaseout::SetCookie' = 85,
-  'SelectElementAccessibilityIssue::DisallowedSelectChild' = 86,
-  'SelectElementAccessibilityIssue::DisallowedOptGroupChild' = 87,
-  'SelectElementAccessibilityIssue::NonPhrasingContentOptionChild' = 88,
-  'SelectElementAccessibilityIssue::InteractiveContentOptionChild' = 89,
-  'SelectElementAccessibilityIssue::InteractiveContentLegendChild' = 90,
+  'ElementAccessibilityIssue::DisallowedSelectChild' = 86,
+  'ElementAccessibilityIssue::DisallowedOptGroupChild' = 87,
+  'ElementAccessibilityIssue::NonPhrasingContentOptionChild' = 88,
+  'ElementAccessibilityIssue::InteractiveContentOptionChild' = 89,
+  'ElementAccessibilityIssue::InteractiveContentLegendChild' = 90,
   'SRIMessageSignatureIssue::MissingSignatureHeader' = 91,
   'SRIMessageSignatureIssue::MissingSignatureInputHeader' = 92,
   'SRIMessageSignatureIssue::InvalidSignatureHeader' = 93,
@@ -978,8 +978,9 @@ export enum IssueCreated {
   'SRIMessageSignatureIssue::ValidationFailedSignatureMismatch' = 110,
   'CorsIssue::LocalNetworkAccessPermissionDenied' = 111,
   'SRIMessageSignatureIssue::ValidationFailedIntegrityMismatch' = 112,
+  'ElementAccessibilityIssue::InteractiveContentSummaryDescendant' = 113,
   /* eslint-enable @typescript-eslint/naming-convention */
-  MAX_VALUE = 113,
+  MAX_VALUE = 114,
 }
 
 export const enum DeveloperResourceLoaded {

front_end/generated/InspectorBackendCommands.js

@@ -1336,20 +1336,21 @@ export namespace Audits {
     partitioningBlobURLInfo: PartitioningBlobURLInfo;
   }
 
-  export const enum SelectElementAccessibilityIssueReason {
+  export const enum ElementAccessibilityIssueReason {
     DisallowedSelectChild = 'DisallowedSelectChild',
     DisallowedOptGroupChild = 'DisallowedOptGroupChild',
     NonPhrasingContentOptionChild = 'NonPhrasingContentOptionChild',
     InteractiveContentOptionChild = 'InteractiveContentOptionChild',
     InteractiveContentLegendChild = 'InteractiveContentLegendChild',
+    InteractiveContentSummaryDescendant = 'InteractiveContentSummaryDescendant',
   }
 
   /**
-   * This issue warns about errors in the select element content model.
+   * This issue warns about errors in the select or summary element content model.
    */
-  export interface SelectElementAccessibilityIssueDetails {
+  export interface ElementAccessibilityIssueDetails {
     nodeId: DOM.BackendNodeId;
-    selectElementAccessibilityIssueReason: SelectElementAccessibilityIssueReason;
+    elementAccessibilityIssueReason: ElementAccessibilityIssueReason;
     hasDisallowedAttributes: boolean;
   }
 
@@ -1447,7 +1448,7 @@ export namespace Audits {
     FederatedAuthUserInfoRequestIssue = 'FederatedAuthUserInfoRequestIssue',
     PropertyRuleIssue = 'PropertyRuleIssue',
     SharedDictionaryIssue = 'SharedDictionaryIssue',
-    SelectElementAccessibilityIssue = 'SelectElementAccessibilityIssue',
+    ElementAccessibilityIssue = 'ElementAccessibilityIssue',
     SRIMessageSignatureIssue = 'SRIMessageSignatureIssue',
     UserReidentificationIssue = 'UserReidentificationIssue',
   }
@@ -1480,7 +1481,7 @@ export namespace Audits {
     propertyRuleIssueDetails?: PropertyRuleIssueDetails;
     federatedAuthUserInfoRequestIssueDetails?: FederatedAuthUserInfoRequestIssueDetails;
     sharedDictionaryIssueDetails?: SharedDictionaryIssueDetails;
-    selectElementAccessibilityIssueDetails?: SelectElementAccessibilityIssueDetails;
+    elementAccessibilityIssueDetails?: ElementAccessibilityIssueDetails;
     sriMessageSignatureIssueDetails?: SRIMessageSignatureIssueDetails;
     userReidentificationIssueDetails?: UserReidentificationIssueDetails;
   }
@@ -13020,16 +13021,6 @@ export namespace Page {
     themeColor?: string;
   }
 
-  /**
-   * Enum of possible auto-response for permission / prompt dialogs.
-   */
-  export const enum AutoResponseMode {
-    None = 'none',
-    AutoAccept = 'autoAccept',
-    AutoReject = 'autoReject',
-    AutoOptOut = 'autoOptOut',
-  }
-
   /**
    * The type of a frameNavigated event.
    */
@@ -13972,12 +13963,26 @@ export namespace Page {
     data: binary;
   }
 
+  export const enum SetSPCTransactionModeRequestMode {
+    None = 'none',
+    AutoAccept = 'autoAccept',
+    AutoChooseToAuthAnotherWay = 'autoChooseToAuthAnotherWay',
+    AutoReject = 'autoReject',
+    AutoOptOut = 'autoOptOut',
+  }
+
   export interface SetSPCTransactionModeRequest {
-    mode: AutoResponseMode;
+    mode: SetSPCTransactionModeRequestMode;
+  }
+
+  export const enum SetRPHRegistrationModeRequestMode {
+    None = 'none',
+    AutoAccept = 'autoAccept',
+    AutoReject = 'autoReject',
   }
 
   export interface SetRPHRegistrationModeRequest {
-    mode: AutoResponseMode;
+    mode: SetRPHRegistrationModeRequestMode;
   }
 
   export interface GenerateTestReportRequest {

front_end/generated/protocol.ts

@@ -21,6 +21,7 @@ devtools_module("issues_manager") {
     "CorsIssue.ts",
     "CrossOriginEmbedderPolicyIssue.ts",
     "DeprecationIssue.ts",
+    "ElementAccessibilityIssue.ts",
     "FederatedAuthRequestIssue.ts",
     "FederatedAuthUserInfoRequestIssue.ts",
     "GenericIssue.ts",
@@ -37,7 +38,6 @@ devtools_module("issues_manager") {
     "QuirksModeIssue.ts",
     "RelatedIssue.ts",
     "SRIMessageSignatureIssue.ts",
-    "SelectElementAccessibilityIssue.ts",
     "SharedArrayBufferIssue.ts",
     "SharedDictionaryIssue.ts",
     "SourceFrameIssuesManager.ts",
@@ -191,6 +191,7 @@ devtools_issue_description_files = [
   "selectElementAccessibilityInteractiveContentLegendChild.md",
   "selectElementAccessibilityInteractiveContentOptionChild.md",
   "selectElementAccessibilityNonPhrasingContentOptionChild.md",
+  "summaryElementAccessibilityInteractiveContentSummaryDescendant.md",
   "sharedArrayBuffer.md",
   "stylesheetLateImport.md",
   "stylesheetRequestFailed.md",
@@ -284,6 +285,7 @@ ts_library("unittests") {
   sources = [
     "CheckFormsIssuesTrigger.test.ts",
     "DeprecationIssue.test.ts",
+    "ElementAccessibilityIssue.test.ts",
     "FederatedAuthUserInfoRequestIssue.test.ts",
     "GenericIssue.test.ts",
     "Issue.test.ts",
@@ -294,7 +296,6 @@ ts_library("unittests") {
     "PropertyRuleIssue.test.ts",
     "RelatedIssue.test.ts",
     "SRIMessageSignatureIssue.test.ts",
-    "SelectElementAccessibilityIssue.test.ts",
     "SharedDictionaryIssue.test.ts",
     "StylesheetLoadingIssue.test.ts",
   ]

front_end/models/issues_manager/BUILD.gn

@@ -8,22 +8,22 @@ import {describeWithLocale, expectConsoleLogs} from '../../testing/EnvironmentHe
 import {MockIssuesModel} from '../../testing/MockIssuesModel.js';
 import * as IssuesManager from '../issues_manager/issues_manager.js';
 
-describeWithLocale('SelectElementAccessibilityIssue', () => {
+describeWithLocale('ElementAccessibilityIssue', () => {
   const mockModel = new MockIssuesModel([]) as unknown as SDK.IssuesModel.IssuesModel;
 
   function createProtocolIssueWithoutDetails(): Protocol.Audits.InspectorIssue {
     return {
-      code: Protocol.Audits.InspectorIssueCode.SelectElementAccessibilityIssue,
+      code: Protocol.Audits.InspectorIssueCode.ElementAccessibilityIssue,
       details: {},
     };
   }
 
   function createProtocolIssueWithDetails(
-      selectElementAccessibilityIssueDetails: Protocol.Audits.SelectElementAccessibilityIssueDetails):
+      elementAccessibilityIssueDetails: Protocol.Audits.ElementAccessibilityIssueDetails):
       Protocol.Audits.InspectorIssue {
     return {
-      code: Protocol.Audits.InspectorIssueCode.SelectElementAccessibilityIssue,
-      details: {selectElementAccessibilityIssueDetails},
+      code: Protocol.Audits.InspectorIssueCode.ElementAccessibilityIssue,
+      details: {elementAccessibilityIssueDetails},
     };
   }
 
@@ -33,22 +33,22 @@ describeWithLocale('SelectElementAccessibilityIssue', () => {
 
   it('can be created for various reasons', () => {
     const reasons = [
-      Protocol.Audits.SelectElementAccessibilityIssueReason.DisallowedSelectChild,
-      Protocol.Audits.SelectElementAccessibilityIssueReason.DisallowedOptGroupChild,
-      Protocol.Audits.SelectElementAccessibilityIssueReason.NonPhrasingContentOptionChild,
-      Protocol.Audits.SelectElementAccessibilityIssueReason.InteractiveContentOptionChild,
-      Protocol.Audits.SelectElementAccessibilityIssueReason.InteractiveContentLegendChild,
+      Protocol.Audits.ElementAccessibilityIssueReason.DisallowedSelectChild,
+      Protocol.Audits.ElementAccessibilityIssueReason.DisallowedOptGroupChild,
+      Protocol.Audits.ElementAccessibilityIssueReason.NonPhrasingContentOptionChild,
+      Protocol.Audits.ElementAccessibilityIssueReason.InteractiveContentOptionChild,
+      Protocol.Audits.ElementAccessibilityIssueReason.InteractiveContentLegendChild,
+      Protocol.Audits.ElementAccessibilityIssueReason.InteractiveContentSummaryDescendant,
     ];
     for (const reason of reasons) {
       const issueDetails = {
         nodeId: 1 as Protocol.DOM.BackendNodeId,
-        selectElementAccessibilityIssueReason: reason,
+        elementAccessibilityIssueReason: reason,
         hasDisallowedAttributes: false,
       };
       const issue = createProtocolIssueWithDetails(issueDetails);
       const selectIssues =
-          IssuesManager.SelectElementAccessibilityIssue.SelectElementAccessibilityIssue.fromInspectorIssue(
-              mockModel, issue);
+          IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue.fromInspectorIssue(mockModel, issue);
       assert.lengthOf(selectIssues, 1);
       const selectIssue = selectIssues[0];
 
@@ -61,24 +61,21 @@ describeWithLocale('SelectElementAccessibilityIssue', () => {
 
   it('adds a disallowed select child issue without details', () => {
     const inspectorIssueWithoutGenericDetails = createProtocolIssueWithoutDetails();
-    const selectIssues =
-        IssuesManager.SelectElementAccessibilityIssue.SelectElementAccessibilityIssue.fromInspectorIssue(
-            mockModel, inspectorIssueWithoutGenericDetails);
+    const selectIssues = IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue.fromInspectorIssue(
+        mockModel, inspectorIssueWithoutGenericDetails);
 
     assert.isEmpty(selectIssues);
   });
 
   it('adds an interactive content attributes select child issue with valid details', () => {
     const issueDetails = {
       nodeId: 1 as Protocol.DOM.BackendNodeId,
-      selectElementAccessibilityIssueReason:
-          Protocol.Audits.SelectElementAccessibilityIssueReason.InteractiveContentOptionChild,
+      elementAccessibilityIssueReason: Protocol.Audits.ElementAccessibilityIssueReason.InteractiveContentOptionChild,
       hasDisallowedAttributes: true,
     };
     const issue = createProtocolIssueWithDetails(issueDetails);
     const selectIssues =
-        IssuesManager.SelectElementAccessibilityIssue.SelectElementAccessibilityIssue.fromInspectorIssue(
-            mockModel, issue);
+        IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue.fromInspectorIssue(mockModel, issue);
     assert.lengthOf(selectIssues, 1);
     const selectIssue = selectIssues[0];