GreenDev: remove in-DevTools floaty prototype

We tested it, and now we do not need it.

Bug: 461428712
Change-Id: I11cd235a012c347f37e9e20b3e8f81030e3b9f57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7575893
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>

Author: jackfranklin

config/gni/devtools_grd_files.gni

@@ -2558,7 +2558,6 @@ grd_files_unbundled_sources = [
   "front_end/ui/legacy/EmptyWidget.js",
   "front_end/ui/legacy/FilterBar.js",
   "front_end/ui/legacy/FilterSuggestionBuilder.js",
-  "front_end/ui/legacy/Floaty.js",
   "front_end/ui/legacy/ForwardedInputEventHandler.js",
   "front_end/ui/legacy/Fragment.js",
   "front_end/ui/legacy/GlassPane.js",
@@ -2705,7 +2704,6 @@ grd_files_unbundled_sources = [
   "front_end/ui/legacy/dropTarget.css.js",
   "front_end/ui/legacy/emptyWidget.css.js",
   "front_end/ui/legacy/filter.css.js",
-  "front_end/ui/legacy/floaty.css.js",
   "front_end/ui/legacy/glassPane.css.js",
   "front_end/ui/legacy/infobar.css.js",
   "front_end/ui/legacy/inspectorCommon.css.js",

front_end/models/greendev/Prototypes.ts

@@ -8,7 +8,6 @@ import * as Root from '../../core/root/root.js';
 let instance: Prototypes|null = null;
 
 export interface GreenDevSettings {
-  inDevToolsFloaty: Common.Settings.Setting<boolean>;
   aiAnnotations: Common.Settings.Setting<boolean>;
   copyToGemini: Common.Settings.Setting<boolean>;
 }
@@ -36,9 +35,6 @@ export class Prototypes {
 
   settings(): Readonly<GreenDevSettings> {
     const settings = Common.Settings.Settings.instance();
-    const inDevToolsFloaty =
-        settings.createSetting('greendev-in-devtools-floaty-enabled', false, Common.Settings.SettingStorageType.LOCAL);
-
     const aiAnnotations = settings.createSetting(
         'greendev-ai-annotations-enabled',
         false,
@@ -47,6 +43,6 @@ export class Prototypes {
     const copyToGemini =
         settings.createSetting('greendev-copy-to-gemini-enabled', false, Common.Settings.SettingStorageType.LOCAL);
 
-    return {inDevToolsFloaty, aiAnnotations, copyToGemini};
+    return {aiAnnotations, copyToGemini};
   }
 }

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -13,7 +13,6 @@ import * as SDK from '../../core/sdk/sdk.js';
 import * as AiAssistanceModel from '../../models/ai_assistance/ai_assistance.js';
 import * as Annotations from '../../models/annotations/annotations.js';
 import * as Badges from '../../models/badges/badges.js';
-import * as GreenDev from '../../models/greendev/greendev.js';
 import * as TextUtils from '../../models/text_utils/text_utils.js';
 import type * as Trace from '../../models/trace/trace.js';
 import * as Workspace from '../../models/workspace/workspace.js';
@@ -518,7 +517,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   };
   #timelinePanelInstance: TimelinePanel.TimelinePanel.TimelinePanel|null = null;
   #runAbortController = new AbortController();
-  #additionalContextItemsFromFloaty: UI.Floaty.FloatyContextSelection[] = [];
 
   constructor(private view: View = defaultView, {aidaClient, aidaAvailability, syncInfo}: {
     aidaClient: Host.AidaClient.AidaClient,
@@ -571,7 +569,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       return {
         state: ViewState.CHAT_VIEW,
         props: {
-          additionalFloatyContext: this.#additionalContextItemsFromFloaty,
           blockedByCrossOrigin: this.#conversation.isBlockedByOrigin,
           isLoading: this.#isLoading,
           messages: this.#messages,
@@ -665,15 +662,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     }
   }
 
-  #bindFloatyListener(): void {
-    const additionalContexts = UI.Context.Context.instance().flavor(UI.Floaty.FloatyFlavor);
-    if (!additionalContexts) {
-      return;
-    }
-    this.#additionalContextItemsFromFloaty = additionalContexts.selectedContexts;
-    this.requestUpdate();
-  }
-
   async #handlePerformanceRecordAndReload(): Promise<Trace.TraceModel.ParsedTrace> {
     return await TimelinePanel.TimelinePanel.TimelinePanel.executeRecordAndReload();
   }
@@ -826,11 +814,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     this.#selectDefaultAgentIfNeeded();
 
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistancePanelOpened);
-
-    if (GreenDev.Prototypes.instance().isEnabled('inDevToolsFloaty')) {
-      UI.Context.Context.instance().addFlavorChangeListener(UI.Floaty.FloatyFlavor, this.#bindFloatyListener, this);
-      this.#bindFloatyListener();
-    }
   }
 
   override willHide(): void {
@@ -1469,7 +1452,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
             text,
             {
               signal,
-              extraContext: this.#additionalContextItemsFromFloaty,
               multimodalInput,
             },
             ),

front_end/panels/ai_assistance/components/ChatInput.test.ts

@@ -256,7 +256,6 @@ describeWithEnvironment('ChatInput', () => {
             inputPlaceholder: 'Type a message...' as Platform.UIString.LocalizedString,
             selectedContext: null,
             inspectElementToggled: false,
-            additionalFloatyContext: [],
             disclaimerText: 'Disclaimer text',
             conversationType: AiAssistanceModel.AiHistoryStorage.ConversationType.STYLING,
             multimodalInputEnabled: true,
@@ -295,7 +294,6 @@ describeWithEnvironment('ChatInput', () => {
             inputPlaceholder: 'Type a message...' as Platform.UIString.LocalizedString,
             selectedContext: null,
             inspectElementToggled: false,
-            additionalFloatyContext: [],
             disclaimerText: 'Disclaimer text',
             conversationType: AiAssistanceModel.AiHistoryStorage.ConversationType.STYLING,
             multimodalInputEnabled: false,

front_end/panels/ai_assistance/components/ChatInput.ts

@@ -10,8 +10,6 @@ import type * as Platform from '../../../core/platform/platform.js';
 import * as SDK from '../../../core/sdk/sdk.js';
 import * as Protocol from '../../../generated/protocol.js';
 import * as AiAssistanceModel from '../../../models/ai_assistance/ai_assistance.js';
-import * as GreenDev from '../../../models/greendev/greendev.js';
-import * as Trace from '../../../models/trace/trace.js';
 import * as Workspace from '../../../models/workspace/workspace.js';
 import * as PanelsCommon from '../../../panels/common/common.js';
 import * as PanelUtils from '../../../panels/utils/utils.js';
@@ -123,7 +121,6 @@ export interface ViewInput {
   inputPlaceholder: Platform.UIString.LocalizedString;
   selectedContext: AiAssistanceModel.AiAgent.ConversationContext<unknown>|null;
   inspectElementToggled: boolean;
-  additionalFloatyContext: UI.Floaty.FloatyContextSelection[];
   disclaimerText: string;
   conversationType: AiAssistanceModel.AiHistoryStorage.ConversationType;
   multimodalInputEnabled: boolean;
@@ -151,22 +148,19 @@ export interface ViewInput {
 
 export type ViewOutput = undefined;
 
-export const
-    DEFAULT_VIEW =
-        (input: ViewInput, output: ViewOutput, target: HTMLElement):
-            void => {
-              const chatInputContainerCls = Lit.Directives.classMap({
-                'chat-input-container': true,
-                'single-line-layout': !input.selectedContext && !input.onContextAdd,
-                disabled: input.isTextInputDisabled,
-              });
-
-              const renderRelevantDataDisclaimer = (tooltipId: string): Lit.LitTemplate => {
-                const classes = Lit.Directives.classMap({
-                  'chat-input-disclaimer': true,
-                  'hide-divider': !input.isLoading && input.blockedByCrossOrigin,
-                });
-                // clang-format off
+export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: HTMLElement): void => {
+  const chatInputContainerCls = Lit.Directives.classMap({
+    'chat-input-container': true,
+    'single-line-layout': !input.selectedContext && !input.onContextAdd,
+    disabled: input.isTextInputDisabled,
+  });
+
+  const renderRelevantDataDisclaimer = (tooltipId: string): Lit.LitTemplate => {
+    const classes = Lit.Directives.classMap({
+      'chat-input-disclaimer': true,
+      'hide-divider': !input.isLoading && input.blockedByCrossOrigin,
+    });
+    // clang-format off
     return html`
       <div class=${classes}>
         <button
@@ -198,10 +192,10 @@ export const
         </div></devtools-tooltip>
       </div>
     `;
-                // clang-format on
-              };
+    // clang-format on
+  };
 
-              // clang-format off
+  // clang-format off
   Lit.render(html`
     <style>${Input.textInputStyles}</style>
     <style>${chatInputStyles}</style>
@@ -226,52 +220,6 @@ export const
       :
       html`
         <form class="input-form" @submit=${input.onSubmit}>
-          ${GreenDev.Prototypes.instance().isEnabled('inDevToolsFloaty') ?
-            html`
-              <ul class="floaty">
-                ${input.additionalFloatyContext.map(c => {
-                  return html`
-                    <li>
-                      <span class="context-item">
-                        ${c instanceof SDK.NetworkRequest.NetworkRequest ? html`${c.url()}` :
-                          c instanceof SDK.DOMModel.DOMNode ? html`
-                            <devtools-widget .widgetConfig=${
-                              UI.Widget.widgetConfig(PanelsCommon.DOMLinkifier.DOMNodeLink, {node: c})}
-                            ></devtools-widget>` :
-                          'insight' in c ? html`${c.insight.title}` :
-                          'event' in c && 'traceStartTime' in c ? html`
-                            ${c.event.name} @ ${i18n.TimeUtilities.formatMicroSecondsAsMillisFixed(Trace.Types.Timing.Micro(c.event.ts - c.traceStartTime))}` :
-                          Lit.nothing}
-                      </span>
-                      <devtools-button
-                        class="floaty-delete-button"
-                        @click=${(e: MouseEvent) => {
-                          e.preventDefault();
-                          UI.Floaty.onFloatyContextDelete(c);
-                        }}
-                        .data=${{
-                          variant: Buttons.Button.Variant.ICON,
-                          iconName: 'cross',
-                          title: 'Delete',
-                          size: Buttons.Button.Size.SMALL,
-                        } as Buttons.Button.ButtonData}
-                      ></devtools-button>
-                    </li>`;
-                })}
-                <li class="open-floaty">
-                  <devtools-button
-                    class="floaty-add-button"
-                    @click=${UI.Floaty.onFloatyOpen}
-                    .data=${{
-                      variant: Buttons.Button.Variant.ICON,
-                      iconName: 'select-element',
-                      title: 'Open context picker',
-                      size: Buttons.Button.Size.SMALL,
-                    } as Buttons.Button.ButtonData}
-                  ></devtools-button>
-                </li>
-              </ul>`
-            : Lit.nothing}
           <div class=${chatInputContainerCls}>
             ${(input.multimodalInputEnabled && input.imageInput && !input.isTextInputDisabled) ?
               html`
@@ -495,8 +443,8 @@ export const
       ${renderRelevantDataDisclaimer(RELEVANT_DATA_LINK_FOOTER_ID)}
     </footer>
   `, target);
-              // clang-format on
-            };
+  // clang-format on
+};
 
 /**
  * ChatInput is a presenter for the input area in the AI Assistance panel.
@@ -508,7 +456,6 @@ export class ChatInput extends UI.Widget.Widget implements SDK.TargetManager.Obs
   inputPlaceholder = '' as Platform.UIString.LocalizedString;
   selectedContext = null as AiAssistanceModel.AiAgent.ConversationContext<unknown>| null;
   inspectElementToggled = false;
-  additionalFloatyContext = [] as UI.Floaty.FloatyContextSelection[];
   disclaimerText = '';
   conversationType = AiAssistanceModel.AiHistoryStorage.ConversationType.STYLING;
   multimodalInputEnabled = false;
@@ -697,7 +644,6 @@ export class ChatInput extends UI.Widget.Widget implements SDK.TargetManager.Obs
           selectedContext: this.selectedContext,
           inspectElementToggled: this.inspectElementToggled,
           isTextInputEmpty: this.#isTextInputEmpty(),
-          additionalFloatyContext: this.additionalFloatyContext,
           disclaimerText: this.disclaimerText,
           conversationType: this.conversationType,
           multimodalInputEnabled: this.multimodalInputEnabled,

front_end/panels/ai_assistance/components/ChatView.test.ts

@@ -40,7 +40,6 @@ describeWithEnvironment('ChatView', () => {
       inputPlaceholder: i18n.i18n.lockedString('input placeholder'),
       disclaimerText: i18n.i18n.lockedString('disclaimer text'),
       markdownRenderer: new AiAssistancePanel.MarkdownRendererWithCodeBlock(),
-      additionalFloatyContext: [],
       ...options,
     };
   }

front_end/panels/ai_assistance/components/ChatView.ts

@@ -76,7 +76,6 @@ export interface Props {
   disclaimerText: Platform.UIString.LocalizedString;
   uploadImageInputEnabled?: boolean;
   markdownRenderer: MarkdownLitRenderer;
-  additionalFloatyContext: UI.Floaty.FloatyContextSelection[];
 }
 
 interface ChatWidgetInput extends Props {
@@ -171,7 +170,6 @@ const DEFAULT_VIEW: View = (input, output, target) => {
             conversationType: input.conversationType,
             uploadImageInputEnabled: input.uploadImageInputEnabled ?? false,
             isReadOnly: input.isReadOnly,
-            additionalFloatyContext: input.additionalFloatyContext,
             onContextClick: input.onContextClick,
             onInspectElementClick: input.onInspectElementClick,
             onTextSubmit: input.onTextSubmit,

front_end/panels/elements/ElementsTreeElement.ts

@@ -1702,13 +1702,6 @@ export class ElementsTreeElement extends UI.TreeOutline.TreeElement {
     if (this.editing) {
       return false;
     }
-    const handledByFloaty = UI.Floaty.onFloatyClick({
-      type: UI.Floaty.FloatyContextTypes.ELEMENT_NODE_ID,
-      data: {nodeId: this.nodeInternal.id},
-    });
-    if (handledByFloaty) {
-      return false;
-    }
     return super.select(omitFocus, selectedByUser);
   }
 

front_end/panels/network/NetworkDataGridNode.ts

@@ -1185,14 +1185,6 @@ export class NetworkRequestNode extends NetworkNode {
   }
 
   override select(suppressSelectedEvent?: boolean): void {
-    const id = this.request()?.requestId();
-    if (id) {
-      const floatyHandled =
-          UI.Floaty.onFloatyClick({type: UI.Floaty.FloatyContextTypes.NETWORK_REQUEST, data: {requestId: id}});
-      if (floatyHandled) {
-        return;
-      }
-    }
     super.select(suppressSelectedEvent);
     this.parentView().dispatchEventToListeners(Events.RequestSelected, this.requestInternal);
   }

front_end/panels/settings/SettingsScreen.ts

@@ -637,7 +637,7 @@ const GREENDEV_VIEW: View = (input, _output, target) => {
               <span>${i18nString(UIStrings.greenDevUnstable)}</span>
              </div>
              <div class="settings-experiments-block">
-               ${renderPrototypeCheckboxes(input.settings, ['aiAnnotations', 'inDevToolsFloaty', 'copyToGemini'])}
+               ${renderPrototypeCheckboxes(input.settings, ['aiAnnotations', 'copyToGemini'])}
              </div>
            </devtools-card>
          </div>
@@ -646,7 +646,6 @@ const GREENDEV_VIEW: View = (input, _output, target) => {
 };
 
 const GREENDEV_PROTOTYPE_NAMES: Record<keyof GreenDev.GreenDevSettings, string> = {
-  inDevToolsFloaty: 'In DevTools context picker',
   aiAnnotations: 'AI auto-annotations',
   copyToGemini: 'Copy changes to AI Prompt'
 };