Skip to content

Commit a0d078c

Browse files
authored
fix: align sub-range binding with current spec text (#5)
1 parent 3a84349 commit a0d078c

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/decode/decode.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -468,10 +468,10 @@ describe("decode", () => {
468468
encoder.addUnsignedVLQs(Tag.GENERATED_RANGE_BINDINGS, 2).finishItem();
469469

470470
// 1st sub-range binding for variable 0. from 1,0, value is "var1" (index 1)
471-
encoder.addUnsignedVLQs(Tag.GENERATED_RANGE_SUBRANGE_BINDING, 0, 1, 1, 0)
471+
encoder.addUnsignedVLQs(Tag.GENERATED_RANGE_SUBRANGE_BINDING, 0, 1, 0, 1)
472472
.finishItem();
473473
// 2nd sub-range binding for variable 0. from 2,0, value is "baz" (index 3)
474-
encoder.addUnsignedVLQs(Tag.GENERATED_RANGE_SUBRANGE_BINDING, 0, 3, 1, 0)
474+
encoder.addUnsignedVLQs(Tag.GENERATED_RANGE_SUBRANGE_BINDING, 0, 1, 0, 3)
475475
.finishItem();
476476
encoder.addUnsignedVLQs(Tag.GENERATED_RANGE_END, 3, 0).finishItem();
477477
const map = createMap(encoder.encode(), ["var1", "bar", "baz"]);

src/decode/decode.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ class Decoder {
541541
value: value as string | undefined,
542542
});
543543

544-
for (const [binding, line, column] of bindings) {
544+
for (const [line, column, binding] of bindings) {
545545
lastLine += line;
546546
if (line === 0) {
547547
lastColumn += column;

src/encode/encoder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,8 @@ export class Encoder {
228228
const binding = subRange.value === undefined
229229
? 0
230230
: this.#resolveNamesIdx(subRange.value) + 1;
231-
this.#encodeUnsigned(binding).#encodeUnsigned(encodedLine)
232-
.#encodeUnsigned(encodedColumn);
231+
this.#encodeUnsigned(encodedLine).#encodeUnsigned(encodedColumn)
232+
.#encodeUnsigned(binding);
233233
}
234234
this.#finishItem();
235235
}

0 commit comments

Comments
 (0)