New ScopedTimer and small cmake fixes#7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the timer utilities and build configuration for the project. The main changes include refactoring the
TimerandScopedTimerclasses for better usability and safety, updating their implementation, and enhancing the CMake presets to support multiple build types and compilers. Additionally, tests forScopedTimerare now enabled.Timer utility improvements:
TimerandScopedTimerclasses intimer.hppandtimer.cppto consistently use an internalclocktype alias, improved the interface ofScopedTimerto output elapsed time via a reference, and implemented its destructor for automatic timing. [1] [2]ScopedTimerintest_timer.cpp, ensuring it correctly measures elapsed time.Build configuration enhancements:
CMakePresets.jsonto define separate build directories for each preset (e.g.,build-debug,build-release,build-clang-debug, etc.), and added a newmsvc-debugpreset for MSVC builds. This makes it easier to manage and switch between different build configurations. [1] [2] [3]