Convert MiniMessage hex colors to legacy ampersand format before translation#4
Draft
Chwitst187 wants to merge 1 commit into
Draft
Convert MiniMessage hex colors to legacy ampersand format before translation#4Chwitst187 wants to merge 1 commit into
Chwitst187 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
<#RRGGBB>while downstream color formatters only handle legacy&codes, causing hex tags to be shown literally instead of colored.Description
MINI_HEX_PATTERNregex and a helperconvertMiniMessageHexToLegacyAmpersand(String)that converts<#RRGGBB>into&x&R&R&G&G&B&Bsequences.formatMessage(...)to run the conversion before callingcolorFormatter.translateAlternateColorCodes('&', ...)so formatted messages render hex colors correctly.prefix(...)to apply the same conversion for consistent prefix rendering; changes are inplugman-core/src/main/java/core/com/rylinaux/plugman/file/messaging/MessageFormatter.javaand include an import forjava.util.regex.Pattern.Testing
mvn -q -pl plugman-core,plugman-bukkit -am test -DskipTests, but the Maven run failed due to external repository resolution returning HTTP 403 fromhttps://repo.maven.apache.org/maven2, so automated tests could not be executed in this environment.Codex Task