🎉 Release based_split_view v1.2.3 🎉

Author: Cierra-Runis

packages/based_split_view/CHANGELOG.md

@@ -1,58 +1,61 @@
+## 1.2.3
+
+- 🔧 Fix Issue Caused by 1.2.1
+
 ## 1.2.2
 
-🔧Drop 1.2.1 Changes
+- 🔧 Drop 1.2.1 Changes
 
 ## 1.2.1
 
-📖Update README.md to fix broken links
-🔧Use `canPop` of `Page` instead `onPopPage` method in `Navigator`
-🔧Use `onPopWithResult` instead `onPop` in `NavigatorPopHandler`
+- 📖 Update README.md to fix broken links
+- 🔧 Use `canPop` of `Page` instead `onPopPage` method in `Navigator`
+- 🔧 Use `onPopWithResult` instead `onPop` in `NavigatorPopHandler`
 
 ## 1.2.0
 
-⚠️Now `breakPoint` is deprecated
-🌍Add width adjustment [#1](https://github.com/Cierra-Runis/based_flutter/issues/1)
+- ⚠️ Now `breakPoint` is deprecated
+- 🌍 Add width adjustment [#1](https://github.com/Cierra-Runis/based_flutter/issues/1)
 
 ## 1.1.0
 
-⚠️Now `leftWidget` required a `key` for keep its state
-⚠️Now `navigatorKey` is `required`
+- ⚠️ Now `leftWidget` required a `key` for keep its state
+- ⚠️ Now `navigatorKey` is `required`
 
 ## 1.0.7
 
-📖Rename `BasedSplitViewPlaceholder` to `_BasedSplitViewPlaceholder`
-📖Remove `leftWidgetKey`
-📖Now divider only show when `dividerWidth > 0`
-🔧Fix `ScaffoldMessenger`
+- 📖 Rename `BasedSplitViewPlaceholder` to `_BasedSplitViewPlaceholder`
+- 📖 Remove `leftWidgetKey`
+- 📖 Now divider only show when `dividerWidth > 0`
+- 🔧 Fix `ScaffoldMessenger`
 
 ## 1.0.6
 
-📖Use `CupertinoPage` now
+- 📖 Use `CupertinoPage` now
 
 ## 1.0.5
 
-🔧Use `NavigatorPopHandler` instead `WillPopScope`
+- 🔧 Use `NavigatorPopHandler` instead `WillPopScope`
 
 ## 1.0.4
 
-😵‍💫Weird behavior
+### 😵‍💫 Weird behavior
 
 When there's page in ipad's right view, by clicking the back button at demo's right view, it pops ipad's right view, but not demo's right view, only when ipad's right view has not more page it pops demo's right view.
 
 ## 1.0.3
 
-🔧Fix can't pop BasedSplitView when it has pages
+- 🔧 Fix can't pop BasedSplitView when it has pages
 
 ## 1.0.2
 
-🔧Add \_leftWidgetKey to save state
-
-Refer to <https://github.com/Cierra-Runis/chat_life/commit/983d8fd89dd78f1b14ec617d62c73cf3bfae0acb>
+- 🔧 Add \_leftWidgetKey to save state
+  Refer to <https://github.com/Cierra-Runis/chat_life/commit/983d8fd89dd78f1b14ec617d62c73cf3bfae0acb>
 
 ## 1.0.1
 
-📖Update repo link
+- 📖 Update repo link
 
 ## 1.0.0
 
-🌞First Publish🌞
+- 🌞 First Publish 🌞

packages/based_split_view/lib/src/based_split_view.dart

@@ -99,7 +99,8 @@ class _BasedSplitViewState extends State<BasedSplitView> {
   @override
   Widget build(BuildContext context) {
     return NavigatorPopHandler(
-      onPopWithResult: widget.navigatorKey.currentState?.maybePop,
+      onPopWithResult: (result) async =>
+          await widget.navigatorKey.currentState?.maybePop(result),
       child: LayoutBuilder(
         builder: (context, constraints) {
           final singleView = constraints.maxWidth <= widget.breakPoint;

packages/based_split_view/pubspec.yaml

@@ -1,6 +1,6 @@
 name: based_split_view
 description: A Based Split View Widget, Which Helps You Create A Split View In Large Screen Device like Telegram, QQ or Discord
-version: 1.2.1
+version: 1.2.3
 homepage: https://github.com/Cierra-Runis/based_flutter/tree/master/packages/based_split_view
 
 environment: