V3#59
Open
tomhooijenga wants to merge 25 commits into
Open
Conversation
added 24 commits
September 21, 2020 10:20
- Combine country data - Split regexes & test data - Add universal & extendable lookup - Add lookup generator script - Return boolean instead of strings - Web and node are now equal
Contributor
Author
|
The checks are failing on node 6 and 8. Do we require support for them or can I just remove them from travis? |
Contributor
I think it's fine to drop node 6 & 8 support with the v3. The PR looks good to me. I pinged the other maintainers of the repository for a second review as this is a big change. |
Contributor
Author
|
@ozankaya Do you happen to know if there's any progress on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for #5. It also fixes #7 .