Skip to content

Commit 259cff8

Browse files
committed
Harden Codex parity and installer safety
1 parent 1c5f2ac commit 259cff8

126 files changed

Lines changed: 1662 additions & 316 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.agents/skills/architecture-decision/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ to implement it.]
334334
5.5. **Engine Specialist Validation** — Before saving, spawn the **primary engine specialist** via Codex subagent delegation to validate the drafted ADR:
335335
- Read `.codex/docs/technical-preferences.md` `Engine Specialists` section to get the primary specialist
336336
- If no engine is configured (`[TO BE CONFIGURED]`), skip this step
337-
- Spawn `subagent_type: [primary specialist]` with: the ADR's Engine Compatibility section, Decision section, Key Interfaces, and the engine reference docs path. Ask them to:
337+
- Spawn `[primary specialist]` via Codex subagent delegation with: the ADR's Engine Compatibility section, Decision section, Key Interfaces, and the engine reference docs path. Ask them to:
338338
1. Confirm the proposed approach is idiomatic for the pinned engine version
339339
2. Flag any APIs or patterns that are deprecated or changed post-training-cutoff
340340
3. Identify engine-specific risks or gotchas not captured in the current ADR draft

.agents/skills/architecture-review/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ Post-Cutoff API Conflicts:
321321
After completing the engine audit above, spawn the **primary engine specialist** via Codex subagent delegation for a domain-expert second opinion:
322322
- Read `.codex/docs/technical-preferences.md` `Engine Specialists` section to get the primary specialist
323323
- If no engine is configured, skip this consultation
324-
- Spawn `subagent_type: [primary specialist]` with: all ADRs that contain engine-specific decisions or `Post-Cutoff APIs Used` fields, the engine reference docs, and the Phase 5 audit findings. Ask them to:
324+
- Spawn `[primary specialist]` via Codex subagent delegation with: all ADRs that contain engine-specific decisions or `Post-Cutoff APIs Used` fields, the engine reference docs, and the Phase 5 audit findings. Ask them to:
325325
1. Confirm or challenge each audit finding — specialists may know of engine nuances not captured in the reference docs
326326
2. Identify engine-specific anti-patterns in the ADRs that the audit may have missed (e.g., using the wrong Godot node type, Unity component coupling, Unreal subsystem misuse)
327327
3. Flag ADRs that make assumptions about engine behaviour that differ from the actual pinned version

.agents/skills/handoff/SKILL.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,3 +252,7 @@ Report in 15 lines or fewer:
252252
- Open blockers or deferred items.
253253

254254
After reporting, stop. Do not start new feature work in the same turn.
255+
256+
## Ported metadata
257+
258+
This is a Codex-native support skill. It has no upstream Claude skill equivalent.

.agents/skills/help/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ Collect these for the output in Step 7 — show them as a footer block:
4343

4444
```
4545
### Also installed (not in workflow)
46-
- `/skill-name` — [description from SKILL.md frontmatter]
47-
- `/skill-name` — [description]
46+
- `$skill-name` — [description from SKILL.md frontmatter]
47+
- `$skill-name` — [description]
4848
```
4949

5050
Only show this block if at least one uncataloged skill exists. Limit to the 10

.agents/skills/hotfix/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ Update the hotfix record with root cause, fix details, and test results.
9595

9696
Use the Codex subagent delegation to request sign-off in parallel:
9797

98-
- `subagent_type: lead-programmer` — Review the fix for correctness and side effects
99-
- `subagent_type: qa-tester` — Run targeted regression tests on the affected system
100-
- `subagent_type: producer` — Approve deployment timing and communication plan
98+
- Delegate to `lead-programmer` — Review the fix for correctness and side effects
99+
- Delegate to `qa-tester` — Run targeted regression tests on the affected system
100+
- Delegate to `producer` — Approve deployment timing and communication plan
101101

102102
All three must return APPROVE before proceeding. If any returns CONCERNS or REJECT, do not deploy — surface the issue and resolve it first.
103103

.agents/skills/resume-from-handoff/SKILL.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,3 +302,7 @@ closeouts should read or refresh the saved `## Session Worklist` in `active.md`.
302302
- Does not perform a full artifact gap audit; that is `$project-stage-detect`.
303303
- Does not replace reading the handoff; it operationalizes the canonical handoff
304304
into an oriented, prioritized session worklist.
305+
306+
## Ported metadata
307+
308+
This is a Codex-native support skill. It has no upstream Claude skill equivalent.

.agents/skills/skill-improve/SKILL.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,17 @@ Read the full skill file at `.agents/skills/[name]/SKILL.md`.
6868

6969
For each failing or warning **static** check, identify the exact gap:
7070

71-
- **Check 1 fail** → which frontmatter field is missing
71+
- **Check 1 fail** → which Codex frontmatter field or required Ported-metadata
72+
field/classification is missing, or which unsupported field is in frontmatter
7273
- **Check 2 fail** → how many phases found vs. minimum required
7374
- **Check 3 fail** → no verdict keywords anywhere in the skill body
74-
- **Check 4 fail** → Write or Edit in allowed-tools but no ask-before-write language
75+
- **Check 4 fail** → effective Write or Edit behavior from Ported metadata or a
76+
Codex-native workflow has no ask-before-write language or declared exception
7577
- **Check 5 warn** → no follow-up or next-step section at the end
76-
- **Check 6 warn**`context: fork` set but fewer than 5 phases found
77-
- **Check 7 warn** → argument-hint is empty or doesn't match documented modes
78+
- **Check 6 warn** → declared Codex delegation lacks central authorization,
79+
review-mode routing, missing-delegation reporting, or no-simulation fallback
80+
- **Check 7 warn** → Ported-metadata argument-hint is empty or doesn't match
81+
documented modes; Codex-native argument-free support skills are not warned
7882

7983
For each failing or warning **category** check (if category was assigned in Phase 2b),
8084
identify the exact gap in the skill's text. For example:

.agents/skills/skill-test/SKILL.md

Lines changed: 32 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,24 @@ If argument is missing or unrecognized, output usage and stop.
3939

4040
For each skill being tested, read its `SKILL.md` fully and run all 7 checks:
4141

42-
### Check 1 — Required Frontmatter Fields
43-
The file must contain all of these in the YAML frontmatter block:
42+
### Check 1 — Codex Metadata Contract
43+
The YAML frontmatter block must contain only the Codex runtime fields required
44+
for discovery:
4445
- `name:`
4546
- `description:`
47+
48+
For a ported upstream skill, the `## Ported metadata` section must preserve:
4649
- `argument-hint:`
4750
- `user-invocable:`
4851
- `allowed-tools:`
4952

50-
**FAIL** if any are absent.
53+
Codex-native support skills with no upstream equivalent instead must state that
54+
classification explicitly in `## Ported metadata`; they do not invent legacy
55+
fields merely to satisfy this check.
56+
57+
**FAIL** if `name` or `description` is absent, if unsupported Claude fields are
58+
placed in YAML frontmatter, or if a ported skill omits its required Ported
59+
metadata fields.
5160

5261
### Check 2 — Multiple Phases
5362
The skill must have ≥2 numbered phase headings. Look for patterns like:
@@ -74,7 +83,12 @@ when they are explicitly described as derived checkpoints and say: Do not ask a
7483
separate "May I write?" for this file.
7584

7685
**WARN** if absent (some read-only skills legitimately skip this).
77-
**FAIL** if `allowed-tools` includes `Write` or `Edit` but no ask-before-write language is found.
86+
For ported skills, read `allowed-tools` from the Ported metadata section, not
87+
from YAML frontmatter. For Codex-native support skills, infer write behavior
88+
from the workflow's declared actions and explicit invocation exceptions.
89+
90+
**FAIL** if the effective tool/actions contract includes Write or Edit but no
91+
ask-before-write or valid declared exception language is found.
7892

7993
### Check 5 — Next-Step Handoff
8094
The skill must end with a recommended next action or follow-up path. Look for:
@@ -113,17 +127,21 @@ Skills that create, update, append, overwrite, or write
113127
checkpoint and must say: Do not ask a separate "May I write?" for this file.
114128
Durable artifact writes still require normal explicit approval.
115129

116-
### Check 6 — Fork Context Complexity
117-
If frontmatter contains `context: fork`, the skill should have ≥5 phase headings
118-
(`##` level or numbered Phase N headers). Fork context is for complex multi-phase
119-
skills; simple skills should not use it.
130+
### Check 6 — Codex Delegation Structure
131+
If the skill declares role-agent or director delegation, verify that it uses the
132+
central `AGENTS.md` delegation authorization, applies review-mode filtering when
133+
director gates are involved, reports unavailable/skipped/blocked delegation,
134+
and never simulates a specialist or director verdict.
120135

121-
**WARN** if `context: fork` is set but fewer than 5 phases found.
136+
**WARN** if declared delegation lacks one of those Codex-native routing or
137+
fallback requirements. Non-delegating skills pass this check as not applicable.
122138

123139
### Check 7 — Argument Hint Plausibility
124-
`argument-hint` must be non-empty. If the skill body mentions multiple modes
125-
(e.g., "Mode A | Mode B"), the hint should reflect them. Cross-reference the
126-
hint against the first phase's "Parse Arguments" section.
140+
For ported skills, the Ported-metadata `argument-hint` must be non-empty. If the
141+
skill body mentions multiple modes (e.g., "Mode A | Mode B"), the hint should
142+
reflect them. Cross-reference the hint against the first phase's "Parse
143+
Arguments" section. Codex-native support skills without an upstream hint pass
144+
when their usage is unambiguous or explicitly argument-free.
127145

128146
**WARN** if hint is `""` or if documented modes don't match hint.
129147

@@ -135,12 +153,12 @@ For a single skill:
135153
```
136154
=== Skill Static Check: /[name] ===
137155
138-
Check 1 — Frontmatter Fields: PASS
156+
Check 1 — Codex Metadata Contract: PASS
139157
Check 2 — Multiple Phases: PASS (7 phases found)
140158
Check 3 — Verdict Keywords: PASS (PASS, FAIL, CONCERNS)
141159
Check 4 — Collaborative Protocol: PASS ("May I write" found)
142160
Check 5 — Next-Step Handoff: WARN (no follow-up section found)
143-
Check 6 — Fork Context Complexity: PASS (8 phases, context: fork set)
161+
Check 6 — Codex Delegation Structure: PASS (central routing and fallback present)
144162
Check 7 — Argument Hint: PASS
145163
146164
Verdict: WARNINGS (1 warning, 0 failures)

.agents/skills/studio-status/SKILL.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,7 @@ context, current-directory, and git footer items remain configured separately
2828
through `[tui].status_line` when project config is installed. A real footer
2929
`Stage:` item is blocked until Codex documents support for project custom footer
3030
items; do not add an unverified fake status-line entry.
31+
32+
## Ported metadata
33+
34+
This is a Codex-native support skill. It has no upstream Claude skill equivalent.

.agents/skills/team-audio/SKILL.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ Store the resolved mode for use in all subsequent phases.
3838
## How to Delegate
3939

4040
Use the Codex subagent delegation to spawn each team member as a subagent:
41-
- `subagent_type: audio-director` — Sonic identity, emotional tone, audio palette
42-
- `subagent_type: sound-designer` — SFX specifications, audio events, mixing groups
43-
- `subagent_type: technical-artist` — Audio middleware, bus structure, memory budgets
44-
- `subagent_type: [primary engine specialist]` — Validate audio integration patterns for the engine
45-
- `subagent_type: gameplay-programmer` — Audio manager, gameplay triggers, adaptive music
41+
- Delegate to `audio-director` — Sonic identity, emotional tone, audio palette
42+
- Delegate to `sound-designer` — SFX specifications, audio events, mixing groups
43+
- Delegate to `technical-artist` — Audio middleware, bus structure, memory budgets
44+
- Delegate to `[primary engine specialist]` — Validate audio integration patterns for the engine
45+
- Delegate to `gameplay-programmer` — Audio manager, gameplay triggers, adaptive music
4646

4747
Always provide full context in each agent's prompt (feature description, existing audio assets, design doc references).
4848

0 commit comments

Comments
 (0)