vn anchor logic (#424)

* vn anchor logic

* put back comments, add changelog

* shorten changelog

* update Changelog

---------

Co-authored-by: Rafal Slominski <rsominsk@cisco.com>
Co-authored-by: kuba-mazurkiewicz <kmazurki@cisco.com>

Author: 3 people

CHANGELOG.md

@@ -6,7 +6,7 @@
 
 - Fix `catalystcenter_pnp_device_claim_site` resource to correctly handle day-zero template attachment when the template does not require variables
 - Extend detection to match specific failure reason messages in addition to the `NCDP10000` error code. This prevents false error reporting when multiple devices are temporarily unreachable. Fixes [link](https://github.com/CiscoDevNet/terraform-provider-catalystcenter/issues/414)
-- Fix `catalystcenter_fabric_l3_virtual_network` resource to allow in-place updates to the `anchored_site_id` attribute
+- Fix `catalystcenter_fabric_l3_virtual_network` resource to fully support anchored Layer 3 Virtual Networks, mirroring undocumented Catalyst Center anchor handling in Create, Update, and Delete API operations
 
 ## 0.5.12
 

docs/data-sources/fabric_l3_virtual_network.md

@@ -27,7 +27,7 @@ data "catalystcenter_fabric_l3_virtual_network" "example" {
 
 ### Read-Only
 
-- `anchored_site_id` (String) Fabric ID of the fabric site this layer 3 virtual network is to be anchored at.
+- `anchored_site_id` (String) Fabric ID of the fabric site this layer 3 virtual network is to be anchored at. Must be one of the `fabric_ids` entries. Changing this value (including setting or clearing it) forces resource replacement, because Catalyst Center does not allow adding, changing, or removing the anchor of an existing Layer 3 Virtual Network.
 - `fabric_ids` (Set of String) IDs of the fabrics this layer 3 virtual network is to be assigned to.
 - `id` (String) The id of the object
 - `merge_fabric_sites` (Boolean) When set to `true`, the `fabric_ids` declared in this resource are merged with the existing fabric associations on Catalyst Center (additive on create/update, subtractive on delete), rather than replacing the entire set. Use this in environments where multiple resources or external processes manage fabric associations for the same L3 Virtual Network.

docs/guides/changelog.md

@@ -15,7 +15,7 @@ description: |-
 
 - Fix `catalystcenter_pnp_device_claim_site` resource to correctly handle day-zero template attachment when the template does not require variables
 - Extend detection to match specific failure reason messages in addition to the `NCDP10000` error code. This prevents false error reporting when multiple devices are temporarily unreachable. Fixes [link](https://github.com/CiscoDevNet/terraform-provider-catalystcenter/issues/414)
-- Fix `catalystcenter_fabric_l3_virtual_network` resource to allow in-place updates to the `anchored_site_id` attribute
+- Fix `catalystcenter_fabric_l3_virtual_network` resource to fully support anchored Layer 3 Virtual Networks, mirroring undocumented Catalyst Center anchor handling in Create, Update, and Delete API operations
 
 ## 0.5.12
 

docs/resources/fabric_l3_virtual_network.md

@@ -28,7 +28,7 @@ resource "catalystcenter_fabric_l3_virtual_network" "example" {
 
 ### Optional
 
-- `anchored_site_id` (String) Fabric ID of the fabric site this layer 3 virtual network is to be anchored at.
+- `anchored_site_id` (String) Fabric ID of the fabric site this layer 3 virtual network is to be anchored at. Must be one of the `fabric_ids` entries. Changing this value (including setting or clearing it) forces resource replacement, because Catalyst Center does not allow adding, changing, or removing the anchor of an existing Layer 3 Virtual Network.
 - `fabric_ids` (Set of String) IDs of the fabrics this layer 3 virtual network is to be assigned to.
 - `merge_fabric_sites` (Boolean) When set to `true`, the `fabric_ids` declared in this resource are merged with the existing fabric associations on Catalyst Center (additive on create/update, subtractive on delete), rather than replacing the entire set. Use this in environments where multiple resources or external processes manage fabric associations for the same L3 Virtual Network.
 

gen/definitions/fabric_l3_virtual_network.yaml

@@ -1,4 +1,20 @@
 ---
+# NOTE: The Create, Update and Delete functions in the generated resource file
+# (internal/provider/resource_catalystcenter_fabric_l3_virtual_network.go) contain
+# hand-written logic that mirrors several undocumented Catalyst Center constraints
+# around Layer 3 Virtual Networks, in particular anchored VNs and the
+# `merge_fabric_sites` (additive) mode. Specifically:
+#   * Anchored Create is a two-phase POST+PUT (CatC rejects POST with multiple
+#     fabricIds when anchoredSiteId is set).
+#   * Anchored Update splits a combined add+remove of fabricIds into two
+#     sequential PUTs (CatC errorCode NCHS20477).
+#   * Anchored Delete pre-shrinks fabricIds to the anchor only before DELETE
+#     (CatC errorCode NCHS20691).
+#   * `anchored_site_id` is marked requires_replace because CatC does not allow
+#     adding, changing, or removing the anchor of an existing L3 VN.
+#   * `INFRA_VN` / `DEFAULT_VN` cannot be anchored and are managed via PUT only.
+# If you re-run `go generate`, remove the //template:begin/end markers around
+# these hand-edited functions so they are preserved.
 name: Fabric L3 Virtual Network
 rest_endpoint: /dna/intent/api/v1/sda/layer3VirtualNetworks
 id_from_query_path: response.0
@@ -31,8 +47,9 @@ attributes:
     test_value: "[catalystcenter_fabric_site.test.id]"
   - model_name: anchoredSiteId
     data_path: "0"
+    requires_replace: true
     response_data_path: response.0.anchoredSiteId
-    description: Fabric ID of the fabric site this layer 3 virtual network is to be anchored at.
+    description: "Fabric ID of the fabric site this layer 3 virtual network is to be anchored at. Must be one of the `fabric_ids` entries. Changing this value (including setting or clearing it) forces resource replacement, because Catalyst Center does not allow adding, changing, or removing the anchor of an existing Layer 3 Virtual Network."
     type: String
     example: ""
     exclude_test: true

internal/provider/data_source_catalystcenter_fabric_l3_virtual_network.go

@@ -72,7 +72,7 @@ func (d *FabricL3VirtualNetworkDataSource) Schema(ctx context.Context, req datas
 				Computed:            true,
 			},
 			"anchored_site_id": schema.StringAttribute{
-				MarkdownDescription: "Fabric ID of the fabric site this layer 3 virtual network is to be anchored at.",
+				MarkdownDescription: "Fabric ID of the fabric site this layer 3 virtual network is to be anchored at. Must be one of the `fabric_ids` entries. Changing this value (including setting or clearing it) forces resource replacement, because Catalyst Center does not allow adding, changing, or removing the anchor of an existing Layer 3 Virtual Network.",
 				Computed:            true,
 			},
 			"merge_fabric_sites": schema.BoolAttribute{