[ISSUE] Server Profile Template not syncing when updated

[louis-gounot]

Bug Report Checklist

• Have you provided a full/minimal configuration to reproduce the issue?
• Have you [tested with the latest master] to confirm the issue still exists?
• Have you provided the terraform console logs with environment variable set to TF_LOG=trace?

Description

When updating server profile template (intersight_server_profile_template), no template synchronization is done to update linked profiles.
Resource argument template_actions is causing an API error if used.
Resource argument action seems useless (tryied No-op, Sync, Deploy).

Terraform-provider-intersight version

1.0.66, signed, from registry.terraform.io
PVA 1.1.2-1

Configuration file

Step 1 :

resource "intersight_thermal_policy" "ok" {
  name = "issue_thermal"
}

resource "intersight_server_profile_template" "ok" {
  name = "issue_template"

  policy_bucket {
    moid        = intersight_thermal_policy.ok.moid
    object_type = intersight_thermal_policy.ok.object_type
  }
}

resource "intersight_server_profile" "ok" {
  name = "issue_profile"

  src_template {
    moid        = intersight_server_profile_template.ok.moid
    object_type = intersight_server_profile_template.ok.object_type
  }
}

Apply and wait for convergence (wait_for_completion does not work), activate profile on a compute.

Step 2 (remove thermal policy from template) :

resource "intersight_thermal_policy" "ok" {
  name = "issue_thermal"
}

resource "intersight_server_profile_template" "ok" {
  name = "issue_template"
}

resource "intersight_server_profile" "ok" {
  name = "issue_profile"

  src_template {
    moid        = intersight_server_profile_template.ok.moid
    object_type = intersight_server_profile_template.ok.object_type
  }
}

Apply is OK but profile is not updated within Intersight (no template synchronisation).
If I manually edit template within Intersight UI, then it synchronize the profile.

Actual output (Attach screenshots if applicable)

Not relevant, more a functional issue Terraform Provider / Intersight

Related issues/PRs

Suggest a fix

Implement template_actions or offer a way to sync template to linked profiles.
Update provider documentation accordingly.

[jingiris05]

Hi @louis-gounot
Thanks for raising the issue

Workaround / Fix:
To properly detach the thermal policy and synchronize the server profile template with its linked profiles, you can use the below code,

Step 1 : Create and attach thermal policy

resource "intersight_thermal_policy" "thermal_policy_1" {
  name              = "thermal_policy_1"
  fan_control_mode  = "Balanced"
  organization {
    object_type = "organization.Organization"
    moid        = data.intersight_organization_organization.default.moid
  }
}

resource "intersight_server_profile_template" "server_test_template" {
  name = "server_test"
  description = "This is a test server profile"
  target_platform = "Standalone"
  policy_bucket {
    moid        = intersight_thermal_policy.thermal_policy_1.moid
    object_type = intersight_thermal_policy.thermal_policy_1.object_type
  }
  organization {
    object_type = "organization.Organization"
    moid        = data.intersight_organization_organization.default.moid
  }
}

resource "intersight_server_profile" "server_test_13" {
  name = "server_test_13"
  description = "This is a test server profile"
  src_template {
    moid = intersight_server_profile_template.server_test_template.moid
    object_type = "server.ProfileTemplate"
  }
  organization {
    object_type = "organization.Organization"
    moid        = data.intersight_organization_organization.default.moid
  }
}

Step 2 : Remove the thermal policy and re-apply

resource "intersight_server_profile_template" "server_test_template" {
  name = "server_test"
  description = "This is a test server profile"
  target_platform = "Standalone"
  organization {
    object_type = "organization.Organization"
    moid        = data.intersight_organization_organization.default.moid
  }
}

resource "intersight_server_profile" "server_test_13" {
  name = "server_test_13"
  description = "This is a test server profile"
  src_template {
    moid = intersight_server_profile_template.server_test_template.moid
    object_type = "server.ProfileTemplate"
  }
  organization {
    object_type = "organization.Organization"
    moid        = data.intersight_organization_organization.default.moid
  }
}

Applying in this sequence ensures the server profile template updates correctly, and linked profiles get synchronized.

[louis-gounot]

Will check once again but was not syncing the profile. You suggest to do what I did but deleted the thermal policy (thus forcing profiles to update by itself because policy disappeared and not because of profile sync).
I believe this is because we need to create a bulk_mo_cloner in order for template to be auto synchronized every time it is changed (or a bulk_mo_merger if we want to sync only once).
Main point here : it is not "terraform" friendly at all (bulk_mo_cloner gets recreated each time and is not idempotent at all, something similar to #291 in behaviour).
In a "terraform" way of working, provider should handle configuration migration actions.
In addition, actions within WebUI can create things we can't manage without dissociating profile from template (cause UI is creating an auto mo_cloner behind the scenes). So even if would chose one time masterized mo_merger strategy, anyone going within Web UI and editing the profile (without even saving it, just editing it is enough) would create an auto mo_merger.