Skip to content

Commit 3e49e27

Browse files
committed
remove unnecessary init cycle
1 parent 3066cc5 commit 3e49e27

2 files changed

Lines changed: 3 additions & 10 deletions

File tree

src/core/managers/matchingEngineManager.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ const matchingEngineManager = {
4343
return engine;
4444
},
4545

46-
async fetchMetadata(language = "en") {
47-
const engine = await this.initMatchingEngine(language);
48-
return engine.metadata || {};
49-
},
50-
5146
// fetchValidationReport and fetchQuizReport could probably be unified further to only expose fetchMatchingReport() TODO
5247
async fetchMatchingReport(userId, rps, lang = "en") {
5348
if (!this.matchingEngineInstance) {

src/ui/shared-hooks/useInitialiseApplication.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,10 @@ export const useInitialiseApplication = () => {
4949

5050
// Call init(language) once after construction
5151
lastInitializedLang.current = language; // prevent duplicate init
52-
await matchingEngineManager.initMatchingEngine(language);
52+
const engine = await matchingEngineManager.initMatchingEngine(language);
5353

5454
// Fetch metadata and report
55-
const metadata = await matchingEngineManager.fetchMetadata(language);
56-
console.log("Fetched metadata:", metadata);
57-
metadataStore.updateMetadata(metadata || "empty");
55+
metadataStore.updateMetadata(engine.metadata || "empty");
5856

5957
// It this necessary initially or only later? TODO
6058
const report = await matchingEngineManager.fetchValidationReport(fixedUserId, language);
@@ -92,7 +90,7 @@ export const useInitialiseApplication = () => {
9290
console.log(`🔁 Setting Matching Engine for language: ${language}`);
9391
await matchingEngineManager.matchingEngineInstance.init(language);
9492

95-
const metadata = await matchingEngineManager.fetchMetadata(language);
93+
const metadata = matchingEngineManager.matchingEngineInstance.engine.metadata;
9694
metadataStore.updateMetadata(metadata || "empty");
9795

9896
const report = await matchingEngineManager.fetchValidationReport(fixedUserId, language);

0 commit comments

Comments
 (0)