Skip to content

Feat: add html content block#14119

Merged
Stef-Rousset merged 32 commits into
masterfrom
feat/add_html_content_block
Jul 13, 2026
Merged

Feat: add html content block#14119
Stef-Rousset merged 32 commits into
masterfrom
feat/add_html_content_block

Conversation

@Stef-Rousset

Copy link
Copy Markdown
Contributor

Changelog

Added

  • html block in content builder for homepage, project description and folder description.
  • feature flag html_block_in_content_builder

For translators

@cl-dev-bot

cl-dev-bot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ The PR title contains no Jira issue key (case-sensitive)
⚠️ The branch name contains no Jira issue key (case-sensitive)
Messages
📖 Changelog provided 🎉
📖

Run the e2e tests

📖

Check translation progress

Generated by 🚫 dangerJS against 271c8ae

@Stef-Rousset Stef-Rousset force-pushed the feat/add_html_content_block branch from f183bb7 to ab91a63 Compare June 24, 2026 09:28
@Stef-Rousset Stef-Rousset marked this pull request as ready for review June 24, 2026 15:01
@Stef-Rousset Stef-Rousset removed the request for review from luucvanderzee June 25, 2026 07:16
@Stef-Rousset Stef-Rousset marked this pull request as draft June 25, 2026 07:43
@Stef-Rousset Stef-Rousset requested a review from EdwinKato June 25, 2026 08:20
@Stef-Rousset Stef-Rousset marked this pull request as ready for review June 25, 2026 08:20

@EdwinKato EdwinKato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good overall. I left some minor comments but nothing blocking. I noticed we have some import order issues, you can run

cd front
npm run eslint --ext .ts,.tsx --fix \
  app/components/admin/ContentBuilder/Widgets/HtmlBlockMultiloc/index.tsx \
  'app/containers/Admin/pagesAndMenu/containers/ContentBuilder/components/Widgets/HtmlBlockMultiloc/index.tsx'

For those files to fix any issues or npm run lint --fix for the entire codebase

Comment thread front/app/components/admin/ContentBuilder/Widgets/HtmlBlockMultiloc/index.tsx Outdated
@Stef-Rousset

Copy link
Copy Markdown
Contributor Author

The code looks good overall. I left some minor comments but nothing blocking. I noticed we have some import order issues, you can run

cd front
npm run eslint --ext .ts,.tsx --fix \
  app/components/admin/ContentBuilder/Widgets/HtmlBlockMultiloc/index.tsx \
  'app/containers/Admin/pagesAndMenu/containers/ContentBuilder/components/Widgets/HtmlBlockMultiloc/index.tsx'

For those files to fix any issues or npm run lint --fix for the entire codebase

Thx for the advice, I ran the command and update the files !

@Stef-Rousset Stef-Rousset requested a review from EdwinKato June 30, 2026 15:58

@EdwinKato EdwinKato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Stef-Rousset Stef-Rousset requested a review from jinjagit July 3, 2026 09:38

@jinjagit jinjagit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BE code looks generally good.

I recommended some improvements in documentation (via comments &/or more tests), and I asked a couple of questions (for clarification of your intent).
I also suggested a small change in the rel sanitisation.

@Stef-Rousset Stef-Rousset requested a review from jinjagit July 9, 2026 15:31

@jinjagit jinjagit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Stef-Rousset Stef-Rousset merged commit edf19ee into master Jul 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants