Skip to content

[TAN-7922] Add sms manual campaigns#14129

Merged
AchrafGoVocal merged 32 commits into
TAN-8120-sms-campaignsfrom
TAN-7922-add-sms-manual-campaigns
Jul 6, 2026
Merged

[TAN-7922] Add sms manual campaigns#14129
AchrafGoVocal merged 32 commits into
TAN-8120-sms-campaignsfrom
TAN-7922-add-sms-manual-campaigns

Conversation

@AchrafGoVocal

@AchrafGoVocal AchrafGoVocal commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Changelog

For translators

@notion-workspace

notion-workspace Bot commented Jun 22, 2026

Copy link
Copy Markdown

Add SMS manual campaigns

@cl-dev-bot

cl-dev-bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Warnings
⚠️

The changelog is empty. What should I put in the changelog?
Messages
📖 Notion issue: TAN-7922
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against a26644b

@AchrafGoVocal AchrafGoVocal changed the base branch from master to TAN-7844-basic-sms-setup June 22, 2026 07:33
jamesspeake
jamesspeake reviewed Jun 23, 2026
View reviewed changes
Comment thread back/engines/free/email_campaigns/app/services/email_campaigns/delivery_service.rb

@jamesspeake jamesspeake Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do wonder actually if this would be better as two services off a base - EmailDeliveryService and SmsSeliveryService

AchrafGoVocal
AchrafGoVocal commented Jun 24, 2026
View reviewed changes
Comment thread back/app/services/sms/sender.rb Outdated
@AchrafGoVocal
Merge branch 'TAN-7844-basic-sms-setup' of github.com:CitizenLabDotCo…
c611f52 
…/citizenlab into TAN-7922-add-sms-manual-campaigns
@AchrafGoVocal
[TAN-7922] Move the Sms DeliverySerializer
825d2d6
@AchrafGoVocal
[TAN-7922] Add email preview handling to send_preview and refactor co…
444b593 
…mmand processing
@AchrafGoVocal
[TAN-7922] Extract NewSmsCampaignButton into its own file
95a83bb
@AchrafGoVocal
[TAN-7922] Store SMS campaign admin label in subject_multiloc instead…
bfa3e7a 
… of title_multiloc
@AchrafGoVocal
[TAN-7922] Merge duplicate SMS i18n key into tabSms
6e4bd36
@AchrafGoVocal
[TAN-7922] Split SMS campaign Show page into smaller components
4bb1151
@AchrafGoVocal
[TAN-7922] Remove error handling from send_preview method in Campaign…
88a19e7 
…sController
@AchrafGoVocal
[TAN-7922] Split deliveries and stats actions into per-channel methods
cf60ed1
@AchrafGoVocal
[TAN-7922] Fold title_multiloc back into content-configurable seriali…
6224386 
…zer group
@AchrafGoVocal
[TAN-7922] Clean up useless comments
f6ea973
@AchrafGoVocal
[TAN-7922] Persist campaign channel as a DB column
8f7b3a3
@AchrafGoVocal
[TAN-7922] Remove useless method
036514c
jamesspeake
jamesspeake reviewed Jul 1, 2026
View reviewed changes
Comment thread back/engines/free/email_campaigns/app/services/email_campaigns/delivery_service.rb Outdated
jamesspeake
jamesspeake reviewed Jul 1, 2026
View reviewed changes
Comment thread back/engines/free/email_campaigns/app/services/email_campaigns/delivery_service.rb Outdated
jamesspeake
jamesspeake reviewed Jul 1, 2026
View reviewed changes
Comment thread front/app/containers/Admin/messaging/CustomEmails/All/index.tsx Outdated
@AchrafGoVocal
Merge branch 'TAN-7844-basic-sms-setup' of github.com:CitizenLabDotCo…
14546e0 
…/citizenlab into TAN-7922-add-sms-manual-campaigns
@AchrafGoVocal
[TAN-7922] Recover SMS recipient number from delivery user at send time
66093b1
@AchrafGoVocal
[TAN-7922] Move SMS phone validation to send entry points
5ba1515
@AchrafGoVocal
[TAN-7922] Add Campaign#sms? predicate to replace channel == 'sms' ch…
1e7e727 
…ecks
@AchrafGoVocal
[TAN-7922] Separate email and SMS campaign hooks/types
b963e06
@AchrafGoVocal
[TAN-7922] Split campaign stats/deliveries into per-channel endpoints
8214cb8
@AchrafGoVocal
[TAN-7922] Filter campaigns by channel instead of excluding campaign …
b9f29aa 
…names
@AchrafGoVocal
[TAN-7922] Split shared preview endpoints into per-channel actions
f27b66a
@AchrafGoVocal
[TAN-7922] Simplify channel serialization to plain attribute
bb6b2ed
@AchrafGoVocal
[TAN-7922] Show delivery stats and recipients on sent SMS campaigns
99a999f
@AchrafGoVocal AchrafGoVocal changed the base branch from TAN-7844-basic-sms-setup to TAN-8120-sms-campaigns July 6, 2026 11:32
@AchrafGoVocal AchrafGoVocal marked this pull request as ready for review July 6, 2026 12:23
@AchrafGoVocal AchrafGoVocal merged commit 874afbb into TAN-8120-sms-campaigns Jul 6, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesspeake jamesspeake jamesspeake left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AchrafGoVocal @cl-dev-bot @jamesspeake