Fix accessibility issues on About Us speaker links and YouTube embed (#91, #92)#120
Merged
alexwolson merged 1 commit intoMay 17, 2026
Merged
Conversation
- Remove invalid `alt` attribute from `<a>` elements in the Past Speakers list on the About Us page. The `alt` attribute is not valid on `<a>` elements (it only applies to `<img>`, `<area>`, and `<input type="image">`). The link's accessible name is already provided by the heading text it contains. Fixes CivicTechTO#92. - Make `embed_youtube.html` accept a `title` parameter and use it as the iframe `title`, falling back to "Embedded YouTube video" if none is provided. The meetup layout now passes the meetup topic, so screen-reader users hear a descriptive frame title instead of the generic "YouTube video". Aligns with WCAG 2.4.1 (Bypass Blocks) and 4.1.2 (Name, Role, Value). Fixes CivicTechTO#91.
alexwolson
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91 and #92 — Accessibility improvements
#92 — Remove invalid
altattribute on<a>elements in About Usalt="{{speark.title}}"from the anchor element in_pages/about-us.mdaltis not a valid attribute on<a>elements<h4>heading content#91 — Add descriptive title to YouTube iframes
_includes/embed_youtube.htmlto accept atitleparameter with a fallback_layouts/meetup.htmlto pass the meetup topic as the iframe titleBoth issues are part of the WCAG 2.2 Level AA compliance milestone (#85).