Cache image derivatives across builds (#140)#143
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The pre-existing sentence said thumbnails cache in assets/thumbs/ and are gitignored; neither is accurate. JPT writes to _site/assets/thumbs and the path is not in .gitignore. Aligns with the adjacent caching note. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
alexwolson
marked this pull request as draft
June 28, 2026 16:51
Contributor
Pa11y Accessibility Report✅ All pages passed — 0 warning(s) (WCAG2AA) Homepage✅ No issues found. Event✅ No issues found. Project✅ No issues found. Person✅ No issues found. Organization✅ No issues found. Venue✅ No issues found. Resource✅ No issues found. Tag✅ No issues found. Category✅ No issues found. |
alexwolson
marked this pull request as ready for review
June 28, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140.
Adds an
actions/cache@v4step caching_site/assets/thumbs(wherejekyll_picture_tagwrites derivatives, preserved across builds via Jekyll'skeep_files) keyed onarchives/images/**, so unchanged-content CI builds regenerate no historical derivatives. The first run populates the cache; later no-image-change runs restore it and skip all generation. Adding/changing an image misses the exact key, restores the most recent cache viarestore-keys, regenerates only what changed, and saves a fresh cache.Why it's safe
JPT only generates a derivative when its output file is absent (
generate_image unless @source.missing || exists?), and generated filenames embed an MD5 of the source content ({name}-{width}-{hash}.webp). A changed source therefore produces a new filename and regenerates correctly — no stale-image risk. Only_site/assets/thumbsis cached, never HTML.Verification (local cold vs. warm build)
make cleanfirst)~4.5× faster with zero regeneration — the same skip behavior CI gains from the restored cache. Will confirm the pattern in post-merge CI logs (first run populates cache; next no-change run shows no
Generating new image file:lines).Out of scope
hacknight_549.avifwarning (Fix incorrect image extension for Meetup #549 (.avif → .png) #141)🤖 Generated with Claude Code