Release/epic 7 by Benevanio · Pull Request #168 · Cla-Code-Community/candidate

Benevanio · 2026-07-11T19:44:27Z

PR aberta Pelo @SilvioFelix32 para aprimoraramento dos testes

…d session management

…165)

Signed-off-by: Benevanio <benevaniosantos930@gmail.com>

…r authentication

#163) …d session management

Signed-off-by: Benevanio <benevaniosantos930@gmail.com>

Copilot

Pull request overview

Esta PR padroniza o tratamento/serialização de erros (frontend e backend) e ajusta/expande a suíte de testes para validar o novo envelope { code, message, details? }, incluindo validação via middleware e propagação consistente de AppError/ApiError.

Changes:

Frontend: adiciona ApiError + parseApiError e integra o parser via interceptor do Axios e via fetch no domínio de Auth.
Backend: introduz AppError, centraliza validação com middleware validate (Zod) e centraliza serialização no errorHandler.
Testes: atualiza testes unitários/integração para validar códigos (UNAUTHORIZED, NOT_FOUND, CONFLICT, etc.), detalhes de validação e cenários de ownership.

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
frontend/tests/unit/utils/apiError.test.ts	Novos testes unitários para `parseApiError` e envelopes/legado/fallback.
frontend/tests/unit/services/auth.service.test.tsx	Ajusta testes para envelope padronizado e valida `ApiError`/code.
frontend/src/shared/lib/apiError.ts	Implementa `ApiError` e `parseApiError` para padronizar parsing no frontend.
frontend/src/shared/lib/apiClient.ts	Adiciona interceptor do Axios para rejeitar com `ApiError` padronizado.
frontend/src/domains/auth/infrastructure/authApi.ts	Troca erros genéricos por `parseApiError` nas chamadas fetch do Auth.
backend/tests/unit/modules/users/users.service.test.ts	Atualiza asserts para `AppError` (code/statusCode/message).
backend/tests/unit/modules/users/user.controller.test.ts	Ajusta controller tests para exceções `AppError` e propagação de erros.
backend/tests/unit/modules/savedJobs/savedJobs.service.test.ts	Amplia cobertura: ownership, transições de status e códigos padronizados.
backend/tests/unit/modules/savedJobs/savedJobs.controller.test.ts	Ajusta testes para controllers lançarem `AppError` e propagarem erros.
backend/tests/unit/modules/auth/credentials.service.test.ts	Atualiza testes para `AppError` em conflict/unauthorized/notFound.
backend/tests/unit/modules/auth/credentials.controller.test.ts	Remove mocks de Zod e valida fluxo com `AppError` + middleware de validação.
backend/tests/unit/modules/auth/auth.controller.test.ts	Simplifica testes, removendo caso de validação direta no controller.
backend/tests/unit/middleware/withSession.test.ts	Novo teste unitário para middleware `withSession`.
backend/tests/unit/middleware/validate.test.ts	Novo teste unitário para middleware `validate` (body/query/params).
backend/tests/unit/middleware/requireAuth.test.ts	Novo teste unitário para `requireAuth` retornando envelope padronizado.
backend/tests/unit/middleware/errorHandler.test.ts	Expande testes do handler: AppError, ZodError e details por env.
backend/tests/unit/lib/errors.test.ts	Novos testes para factories/toJSON/fromZodError do `AppError`.
backend/tests/unit/app.test.ts	Ajusta asserts para envelope `{ code, message }` em erro de CORS.
backend/tests/integration/routes/user.routes.test.ts	Verifica envelope/`details` para validações (ex.: username inválido).
backend/tests/integration/routes/savedJobs.routes.test.ts	Atualiza integração para ownership, transições e envelopes padronizados.
backend/tests/integration/routes/auth.routes.test.ts	Atualiza integração para validação Zod via middleware e `AppError`.
backend/tests/integration/middleware/authGuards.test.ts	Novos testes de rotas protegidas (requireAuth) e exceções permitidas.
backend/src/routes/users.routes.ts	Encaminha promises com `.catch(next)` e aplica `validate` nos payloads.
backend/src/routes/savedJobs.routes.ts	Encaminha promises com `.catch(next)` e aplica `validate` nos payloads.
backend/src/routes/auth.routes.ts	Aplica `validate` para params/body e encaminha erros via `.catch(next)`.
backend/src/modules/users/users.service.ts	Troca `Error` genérico por `AppError.notFound` em cenários de ausência.
backend/src/modules/users/users.controller.ts	Remove try/catch local e passa a lançar `AppError` (handler central).
backend/src/modules/users/schemas/user.schemas.ts	Exporta `createPreferencesSchema` e tipos inferidos.
backend/src/modules/savedJobs/schemas/savedJobs.schemas.ts	Introduz schemas Zod para create/update (inclui enum status + appliedAt).
backend/src/modules/savedJobs/savedJobs.service.ts	Troca `Error` genérico por `AppError` (conflict/notFound).
backend/src/modules/savedJobs/savedJobs.controller.ts	Remove validação Zod inline/handler local e lança `AppError`.
backend/src/modules/auth/credentials.service.ts	Troca `Error` genérico por `AppError` (conflict/unauthorized/notFound).
backend/src/modules/auth/credentials.controller.ts	Remove validação/try-catch no controller; deixa handler/middleware centralizar.
backend/src/modules/auth/auth.controller.ts	Remove validação Zod no `getUrl` (assume validação em rota) e tipa provider.
backend/src/middleware/validate.ts	Novo middleware para validar body/query/params e converter ZodError em AppError.
backend/src/middleware/requireAuth.ts	Retorna envelope padronizado com `AppError.unauthorized().toJSON()`.
backend/src/middleware/errorHandler.ts	Centraliza serialização de `AppError` e conversão de ZodError + env gating de details.
backend/src/lib/errors.ts	Implementa `AppError` (factories, `fromZodError`, `toJSON`) e type guards.

@@ -7,8 +13,25 @@ export function errorHandler(
  _next: NextFunction,


+  const details = isProduction()
+    ? undefined
+    : { cause: error.message || "unknown" };
+  const appError = AppError.internal("Erro interno.", details);


  const payload = await parseResponse(response);
-
-  if (!response.ok) {
-    throw createError(payload, "Falha ao obter URL de autenticacao Google.");
-  }
-
-  return payload.url;
+  throwIfNotOk(response, payload, "Falha ao obter URL de autenticacao Google.");
+  return (payload as { url: string }).url;


  const payload = await parseResponse(response);
-
-  if (!response.ok) {
-    throw createError(payload, "Falha ao obter URL de autenticacao Github.");
-  }
-
-  return payload.url;
+  throwIfNotOk(response, payload, "Falha ao obter URL de autenticacao Github.");
+  return (payload as { url: string }).url;


+    response,
+    payload,
+    "Falha ao obter URL de autenticacao LinkedIn.",
+  );
+  return (payload as { url: string }).url;


+function asCode(value: unknown): ApiErrorCode | undefined {
+  const code = asString(value);
+  if (!code) return undefined;
+
+  const known: ApiErrorCode[] = [
+    "VALIDATION_ERROR",
+    "UNAUTHORIZED",
+    "FORBIDDEN",
+    "NOT_FOUND",
+    "CONFLICT",
+    "INTERNAL_ERROR",
+    "UNKNOWN_ERROR",
+  ];
+
+  return known.includes(code as ApiErrorCode)
+    ? (code as ApiErrorCode)
+    : "UNKNOWN_ERROR";
+}


nayarakarinesilva

🚀

SilvioFelix32 and others added 6 commits July 9, 2026 11:48

feat: add integration and unit tests for authentication middleware an…

982788c

…d session management

feat: PAV-33: api error contract handler (code / message / details)

1f18ba0

feat: PAV-33: api error contract handler (code / message / details) (#…

946ee65

…165)

Merge branch 'release/EPIC-7' into feature/PAV-31

e7e7b56

Signed-off-by: Benevanio <benevaniosantos930@gmail.com>

feat: update error responses to include code and message structure fo…

8107d16

…r authentication

feat: add integration and unit tests for authentication middleware an… (

7118999

#163) …d session management

Copilot AI review requested due to automatic review settings July 11, 2026 19:44

Benevanio requested review from hltav, lima300 and nayarakarinesilva as code owners July 11, 2026 19:44

github-project-automation Bot added this to JobAtlas – Kanban Jul 11, 2026

github-project-automation Bot moved this to Backlog in JobAtlas – Kanban Jul 11, 2026

Benevanio removed the request for review from Copilot July 11, 2026 19:44

Copilot started reviewing on behalf of Benevanio July 11, 2026 19:44 View session

Merge branch 'master' into release/EPIC-7

7d12b92

Signed-off-by: Benevanio <benevaniosantos930@gmail.com>

Copilot AI review requested due to automatic review settings July 11, 2026 19:45

Copilot started reviewing on behalf of Benevanio July 11, 2026 19:46 View session

Benevanio closed this Jul 11, 2026

github-project-automation Bot moved this from Backlog to Done in JobAtlas – Kanban Jul 11, 2026

Copilot AI reviewed Jul 11, 2026

View reviewed changes

nayarakarinesilva approved these changes Jul 11, 2026

View reviewed changes

Benevanio deleted the release/EPIC-7 branch July 12, 2026 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release/epic 7#168

Release/epic 7#168
Benevanio wants to merge 7 commits into
masterfrom
release/EPIC-7

Benevanio commented Jul 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

nayarakarinesilva left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -7,8 +13,25 @@ export function errorHandler(
		_next: NextFunction,

Uh oh!

Conversation

Benevanio commented Jul 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

nayarakarinesilva left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants